From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDEDDC7EE2F for ; Mon, 5 Jun 2023 12:08:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233256AbjFEMIY (ORCPT ); Mon, 5 Jun 2023 08:08:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229815AbjFEMIW (ORCPT ); Mon, 5 Jun 2023 08:08:22 -0400 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66E6B92; Mon, 5 Jun 2023 05:08:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1685966901; x=1717502901; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=dQT6oVcoi6OibIBbA3hTG2i3vMqElgYwkRHP4oreT70=; b=Jy9z2fXDE2qtQ1lqdFjdSSv3OFFyUsvnrDAtls8Lz7O+vre+hby6wRkb 2eg8yY1nJdM3WDrNHMwdbYK7oxxIMCYD4ihvxIyOHM2tS441oGoXrHVcu SS4dQs2a3WOapQ+NrPC61tcGW9gNEHhnvA20BLNl3fqcjBe9U6rTJUPKS lHQu1lNA2pkYLeXve66pfzLyGvUxaurrkQDe6HUL9nDb5SsTa8bxx6wli 0bAALD/ykGl0iENyxunBdInRUkaZr7Oti9OIQ1MESnCMTUEmcsbPquKaL hKFt/9c7QZZXEyBPYPWhX+sMJm/HASBa3v7x8mMl9K0V211OR5bow1g/a w==; X-IronPort-AV: E=Sophos;i="6.00,217,1681196400"; d="scan'208";a="214645686" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa4.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 05 Jun 2023 05:08:19 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Mon, 5 Jun 2023 05:07:46 -0700 Received: from [10.159.245.112] (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.2507.21 via Frontend Transport; Mon, 5 Jun 2023 05:07:39 -0700 Message-ID: <3e262485-bf5f-1a98-e399-e02add3eaa89@microchip.com> Date: Mon, 5 Jun 2023 14:07:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 21/21] net: macb: add support for gmac to sam9x7 Content-Language: en-US To: Krzysztof Kozlowski , Varshini Rajendran , , , , , , , , , , , , , , , , , , , , , , , , , , , , , CC: , , , , , , References: <20230603200243.243878-1-varshini.rajendran@microchip.com> <20230603200243.243878-22-varshini.rajendran@microchip.com> From: Nicolas Ferre Organization: microchip In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/06/2023 at 08:42, Krzysztof Kozlowski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On 03/06/2023 22:02, Varshini Rajendran wrote: >> From: Nicolas Ferre >> >> Add support for GMAC in sam9x7 SoC family >> >> Signed-off-by: Varshini Rajendran >> Signed-off-by: Nicolas Ferre >> --- >> drivers/net/ethernet/cadence/macb_main.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c >> index 29a1199dad14..609c8e9305ba 100644 >> --- a/drivers/net/ethernet/cadence/macb_main.c >> +++ b/drivers/net/ethernet/cadence/macb_main.c >> @@ -4913,6 +4913,7 @@ static const struct of_device_id macb_dt_ids[] = { >> { .compatible = "microchip,mpfs-macb", .data = &mpfs_config }, >> { .compatible = "microchip,sama7g5-gem", .data = &sama7g5_gem_config }, >> { .compatible = "microchip,sama7g5-emac", .data = &sama7g5_emac_config }, >> + { .compatible = "microchip,sam9x7-gem", .data = &sama7g5_gem_config }, > > These are compatible, aren't they? Why do you need new entry? The hardware itself is different, even if the new features are not supported yet in the macb driver. The macb driver will certainly evolve in order to add these features so we decided to match a new compatible string all the way to the driver. Best regards, Nicolas -- Nicolas Ferre From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6AFF3C7EE24 for ; Mon, 5 Jun 2023 12:08:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xsAC8DnYGytLlcFXf+4y37v6BqdrM7ycqT4DLQvhXE8=; b=b9hLxibgncd08+ ECDhHeOPCMSuB1PiF7S37y41JLilCbPYurRyguBTuUyMq1lblt0vWCR1oqpbvddi1t0EsLk/0yytv Ge7WyWiXqW/UmNBsA4zS9jIdTqUsFosheqv81IcIbnFGFi6ASlw/IIL5YQDwcuy4Tp9GS6Bd0lExB DfT54Tp272Fa0njwff4M/dpgHomTwcJKs3a5/dQVTH5b3R7VYw+GNpIWK92C5FOYjhWsr7uRHRkHb AxBHV11ewUNw+RpdunQxGYYAErsDN7k5i5WTUlqvT1Fp9XdUb0GRdkMR6TrgbvHbAkcEZlLhBHu9c w2cGOYurqAH/jfKJWn9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q690c-00FNpp-2z; Mon, 05 Jun 2023 12:08:26 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q690Z-00FNoq-2b for linux-arm-kernel@lists.infradead.org; Mon, 05 Jun 2023 12:08:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1685966904; x=1717502904; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=dQT6oVcoi6OibIBbA3hTG2i3vMqElgYwkRHP4oreT70=; b=WcCFUW6Ig+PFSh8bIHArC68o0UlvpE4fl6/dTt2I0i1rivOP9o6cr8dQ US9VLKJJopg7E9BfrPbVDXY6LfF8nwmmstNNgmYveh3VXGVFqRJ3axDvK t2QffWsZkpxFSwDF+ZacTmVQ351tdK+jLgtMOgwKp7SlO2Vm5JorFjfli gCHQpNR7CxwY2g1FH6q1OEfEG2Qepl3YpP3b9msGvEUMLXSBkLSRkYZqw 3bMfnr8oTvQf+MlzNfk6H9zM5x6WkYonA0QYMCykct4CSpix+76JH1VJK AHtlEAPD1W5ylSHdf8kOpAGxAJgh/0YpVC/kWh6IMIZ5ftm4vEJzwB8TH Q==; X-IronPort-AV: E=Sophos;i="6.00,217,1681196400"; d="scan'208";a="214645686" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa4.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 05 Jun 2023 05:08:19 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Mon, 5 Jun 2023 05:07:46 -0700 Received: from [10.159.245.112] (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.2507.21 via Frontend Transport; Mon, 5 Jun 2023 05:07:39 -0700 Message-ID: <3e262485-bf5f-1a98-e399-e02add3eaa89@microchip.com> Date: Mon, 5 Jun 2023 14:07:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 21/21] net: macb: add support for gmac to sam9x7 Content-Language: en-US To: Krzysztof Kozlowski , Varshini Rajendran , , , , , , , , , , , , , , , , , , , , , , , , , , , , , CC: , , , , , , References: <20230603200243.243878-1-varshini.rajendran@microchip.com> <20230603200243.243878-22-varshini.rajendran@microchip.com> From: Nicolas Ferre Organization: microchip In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230605_050823_930951_1DCB72B6 X-CRM114-Status: GOOD ( 14.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 05/06/2023 at 08:42, Krzysztof Kozlowski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On 03/06/2023 22:02, Varshini Rajendran wrote: >> From: Nicolas Ferre >> >> Add support for GMAC in sam9x7 SoC family >> >> Signed-off-by: Varshini Rajendran >> Signed-off-by: Nicolas Ferre >> --- >> drivers/net/ethernet/cadence/macb_main.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c >> index 29a1199dad14..609c8e9305ba 100644 >> --- a/drivers/net/ethernet/cadence/macb_main.c >> +++ b/drivers/net/ethernet/cadence/macb_main.c >> @@ -4913,6 +4913,7 @@ static const struct of_device_id macb_dt_ids[] = { >> { .compatible = "microchip,mpfs-macb", .data = &mpfs_config }, >> { .compatible = "microchip,sama7g5-gem", .data = &sama7g5_gem_config }, >> { .compatible = "microchip,sama7g5-emac", .data = &sama7g5_emac_config }, >> + { .compatible = "microchip,sam9x7-gem", .data = &sama7g5_gem_config }, > > These are compatible, aren't they? Why do you need new entry? The hardware itself is different, even if the new features are not supported yet in the macb driver. The macb driver will certainly evolve in order to add these features so we decided to match a new compatible string all the way to the driver. Best regards, Nicolas -- Nicolas Ferre _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel