From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F4F8C433E7 for ; Fri, 9 Oct 2020 13:27:23 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 07C7320658 for ; Fri, 9 Oct 2020 13:27:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 07C7320658 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55682 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQsQc-0002Ck-1w for qemu-devel@archiver.kernel.org; Fri, 09 Oct 2020 09:27:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53844) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQqFS-00035b-46; Fri, 09 Oct 2020 07:07:42 -0400 Received: from foss.arm.com ([217.140.110.172]:40786) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQqFP-0007vT-Io; Fri, 09 Oct 2020 07:07:41 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4E291D6E; Fri, 9 Oct 2020 04:07:36 -0700 (PDT) Received: from [10.37.12.22] (unknown [10.37.12.22]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4FCC23F66B; Fri, 9 Oct 2020 04:07:35 -0700 (PDT) Subject: Re: [PATCH 2/3] target/arm: Fix reported EL for mte_check_fail To: Richard Henderson , qemu-devel@nongnu.org References: <20201008162155.161886-1-richard.henderson@linaro.org> <20201008162155.161886-3-richard.henderson@linaro.org> From: Vincenzo Frascino Message-ID: <3e2f2248-8810-bf72-a498-91fa65eeded9@arm.com> Date: Fri, 9 Oct 2020 12:10:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201008162155.161886-3-richard.henderson@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=217.140.110.172; envelope-from=vincenzo.frascino@arm.com; helo=foss.arm.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/09 07:07:36 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.208, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Fri, 09 Oct 2020 09:26:13 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 10/8/20 5:21 PM, Richard Henderson wrote: > The reporting in AArch64.TagCheckFail only depends on PSTATE.EL, > and not the AccType of the operation. There are two guest > visible problems that affect LDTR and STTR because of this: > > (1) Selecting TCF0 vs TCF1 to decide on reporting, > (2) Report "data abort same el" not "data abort lower el". > > Reported-by: Vincenzo Frascino > Signed-off-by: Richard Henderson Reviewed-by: Vincenzo Frascino Tested-by: Vincenzo Frascino > --- > target/arm/mte_helper.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/target/arm/mte_helper.c b/target/arm/mte_helper.c > index 734cc5ca67..153bd1e9df 100644 > --- a/target/arm/mte_helper.c > +++ b/target/arm/mte_helper.c > @@ -525,14 +525,10 @@ static void mte_check_fail(CPUARMState *env, uint32_t desc, > reg_el = regime_el(env, arm_mmu_idx); > sctlr = env->cp15.sctlr_el[reg_el]; > > - switch (arm_mmu_idx) { > - case ARMMMUIdx_E10_0: > - case ARMMMUIdx_E20_0: > - el = 0; > + el = arm_current_el(env); > + if (el == 0) { > tcf = extract64(sctlr, 38, 2); > - break; > - default: > - el = reg_el; > + } else { > tcf = extract64(sctlr, 40, 2); > } > > -- Regards, Vincenzo