* [Buildroot] [PATCH] package/udev: move render and sgx out of UDEV_USERS
@ 2022-04-25 11:11 TIAN Yuanhao
2022-04-27 18:52 ` Arnout Vandecappelle
2022-04-28 11:39 ` [Buildroot] [PATCH v2] package/udev: move render and sgx to package/systemd TIAN Yuanhao
0 siblings, 2 replies; 5+ messages in thread
From: TIAN Yuanhao @ 2022-04-25 11:11 UTC (permalink / raw)
To: buildroot; +Cc: TIAN Yuanhao, Yann E . MORIN
Moved group render and group sgx into UDEV_USERS_SYSTEMD as they
currently only appear in systemd's udev rules.
In systemd, group render was introduced since commit 4e15a73, and group
sgx was introduced since commit c9c4899.
In eudev, group render was introduced since commit bb070c1, but was
removed since commit a8ffcd1 [1].
[1]: https://github.com/eudev-project/eudev/issues/160
Signed-off-by: TIAN Yuanhao <tianyuanhao3@163.com>
Cc: Yann E. MORIN <yann.morin.1998@free.fr>
---
package/systemd/systemd.mk | 2 --
package/udev/udev.mk | 7 +++++--
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/package/systemd/systemd.mk b/package/systemd/systemd.mk
index 58a1376b51..1f2bc108bf 100644
--- a/package/systemd/systemd.mk
+++ b/package/systemd/systemd.mk
@@ -602,8 +602,6 @@ define SYSTEMD_PERMISSIONS
endef
define SYSTEMD_USERS
- # udev user groups
- # systemd user groups
- - systemd-journal -1 * - - - Journal
$(SYSTEMD_REMOTE_USER)
$(SYSTEMD_COREDUMP_USER)
diff --git a/package/udev/udev.mk b/package/udev/udev.mk
index ce93d98431..40d12ad469 100644
--- a/package/udev/udev.mk
+++ b/package/udev/udev.mk
@@ -4,11 +4,14 @@
#
################################################################################
-# Required by default rules for input devices
define UDEV_USERS
- - input -1 * - - - Input device group
- - - render -1 * - - - DRI rendering nodes
- - kvm -1 * - - - kvm nodes
+ $(UDEV_USERS_$(call UPPERCASE,$(call qstrip,$(BR2_PACKAGE_PROVIDES_UDEV))))
+endef
+
+define UDEV_USERS_SYSTEMD
+ - - render -1 * - - - DRI rendering nodes
- - sgx -1 * - - - SGX device nodes
endef
--
2.35.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH] package/udev: move render and sgx out of UDEV_USERS
2022-04-25 11:11 [Buildroot] [PATCH] package/udev: move render and sgx out of UDEV_USERS TIAN Yuanhao
@ 2022-04-27 18:52 ` Arnout Vandecappelle
2022-04-28 11:39 ` [Buildroot] [PATCH v2] package/udev: move render and sgx to package/systemd TIAN Yuanhao
1 sibling, 0 replies; 5+ messages in thread
From: Arnout Vandecappelle @ 2022-04-27 18:52 UTC (permalink / raw)
To: TIAN Yuanhao, buildroot; +Cc: Yann E . MORIN
On 25/04/2022 13:11, TIAN Yuanhao wrote:
> Moved group render and group sgx into UDEV_USERS_SYSTEMD as they
> currently only appear in systemd's udev rules.
>
> In systemd, group render was introduced since commit 4e15a73, and group
> sgx was introduced since commit c9c4899.
>
> In eudev, group render was introduced since commit bb070c1, but was
> removed since commit a8ffcd1 [1].
>
> [1]: https://github.com/eudev-project/eudev/issues/160
>
> Signed-off-by: TIAN Yuanhao <tianyuanhao3@163.com>
> Cc: Yann E. MORIN <yann.morin.1998@free.fr>
> ---
> package/systemd/systemd.mk | 2 --
> package/udev/udev.mk | 7 +++++--
> 2 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/package/systemd/systemd.mk b/package/systemd/systemd.mk
> index 58a1376b51..1f2bc108bf 100644
> --- a/package/systemd/systemd.mk
> +++ b/package/systemd/systemd.mk
> @@ -602,8 +602,6 @@ define SYSTEMD_PERMISSIONS
> endef
>
> define SYSTEMD_USERS
> - # udev user groups
> - # systemd user groups
> - - systemd-journal -1 * - - - Journal
> $(SYSTEMD_REMOTE_USER)
> $(SYSTEMD_COREDUMP_USER)
> diff --git a/package/udev/udev.mk b/package/udev/udev.mk
> index ce93d98431..40d12ad469 100644
> --- a/package/udev/udev.mk
> +++ b/package/udev/udev.mk
> @@ -4,11 +4,14 @@
> #
> ################################################################################
>
> -# Required by default rules for input devices
> define UDEV_USERS
> - - input -1 * - - - Input device group
> - - - render -1 * - - - DRI rendering nodes
> - - kvm -1 * - - - kvm nodes
> + $(UDEV_USERS_$(call UPPERCASE,$(call qstrip,$(BR2_PACKAGE_PROVIDES_UDEV))))
There is really no reason to do it this way. You can simply put it in
SYSTEMD_USERS (under the 'udev groups' comment).
If we need additional groups for eudev, we can put them in EUDEV_USERS.
Regards,
Arnout
> +endef
> +
> +define UDEV_USERS_SYSTEMD
> + - - render -1 * - - - DRI rendering nodes
> - - sgx -1 * - - - SGX device nodes
> endef
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v2] package/udev: move render and sgx to package/systemd
2022-04-25 11:11 [Buildroot] [PATCH] package/udev: move render and sgx out of UDEV_USERS TIAN Yuanhao
2022-04-27 18:52 ` Arnout Vandecappelle
@ 2022-04-28 11:39 ` TIAN Yuanhao
2022-04-28 15:35 ` Yann E. MORIN
2022-05-27 9:42 ` Peter Korsgaard
1 sibling, 2 replies; 5+ messages in thread
From: TIAN Yuanhao @ 2022-04-28 11:39 UTC (permalink / raw)
To: buildroot; +Cc: Carlos Santos, TIAN Yuanhao, Yann E . MORIN
Moved groups render and sgx from UDEV_USERS to SYSTEMD_USERS as they
currently only appear in systemd's udev rules.
In systemd, group render was introduced since commit 4e15a73, and group
sgx was introduced since commit c9c4899.
In eudev, group render was introduced since commit bb070c1, but was
removed since commit a8ffcd1 [1].
[1]: https://github.com/eudev-project/eudev/issues/160
Signed-off-by: TIAN Yuanhao <tianyuanhao3@163.com>
Cc: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Cc: Carlos Santos <unixmania@gmail.com>
Cc: Yann E. MORIN <yann.morin.1998@free.fr>
---
Changes v2: UDEV_USERS_SYSTEMD to SYSTEMD_USERS
---
package/systemd/systemd.mk | 2 ++
package/udev/udev.mk | 4 +---
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/package/systemd/systemd.mk b/package/systemd/systemd.mk
index 58a1376b51..7a711319cf 100644
--- a/package/systemd/systemd.mk
+++ b/package/systemd/systemd.mk
@@ -603,6 +603,8 @@ endef
define SYSTEMD_USERS
# udev user groups
+ - - render -1 * - - - DRI rendering nodes
+ - - sgx -1 * - - - SGX device nodes
# systemd user groups
- - systemd-journal -1 * - - - Journal
$(SYSTEMD_REMOTE_USER)
diff --git a/package/udev/udev.mk b/package/udev/udev.mk
index ce93d98431..d70d13ebb3 100644
--- a/package/udev/udev.mk
+++ b/package/udev/udev.mk
@@ -4,12 +4,10 @@
#
################################################################################
-# Required by default rules for input devices
+# Required by default rules
define UDEV_USERS
- - input -1 * - - - Input device group
- - - render -1 * - - - DRI rendering nodes
- - kvm -1 * - - - kvm nodes
- - - sgx -1 * - - - SGX device nodes
endef
$(eval $(virtual-package))
--
2.35.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH v2] package/udev: move render and sgx to package/systemd
2022-04-28 11:39 ` [Buildroot] [PATCH v2] package/udev: move render and sgx to package/systemd TIAN Yuanhao
@ 2022-04-28 15:35 ` Yann E. MORIN
2022-05-27 9:42 ` Peter Korsgaard
1 sibling, 0 replies; 5+ messages in thread
From: Yann E. MORIN @ 2022-04-28 15:35 UTC (permalink / raw)
To: TIAN Yuanhao; +Cc: Carlos Santos, buildroot
Yuanhao, All,
On 2022-04-28 04:39 -0700, TIAN Yuanhao spake thusly:
> Moved groups render and sgx from UDEV_USERS to SYSTEMD_USERS as they
> currently only appear in systemd's udev rules.
>
> In systemd, group render was introduced since commit 4e15a73, and group
> sgx was introduced since commit c9c4899.
>
> In eudev, group render was introduced since commit bb070c1, but was
> removed since commit a8ffcd1 [1].
>
> [1]: https://github.com/eudev-project/eudev/issues/160
>
> Signed-off-by: TIAN Yuanhao <tianyuanhao3@163.com>
> Cc: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> Cc: Carlos Santos <unixmania@gmail.com>
> Cc: Yann E. MORIN <yann.morin.1998@free.fr>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
>
> Changes v2: UDEV_USERS_SYSTEMD to SYSTEMD_USERS
> ---
> package/systemd/systemd.mk | 2 ++
> package/udev/udev.mk | 4 +---
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/package/systemd/systemd.mk b/package/systemd/systemd.mk
> index 58a1376b51..7a711319cf 100644
> --- a/package/systemd/systemd.mk
> +++ b/package/systemd/systemd.mk
> @@ -603,6 +603,8 @@ endef
>
> define SYSTEMD_USERS
> # udev user groups
> + - - render -1 * - - - DRI rendering nodes
> + - - sgx -1 * - - - SGX device nodes
> # systemd user groups
> - - systemd-journal -1 * - - - Journal
> $(SYSTEMD_REMOTE_USER)
> diff --git a/package/udev/udev.mk b/package/udev/udev.mk
> index ce93d98431..d70d13ebb3 100644
> --- a/package/udev/udev.mk
> +++ b/package/udev/udev.mk
> @@ -4,12 +4,10 @@
> #
> ################################################################################
>
> -# Required by default rules for input devices
> +# Required by default rules
> define UDEV_USERS
> - - input -1 * - - - Input device group
> - - - render -1 * - - - DRI rendering nodes
> - - kvm -1 * - - - kvm nodes
> - - - sgx -1 * - - - SGX device nodes
> endef
>
> $(eval $(virtual-package))
> --
> 2.35.1
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH v2] package/udev: move render and sgx to package/systemd
2022-04-28 11:39 ` [Buildroot] [PATCH v2] package/udev: move render and sgx to package/systemd TIAN Yuanhao
2022-04-28 15:35 ` Yann E. MORIN
@ 2022-05-27 9:42 ` Peter Korsgaard
1 sibling, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2022-05-27 9:42 UTC (permalink / raw)
To: TIAN Yuanhao; +Cc: Carlos Santos, Yann E . MORIN, buildroot
>>>>> "TIAN" == TIAN Yuanhao <tianyuanhao3@163.com> writes:
> Moved groups render and sgx from UDEV_USERS to SYSTEMD_USERS as they
> currently only appear in systemd's udev rules.
> In systemd, group render was introduced since commit 4e15a73, and group
> sgx was introduced since commit c9c4899.
> In eudev, group render was introduced since commit bb070c1, but was
> removed since commit a8ffcd1 [1].
> [1]: https://github.com/eudev-project/eudev/issues/160
> Signed-off-by: TIAN Yuanhao <tianyuanhao3@163.com>
> Cc: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> Cc: Carlos Santos <unixmania@gmail.com>
> Cc: Yann E. MORIN <yann.morin.1998@free.fr>
> ---
> Changes v2: UDEV_USERS_SYSTEMD to SYSTEMD_USERS
Committed to 2022.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-05-27 9:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-25 11:11 [Buildroot] [PATCH] package/udev: move render and sgx out of UDEV_USERS TIAN Yuanhao
2022-04-27 18:52 ` Arnout Vandecappelle
2022-04-28 11:39 ` [Buildroot] [PATCH v2] package/udev: move render and sgx to package/systemd TIAN Yuanhao
2022-04-28 15:35 ` Yann E. MORIN
2022-05-27 9:42 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.