From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60E23C433EF for ; Tue, 15 Feb 2022 20:09:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242392AbiBOUJL (ORCPT ); Tue, 15 Feb 2022 15:09:11 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:42070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243992AbiBOUJJ (ORCPT ); Tue, 15 Feb 2022 15:09:09 -0500 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A55F2B0C41; Tue, 15 Feb 2022 12:08:58 -0800 (PST) Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 21FJsadO014857; Tue, 15 Feb 2022 20:08:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding; s=pp1; bh=CZO2vVfbTb0RbiaMRH3DHFFoOpbO0f4KMW0LM2NECLI=; b=oHf2pcsnXBfk3reeAPkZi0So1/lIhu7AWhDYN8eK1iTpyHZ4e5PVzlNJj74bcKKjZnxz xexiRwoCuuj0MsYlkN1bSyNEjC+0d9y/gfvW7YHD0hsqiC3RH3sWxTn7Nt9YAjSCWCDP cec4IT2DJ7GXwXzn+qKp3upiFbWPORrcsBtvZyC0HutqUTNZIUCA0i6pbrVEpKSE1w3a XYviHlFtgWAH6Q/21AFmW9HyiREM2f6bC0D8Wyze22zFPZRiDYMsk0OUD6FFPqpcYfyL OilFNaNYlAaKnGBY4L02DjP9U5qwCGoRJRkd+8T02n55uHQJODB952sYGXo/5KH2y/xo LA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3e8jre8bgb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Feb 2022 20:08:27 +0000 Received: from m0098417.ppops.net (m0098417.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 21FK3cwE028627; Tue, 15 Feb 2022 20:08:26 GMT Received: from ppma04ams.nl.ibm.com (63.31.33a9.ip4.static.sl-reverse.com [169.51.49.99]) by mx0a-001b2d01.pphosted.com with ESMTP id 3e8jre8bfp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Feb 2022 20:08:26 +0000 Received: from pps.filterd (ppma04ams.nl.ibm.com [127.0.0.1]) by ppma04ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 21FK2VEW007429; Tue, 15 Feb 2022 20:08:24 GMT Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by ppma04ams.nl.ibm.com with ESMTP id 3e64ha2gn2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Feb 2022 20:08:24 +0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 21FK8LNN44958156 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 15 Feb 2022 20:08:21 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6638211C04C; Tue, 15 Feb 2022 20:08:21 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A1B5511C054; Tue, 15 Feb 2022 20:08:18 +0000 (GMT) Received: from sig-9-65-88-149.ibm.com (unknown [9.65.88.149]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 15 Feb 2022 20:08:18 +0000 (GMT) Message-ID: <3e39412657a4b0839bcf38544d591959e89877b8.camel@linux.ibm.com> Subject: Re: [PATCH 4/4] module, KEYS: Make use of platform keyring for signature verification From: Mimi Zohar To: Michal Suchanek Cc: Catalin Marinas , Will Deacon , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Philipp Rudo , Baoquan He , Alexander Egorenkov , AKASHI Takahiro , James Morse , Dave Young , Kairui Song , Martin Schwidefsky , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-modules@vger.kernel.org, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, stable@kernel.org, Eric Snowberg Date: Tue, 15 Feb 2022 15:08:18 -0500 In-Reply-To: <840433bc93a58d6dfc4d96c34c0c3b158a0e669d.1644953683.git.msuchanek@suse.de> References: <840433bc93a58d6dfc4d96c34c0c3b158a0e669d.1644953683.git.msuchanek@suse.de> Content-Type: text/plain; charset="ISO-8859-15" X-Mailer: Evolution 3.28.5 (3.28.5-18.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 0GR9onIvF1UifqvAn0Td1dXMzNG0In9Z X-Proofpoint-ORIG-GUID: aoAH1LPXWXCnZNv3qt9jCU3grFgSYc55 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-02-15_06,2022-02-14_04,2021-12-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 lowpriorityscore=0 mlxscore=0 malwarescore=0 impostorscore=0 priorityscore=1501 suspectscore=0 clxscore=1011 spamscore=0 phishscore=0 adultscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2202150113 Precedence: bulk List-ID: X-Mailing-List: keyrings@vger.kernel.org [Cc'ing Eric Snowberg] Hi Michal, On Tue, 2022-02-15 at 20:39 +0100, Michal Suchanek wrote: > Commit 278311e417be ("kexec, KEYS: Make use of platform keyring for signature verify") > adds support for use of platform keyring in kexec verification but > support for modules is missing. > > Add support for verification of modules with keys from platform keyring > as well. Permission for loading the pre-OS keys onto the "platform" keyring and using them is limited to verifying the kexec kernel image, nothing else. FYI, Eric Snowberg's initial patch set titled "[PATCH v10 0/8] Enroll kernel keys thru MOK" is queued in Jarkko's git repo to be usptreamed. A subsequent patch set is expected. -- thanks, Mimi [1] Message-Id: <20211124044124.998170-11-eric.snowberg@oracle.com> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 588FFC433EF for ; Tue, 15 Feb 2022 20:09:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=70X24CrHCTI00ZAlC1djcEihPMUaNjsBjkOaPKX/Cv0=; b=Ru+I+0LaiLmgTJ b9VbDJF5A0s09TLnTqeybfJQHJshE2k3yJo9coCqNkuYMzr/tY2bJwTpBWdIKkYI6CLlpZFO6k/zW PFRuYJFPMbv4IK33UXv1l9i9GM9hcT1rEaFB1chuIs/m1e/405vKgskYE6L3FBDyElYd6YN9ta+Ur 7wl/72sb/kH9/LLZq5mGVnCnYXTdhMbAKbfUosILu9fatjmilkxiB6h0ptH0Ta3lqzXoSSW8wN5CV X5TwiiM6AcgtWfz8AgVjH6Pvn4tj62QuZzS3V5tjTT3vZbVFxidCLtrxgt6en1/3xdXh/GomEqLly wgWa01ocUSD5ZgyIXY7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nK47s-004Tth-15; Tue, 15 Feb 2022 20:08:40 +0000 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nK47l-004TsJ-24 for linux-arm-kernel@lists.infradead.org; Tue, 15 Feb 2022 20:08:38 +0000 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 21FJsadO014857; Tue, 15 Feb 2022 20:08:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding; s=pp1; bh=CZO2vVfbTb0RbiaMRH3DHFFoOpbO0f4KMW0LM2NECLI=; b=oHf2pcsnXBfk3reeAPkZi0So1/lIhu7AWhDYN8eK1iTpyHZ4e5PVzlNJj74bcKKjZnxz xexiRwoCuuj0MsYlkN1bSyNEjC+0d9y/gfvW7YHD0hsqiC3RH3sWxTn7Nt9YAjSCWCDP cec4IT2DJ7GXwXzn+qKp3upiFbWPORrcsBtvZyC0HutqUTNZIUCA0i6pbrVEpKSE1w3a XYviHlFtgWAH6Q/21AFmW9HyiREM2f6bC0D8Wyze22zFPZRiDYMsk0OUD6FFPqpcYfyL OilFNaNYlAaKnGBY4L02DjP9U5qwCGoRJRkd+8T02n55uHQJODB952sYGXo/5KH2y/xo LA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3e8jre8bgb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Feb 2022 20:08:27 +0000 Received: from m0098417.ppops.net (m0098417.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 21FK3cwE028627; Tue, 15 Feb 2022 20:08:26 GMT Received: from ppma04ams.nl.ibm.com (63.31.33a9.ip4.static.sl-reverse.com [169.51.49.99]) by mx0a-001b2d01.pphosted.com with ESMTP id 3e8jre8bfp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Feb 2022 20:08:26 +0000 Received: from pps.filterd (ppma04ams.nl.ibm.com [127.0.0.1]) by ppma04ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 21FK2VEW007429; Tue, 15 Feb 2022 20:08:24 GMT Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by ppma04ams.nl.ibm.com with ESMTP id 3e64ha2gn2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Feb 2022 20:08:24 +0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 21FK8LNN44958156 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 15 Feb 2022 20:08:21 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6638211C04C; Tue, 15 Feb 2022 20:08:21 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A1B5511C054; Tue, 15 Feb 2022 20:08:18 +0000 (GMT) Received: from sig-9-65-88-149.ibm.com (unknown [9.65.88.149]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 15 Feb 2022 20:08:18 +0000 (GMT) Message-ID: <3e39412657a4b0839bcf38544d591959e89877b8.camel@linux.ibm.com> Subject: Re: [PATCH 4/4] module, KEYS: Make use of platform keyring for signature verification From: Mimi Zohar To: Michal Suchanek Cc: Catalin Marinas , Will Deacon , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Philipp Rudo , Baoquan He , Alexander Egorenkov , AKASHI Takahiro , James Morse , Dave Young , Kairui Song , Martin Schwidefsky , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-modules@vger.kernel.org, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, stable@kernel.org, Eric Snowberg Date: Tue, 15 Feb 2022 15:08:18 -0500 In-Reply-To: <840433bc93a58d6dfc4d96c34c0c3b158a0e669d.1644953683.git.msuchanek@suse.de> References: <840433bc93a58d6dfc4d96c34c0c3b158a0e669d.1644953683.git.msuchanek@suse.de> X-Mailer: Evolution 3.28.5 (3.28.5-18.el8) Mime-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 0GR9onIvF1UifqvAn0Td1dXMzNG0In9Z X-Proofpoint-ORIG-GUID: aoAH1LPXWXCnZNv3qt9jCU3grFgSYc55 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-02-15_06,2022-02-14_04,2021-12-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 lowpriorityscore=0 mlxscore=0 malwarescore=0 impostorscore=0 priorityscore=1501 suspectscore=0 clxscore=1011 spamscore=0 phishscore=0 adultscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2202150113 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220215_120833_378973_292A7835 X-CRM114-Status: GOOD ( 17.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org [Cc'ing Eric Snowberg] Hi Michal, On Tue, 2022-02-15 at 20:39 +0100, Michal Suchanek wrote: > Commit 278311e417be ("kexec, KEYS: Make use of platform keyring for signature verify") > adds support for use of platform keyring in kexec verification but > support for modules is missing. > > Add support for verification of modules with keys from platform keyring > as well. Permission for loading the pre-OS keys onto the "platform" keyring and using them is limited to verifying the kexec kernel image, nothing else. FYI, Eric Snowberg's initial patch set titled "[PATCH v10 0/8] Enroll kernel keys thru MOK" is queued in Jarkko's git repo to be usptreamed. A subsequent patch set is expected. -- thanks, Mimi [1] Message-Id: <20211124044124.998170-11-eric.snowberg@oracle.com> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel