From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752242AbdLFUT2 (ORCPT ); Wed, 6 Dec 2017 15:19:28 -0500 Received: from mail-by2nam03on0047.outbound.protection.outlook.com ([104.47.42.47]:31360 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751544AbdLFUTV (ORCPT ); Wed, 6 Dec 2017 15:19:21 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Janakarajan.Natarajan@amd.com; Subject: Re: [PATCH v2 3/4] Add support for AMD Core Perf Extension in guest To: Radim Krcmar Cc: Borislav Petkov , Paolo Bonzini , kvm@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , Len Brown , Kyle Huey , Kan Liang , Grzegorz Andrejczuk , Tom Lendacky , Tony Luck References: <5113a9d6e76d2c6050c1fba4007068340321521c.1509985085.git.Janakarajan.Natarajan@amd.com> <20171109183425.rhqc5wrltznt5tcf@pd.tnic> <07f23e5e-2747-b0bc-1b93-f83f3982649a@amd.com> <20171115190755.5n2zskcr2d4bmewp@pd.tnic> <20171116172520.4lgdvpcdxuxenxc7@pd.tnic> <2c785f9f-faac-58d5-2efd-3fce80d24c18@amd.com> <20171117114445.iv2s7sm2mjqusztx@pd.tnic> <8ff957e3-67b7-3986-05ef-3e42bd7143f6@amd.com> <20171205175604.GA20099@flask> From: "Natarajan, Janakarajan" Message-ID: <3e3cfa15-8a92-56e4-008e-4d4734efce21@amd.com> Date: Wed, 6 Dec 2017 14:19:11 -0600 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171205175604.GA20099@flask> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [165.204.78.1] X-ClientProxiedBy: BN6PR08CA0075.namprd08.prod.outlook.com (10.172.143.141) To DM5PR12MB1675.namprd12.prod.outlook.com (10.172.40.144) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 93287f34-7938-4e5a-e761-08d53ce6a0f8 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603286);SRVR:DM5PR12MB1675; X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1675;3:7BCQSxuydMAp2RJEvW5KkYQd+st9nJjLr1KCvEe8CFZ/a1ljrvZwQ+1nVZSp9IHrMUqQ2fx05GX4e3JVHEel4EmUMpqn4hDybQ9qNfqb53XpWLEULCK8WQcbZ2a2iQJ19oc+jvF8bdjf3HbUXW/yCM6VDrttmupDmrUzT8DZi8iila6EkV6ITD0q5p71Rq20ckayA7BOxZe/Au8j+rW1H8Xui/p0w9nZ8Y0PNR4YH+iTZX7RpGZR3f4hZ6cLT1gt;25:mG+1KXr3jMfsk32qwnaRrRbs0kS+wiCS8P5EGH2JH6wOq9691sfjFLRDi6RN+Y9e24ZhwpA5GF2EZNNDceQqZE8agkNurobxfIVkZN7Xr7/u7EUcY9rVI8avvgF2hpK7rd2bM2+JVI2e+TuHeuwx5JbMGwcIvNdKZ7z71UAo3omqSk9CcHssGkXWB8BrxJI6zQPwNyzF7csBLiDbkKkYfDGgcKU0+cgkhITMyuKgE+O2AtuaeAFy8JlVIsfv8JzWfx3rHmKvCnZ2spMHK+yOsfKCoF4d07wPXY8ii2o9rX5C1WseklK2gyDLGv6R7jGkk6K1YgD+panR7ReAAfHgVw==;31:pBivbenIiZvsYuRnDd7qvDF9meHavpN349pYz2UitHK77uFFndra6Ip1JnJ+wRSAf82dJPKsyHi/8ex3AZw6yy/8v+d8m0vZaasn/aUTejjnq0DXGI8ENQ/5l17AqJDR6SSkrczbATB/zztYjvTxBdwRxtJQ6i5ddzdSOt+2mSIPwHC88cEvJtjH+WgATunwo7+7bpqJtO7hXqXY2SBzBvX54NYy58mbIwEPT1LHqFo= X-MS-TrafficTypeDiagnostic: DM5PR12MB1675: X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1675;20:2a1XTyZqwoCJyemRuOrvewbgsuLwwX6C0Jas792SBJUNwd4uk8HCFLh1ih8UKfdnfF31lLeEU4BMACvfHRUonRWU0XBikmOYK/FPwZV8SEXtVIRmSu7KYKgI22ASDg0rz1M5x/z3g4ekWRlXjHuqITw9G3URXSJ9qzRe4op0D9UsM+tfVdQc9AimLsKKfU2XR+mRtWf9ntYrCR23A/SIIyjszcXPXKoxVvr5WLs2XUFaOCuhUscJp4+YHgLAavionwB2gyj0xaypWCctOaPf/eSgT0qS9SvlapyIX+O5R9X73mZwqIAC8KkMevoYa8vLimxwopbeyIdgAL5jNI3hstFDxrQ4fUOpxyEj6gr1CY3ImkezpsFY3D5bgQjXRCAuzgFt0mFpo/yc4hFdF5Mr1DqLG9ZF/usAoT5rfoy63Qrtcfk+4RdTThqxgRgy/dW8p1Hh9Wwz2UF6htdaCpajmXJRpCrvTuNdk0anQbnuSrsIfcpNJJmgW7qDIEMJaNNZ;4:bWtqUDlEOwv7+hCJzUb5wPmc9n58KhNC5aDD9aHVLnO418apvTAAxdWdcfDo02bbp0RctSNgaWQckGrGuEKtM77FL8h/rX1t45PjveHiQpy4cjbmi/IwhxG1KPaVJS81O81tirxTkDQ61HMMIqOmeBKonOL2+0EZGI8bVmcTPKVhVVgxksG6OJDj/j1+ruQGs7JNshddN81CDHmTVgCa8oKcxLuj6JMGfDG3ygcSJcP1irjr5x6T9pzS+VAVjonJEr0CkpzXMYB9HUdNsuu/5Q== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(5005006)(8121501046)(10201501046)(3231022)(3002001)(93006095)(93001095)(6055026)(6041248)(20161123558100)(20161123560025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123555025)(6072148)(201708071742011);SRVR:DM5PR12MB1675;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:DM5PR12MB1675; X-Forefront-PRVS: 05134F8B4F X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(346002)(376002)(366004)(39860400002)(199004)(189003)(377424004)(24454002)(8936002)(6116002)(3846002)(54906003)(5660300001)(53936002)(53546010)(36756003)(4326008)(31686004)(90366009)(7416002)(77096006)(101416001)(68736007)(47776003)(8676002)(6666003)(2950100002)(72206003)(31696002)(50466002)(81156014)(105586002)(25786009)(66066001)(65956001)(2486003)(7736002)(230700001)(23676004)(65806001)(83506002)(6916009)(6486002)(16526018)(81166006)(33646002)(478600001)(305945005)(6246003)(316002)(64126003)(52146003)(65826007)(67846002)(86362001)(97736004)(52116002)(58126008)(16576012)(93886005)(76176011)(229853002)(106356001)(2906002);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR12MB1675;H:[10.236.68.193];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjEyTUIxNjc1OzIzOmhLT1FyUjgybUFaeTRxTUpHVWVrYzRUTDc1?= =?utf-8?B?MEt5Wnl4TTliUVVTVVlxaUpLTVdST1dzTUc5TEN3Rkh0cmxnNlVKbVBYKzdv?= =?utf-8?B?b2Y1UTlIZXVBN1J5akw0YVJKejhjQjVMbGM2REl4OTlOZk95Y1F2MG1odmpa?= =?utf-8?B?ZUpJaU0rMllSVlFsNTNJdWtTM3hKNXRNRklNQmlhM3ZpTnRoczFrZmc3NXpP?= =?utf-8?B?M012RDE3cUVFZUhkVk1PYjBqSUlvRWdXaU42SEtNNXFPY3RVa0lXZDJjNWls?= =?utf-8?B?VVMwREdlblFkMVlrQlJKQ2RtUlNyYlpYeURRTzdaUEpBNVJoaEIwUlZnMGc5?= =?utf-8?B?RkJ0WDRaMmI1MmRWOUhrWUQ2elN4NzB6bWdrRlB3NHBEZGZqRUZ4dHpUNTRR?= =?utf-8?B?eVZzNUZTT1d3MWpJV2w0MUNnT0UraHNPcE1JUjBrTE9KRmdPR2paV1ovQXRq?= =?utf-8?B?Q2V0aVJ3WnB3bTBpazludFo2OTJpSTJMUjcxd3FSamR0TEhCSGFFdXM5QVRJ?= =?utf-8?B?VDYxREorQ2VlVyt5UjJGem5SUDN6cE5JUTRTbWkzbmZMNS9YNWdLVXM2bWRL?= =?utf-8?B?WkMwSHRWemF0SWNmdjZtdVNrWFc4Y21DcUwwUzZPdGYwNmtsZEtNK1Q4Yk53?= =?utf-8?B?azdsQ0ZSZXIxek9LZmdlT3QyQ0dOak42T3ZlMm80RGorRGtJdGw3OW5pVyt4?= =?utf-8?B?c1FLZTZ1ZTlJejRDWEZxVGkwZmNWUy9wbmo4Rk1jaGh2OHdGQUFvZ1VOTktH?= =?utf-8?B?cEhVSlVLTjI5NjJhRVNHdGZWOGg0aWJtampwWGI2N3lVdFlwQjN2V0pUQlp0?= =?utf-8?B?d2U2Nll4NnZieEE5bDY0V1FMcUVDUGM3L0I4ZDMrTmV5NGNxSndsVEJ6eVRm?= =?utf-8?B?eXlFcHFzYkZVUjlZQnl4cWs3Nm5kRFhuWXFDWFFOVFZaRmwrTjNOMGEyS0Zm?= =?utf-8?B?UVJ5eWh2QmlWbGMvYTRVbG1jVUtYb2FFT1FYTUYrVk56QjQ1MXpRRU1XeHpZ?= =?utf-8?B?ZU9uTXBpVkRZZVh3UHdzZkRtYUoyWkZ0N1BBbEoxNlc0dTBqd3VUUVA3eEtL?= =?utf-8?B?RmdXVm5ycXl5L3dQb1RFZVc4cHZCVUdkOUc4amhjMGUyWFNSWUFzRVVTbTRC?= =?utf-8?B?YXQrcWw4R0dsOWdXZ1RrVjlkVXRWdHN4dmFTY2ZqcEt4ZlNtUml5aEJhb3M0?= =?utf-8?B?d3NxUEM2VXVkdjYrVWoySGI4cDdTRFBqK0lXTUpzSlA0b1NOWTBoTHlYY1g2?= =?utf-8?B?YmFvcmtBR0tSNnczWFpLWXZ0UkZDMVNsMlJvWUt6akh4VURaaUl1bG5LT2Qx?= =?utf-8?B?ZXVuRUVpZXJHcGdLT1p4aVlYbWhSVEU5ZVF4TmxVcXFvUW9RN2tobEp1WW90?= =?utf-8?B?WmVkNzdDdndzZUVZMmd4TWk3aUpOREtUd0ZDQmFpSzRBcWs3bTRmS1Q5STVy?= =?utf-8?B?SFZXbllBVWNlekdDb1NER29LSitqeUpHV21OUlJySTJNVDNQZFZlc3ZkM0s5?= =?utf-8?B?OWNsQ1A0RW92empkWGFBcjlSVjNvY05MQUJHU0gxeWxMZXZQeC9Cd045NlhF?= =?utf-8?B?OENrbWpFa0lVWEFqbDhvQVpzenI4aElGQkZBV1R5Q0FzN2pmOGkxVWNYOEU0?= =?utf-8?B?TmYrWmFsUW5VMHQwdUJOYVhmMWx6T0FiczN3b2puUlBCOUl5c2tDQVZtN3lV?= =?utf-8?B?VUIrWEFVS2lSTUN1TTJMQ1IxRkNNam52cTlGVzV6MzJrUlpJYnFkcVdiSEdO?= =?utf-8?B?SVgvLzNHanlvMlVwWUpHbDdVdzBrVDFHc01GNHBEMjVpbkFIcG4xbVFsK1kv?= =?utf-8?B?TTZPbWxFVjE2V3RFTEJmdzJMeldiWE9RMU9NMktFQUdlZnc1Vi8wYkdnM1Ar?= =?utf-8?B?UWp4b0NjbysrMkhMTmMvREVtNVlpcFROSmFFYjV2Sm9zc2ozRDZMaVcvU1U2?= =?utf-8?B?L3BveVo2Y3IrL2lBOG1JR2RGMS9NN2M5cTQ0bGkyNzVCL2poVmh4bUVIUjd3?= =?utf-8?B?UlFNa3lSMlM1eThHYkhiUnByb3R2RDN5V0t5QT09?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1675;6:AANa+lduEXdh9T5qCnRKRW5Hl5ujlgZug7uthjIbRU1oz9uFogN5Oy5mGB60gbUssEXPWI+alT4hOT+DypCtVCiyCGuM9rbELAefozzfQBJrdQnLTSmjaP2FzEVwM4VkhMNQuCP/NgWbESTYl+ZeiueBkvlnrIuc7f/CnjdapZ5EnHQ0V8tM12ej9QstxfdEXgbMODPai94hQI5KneU+SX1e8TvEdlKEZvK/FCKOAZoDutzxvqouxFu1hjgLMPxll5HCiW1sI+wjPbDOC/DGex4LgohiisWO46+gBq5EonSRmH90ALLcwdmFIjScPSLH9Y3lt0PvPM+i9TjSSXI2JKYdq6rEMUsTWb6UWIbYFHs=;5:nMnoPB+1OvS6EKzpsQUdM2W5PAgaB5fiMQUjJIIoqP8DFvk1CGchHIWmKYSSoeOGv5AP/EUijbX/8EBdBk2RaDyQO/lEqJxVUHSij/kLpoczu0/2FE5WZYbJkJ4mpJjRsqcc2vIfethuBVvNcaFJAxRmhgcpQz8CLMZOaYP4tPY=;24:Z8QHpavxQpB3wbWf+OukQjSjIQQ0de+eCpJNJVQgy4U3vjRtKfJZHDKq3wPkb/BTK5nVwFTsV+Mz/wfa+U7QXQ4jUshCTMCJxGF7Xx/qnIE=;7:KrSuBvPD6zWO07OWsFn1J+tYfaBYAXHZrlop5wqhgh3GEQCJxGSO5VF2DTOuB6d4xayz9vBtiS9Pb/wRw8Of/K/aT/51w7FJhJLAtr+tYpRVsDcuz8kxY13tRDVkTvIgKdwtr66S0WbnupQLzyg7r7jNNZ9xNelNesr2b5DDIdSloD5neJ1V5k6hIPOCCYVpx7bv7yQ3XBn7W2mvBhZbBYYuHqm0/5RoR/WUnRs3B6RipD9UVpvkdhjm2gDIY9IO SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1675;20:xTRJKWNF3dSn4UI03VimidwNph2wYU+QoRTgmmt3HoW+RQmZzXMg/0q/MErfjBcPaD99KPx7QektN36B0in4js53OL5Tq+GUXLGcN3p12yqzJDS+ssWM24B57AvaXWMzgtvOH42bIRYCjM8osRm7qwW7mzyWB+rlLFgNZ+Ovq7rFsr9nMmuHlZHf/GlaV+py+Kl4PiYLDrsyrpu/qL0UtxpvsQG5NCeHOIkFXppH3g9POxCwlkrgSfErbmiLIfye X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2017 20:19:16.5620 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 93287f34-7938-4e5a-e761-08d53ce6a0f8 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1675 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/5/2017 11:56 AM, Radim Krcmar wrote: > 2017-12-01 13:30-0600, Natarajan, Janakarajan: >> On 11/17/2017 5:44 AM, Borislav Petkov wrote: >>> On Thu, Nov 16, 2017 at 12:00:11PM -0600, Natarajan, Janakarajan wrote: >>>> Ah my apologies. So when the pmu is initialized the cpuid entries >>>> aren't available then. >>> So let's see: >>> >>> ... kvm_arch_vcpu_create() -> >>> svm_create_vcpu() -> >>> kvm_vcpu_init() -> >>> kvm_arch_vcpu_init() -> >>> >>> <--- HERE >>> >>> kvm_pmu_init() >>> >>> But at HERE in kvm_arch_vcpu_init() right before kvm_pmu_init() we do already query >>> cpuid: >>> >>> vcpu->arch.maxphyaddr = cpuid_query_maxphyaddr(vcpu); >>> >>> so it's not like we don't know about cpuid leafs at that point. Which >>> would mean that the code can be made to set the CPU family earlier, >>> before kvm_pmu_init() runs so that you have the proper CPU family and >>> thus have this thing properly designed. >>> >>> Maybe Paolo and Radim have a better suggestion here... >> Paolo, Radim any suggestions about this. I feel that the number of counters >> initialized can be 6 > This is the best solution with the current framework. Okay. > >> and the subsequent code (kvm_pmu_refresh()) takes care of the number of >> counters to be used (4 or 6) >> based on the vcpu family. > Can't we look only at X86_FEATURE_PERFCTR_CORE and completely ignore the > AMD family? > Using the family would bring problems with compatiblity. Yeah. We can just use the X86_FEATURE_PERFCTR_CORE flag as a check. I'll send a v3 with the changes. Thanks. > > Thanks.