From mboxrd@z Thu Jan 1 00:00:00 1970 From: Soeren Moch Date: Thu, 7 Mar 2019 09:33:19 +0100 Subject: [U-Boot] [PATCH 08/10] ata: dwc_ahsata: Add ahci driver model support In-Reply-To: <20190301121101.14163-9-smoch@web.de> References: <20190301121101.14163-1-smoch@web.de> <20190301121101.14163-9-smoch@web.de> Message-ID: <3e3d677e-c3e3-0dc4-e5d0-e462029dd1fd@web.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 01.03.19 13:10, Soeren Moch wrote: > Disable this support for cm_fx6 to avoid breakage. > > Signed-off-by: Soeren Moch > --- > It would be easy to add weak board_ahci_enable/disable functions which > can be overwritten (e.g. in the cm_fx6 board file) to handle power enable/ > disable on driver probe/remove. But I have no idea why this board needs these > repeated probe/remove calls for the same sata device. In my tests on a > tbs2910 board a sata harddisk is always recognized by a 'sata init' command, > also without this probe loop. > If this can be ironed out, we can remove the DWC_AHSATA_AHCI config option. > > Cc: Nikita Kiryanov > Cc: Stefano Babic > Cc: Fabio Estevam > Cc: Marcel Ziswiler > Cc: Stefan Roese > Cc: Simon Glass > Cc: u-boot at lists.denx.de > --- After rebasing this patch series from v2019.04-rc2 to -rc3, I get this: Matrix U-Boot> sata init AHCI 0001.0300 32 slots 1 ports 3 Gbps 0x1 impl SATA mode flags: ncq stag pm led clo only pmp pio slum part Can not start port 0 data abort pc : [<8ffab37c>] lr : [<8ffab595>] reloc pc : [<1781837c>] lr : [<17818595>] sp : 87f909c8 ip : 87f90cd4 fp : 00000004 r10: 6c41202e r9 : 87f90ea0 r8 : 00000000 r7 : 87f90a80 r6 : 00000200 r5 : 00000000 r4 : 87f90a80 r3 : 00000070 r2 : 87f90cc0 r1 : 87f90cc0 r0 : 00000000 Flags: nzcv IRQs off FIQs off Mode SVC_32 Code: fb03231c f8d3030b 9001a00c 9e0c4611 (3038f8da) Resetting CPU ... Any idea what got broken here? Thanks, Soeren