From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A886BC433EF for ; Tue, 7 Jun 2022 06:50:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231247AbiFGGuy (ORCPT ); Tue, 7 Jun 2022 02:50:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44314 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230162AbiFGGux (ORCPT ); Tue, 7 Jun 2022 02:50:53 -0400 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6BCEDDEEB1 for ; Mon, 6 Jun 2022 23:50:52 -0700 (PDT) Received: by mail-ej1-x62f.google.com with SMTP id kq6so20157349ejb.11 for ; Mon, 06 Jun 2022 23:50:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=gcjA/D1N6F29apXrVNtiB7cxyQefIwUG0Piy77ZFa00=; b=e2qVNFqbMue2rV7KpSz8oiizqGhv0jaDz+S7v3abMGbZ5xqQPVkya+z5RUS3itUo6A 1j6PkbqlIQuh/gY/koXNA12KXKqn5ULLSpkUSrxg4UuZ7LzSqtZgcgQIFF4CFMqc8s2z GE+4BgBFrSrqjJWANmEjSMXbibBF7EKTb7VwCj0Q2NIOG73uw6IsAYvCGSBBVLHGzo8A ArW+08xmfFtfzTns54FcKHsrtzPOadCFxTQUHTq9tjH90xSVvG5f65DozGw9VA/xMyAC wrePdthLVd1R17UCRUme4Qbxl34TmlRvUHzfD67qsktqJTfmZ2gaLX7rfAz9RE//gBnM WsTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=gcjA/D1N6F29apXrVNtiB7cxyQefIwUG0Piy77ZFa00=; b=VaTwfC/5TE3sIqnwo28tzGxinKkSB/5tJBEb69gXuiukgZzOXsRkfb6h5tUqBpl3RH 1XCHCRsgcgQH5kdq3njksQ7FPRHFnZGePocizXQ/W/FaB9x7p372nVr6imARbjBs2Rxf GxgnilzR+yeAFKiRS+P0f8KCnQSOaulDWFRSzHw8OPk9Ohfd/B57r2u0ANy4Xmr2HHJ+ /OzDhkApdK6eEAKckcT439bhs3Vo5EzLak/u6OsvsPy5M+xUnBUcqOpP4dyAA0dw/ZkO e2VajzXy1qd19Sn7xMjGpFAidGLED6RTuityz+TfvfYvJ/MSWZB0FDdNNXXta2aWw1uz ERcg== X-Gm-Message-State: AOAM530J9w5HLFVi2lpOUB6MbI3V3wGzfZm8iQuN4RqfQ1bHRwNPPYEt qLp9cyCG13zFtSFjnWNc4E1YTw== X-Google-Smtp-Source: ABdhPJyR5JlmxsGr7LTLbWT6s2wCa6c297ttH1DNwdGUznsJNrDOcsQpF6v/UhkoFMjJt2jTJ0qQhA== X-Received: by 2002:a17:907:c29:b0:704:fbb:1943 with SMTP id ga41-20020a1709070c2900b007040fbb1943mr25005900ejc.486.1654584650908; Mon, 06 Jun 2022 23:50:50 -0700 (PDT) Received: from [192.168.0.181] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id n24-20020aa7c698000000b0042bb229e81esm9694505edq.15.2022.06.06.23.50.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Jun 2022 23:50:50 -0700 (PDT) Message-ID: <3e4e504c-5a38-43cd-ea8d-afbbb72eacad@linaro.org> Date: Tue, 7 Jun 2022 08:50:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v4 1/4] dt-bindings: interconnect: qcom,sdm845-cpu-bwmon: add BWMON device Content-Language: en-US To: Bjorn Andersson Cc: Andy Gross , Georgi Djakov , Rob Herring , Catalin Marinas , Will Deacon , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Rob Herring References: <20220601101140.170504-1-krzysztof.kozlowski@linaro.org> <20220601101140.170504-2-krzysztof.kozlowski@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 06/06/2022 23:11, Bjorn Andersson wrote: > On Wed 01 Jun 03:11 PDT 2022, Krzysztof Kozlowski wrote: > >> Add bindings for the Qualcomm Bandwidth Monitor device providing >> performance data on interconnects. The bindings describe only BWMON >> version 4, e.g. the instance on SDM845 between CPU and Last Level Cache >> Controller. >> >> Signed-off-by: Krzysztof Kozlowski >> Reviewed-by: Rob Herring >> Acked-by: Georgi Djakov >> --- >> .../interconnect/qcom,sdm845-cpu-bwmon.yaml | 97 +++++++++++++++++++ >> 1 file changed, 97 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,sdm845-cpu-bwmon.yaml >> >> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,sdm845-cpu-bwmon.yaml b/Documentation/devicetree/bindings/interconnect/qcom,sdm845-cpu-bwmon.yaml >> new file mode 100644 >> index 000000000000..8c82e06ee432 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/interconnect/qcom,sdm845-cpu-bwmon.yaml >> @@ -0,0 +1,97 @@ >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/interconnect/qcom,sdm845-cpu-bwmon.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm Interconnect Bandwidth Monitor >> + >> +maintainers: >> + - Krzysztof Kozlowski >> + >> +description: >> + Bandwidth Monitor measures current throughput on buses between various NoC >> + fabrics and provides information when it crosses configured thresholds. >> + >> +properties: >> + compatible: >> + enum: >> + - qcom,sdm845-cpu-bwmon # BWMON v4 > > It seems the thing that's called bwmon v4 is compatible with a number of > different platforms, should we add a generic compatible to the binding > as well, to avoid having to update the implementation for each SoC? > > (I.e. "qcom,sdm845-cpu-bwmon", "qcom,bwmon-v4") I am hesitant. I could not find BWMON IP block versioning in the Qualcomm docs. Only the downstream sources had it. Therefore I think it is more applicable to use this one as fallback for other boards, e.g.: "qcom,sdm660-cpu-bwmon", "qcom,sdm845-cpu-bwmon" (even if the number is a bit odd - newer comes as last compatible). What's your preference? Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD507C43334 for ; Tue, 7 Jun 2022 06:58:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0eY/2syckySUnM3k2lRMfqu/yKY5F6MEZn/j3l1n75I=; b=SGjMX4StOP0AvY 9fcUdHzMYzmlG9Xj8sneLQFK8n5G0BOvHvDf0DzmiNSQnvENmYT9kBvSHA59CrVK7AMNdGEO62atU bZ+Ev9TZDXY/FAKFXSmzWC60xJixpU7n4GilqVsSRxOpAauU/SJyvews+bjm0zpHxO6d+s4AitY+p adJvAt4RQBOvHJYliCv90kF2a0CIaQtJZQiwp4P+kgOj9ZqWN/Mom3m91lsy0SqEHfOF97ScszzwF PFb1jdZBeWmrN/BY4N9KV16hsOD7NOM/SlTYCu2mOelwH8CJf+VztO2rjquBpCcpjk4hAGHK5Cq/1 aIuMDk+1+PAWo+gWAptw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyT90-005FCP-3K; Tue, 07 Jun 2022 06:56:50 +0000 Received: from mail-ej1-x62d.google.com ([2a00:1450:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyT3E-005Bt6-ES for linux-arm-kernel@lists.infradead.org; Tue, 07 Jun 2022 06:50:54 +0000 Received: by mail-ej1-x62d.google.com with SMTP id h23so22106750ejj.12 for ; Mon, 06 Jun 2022 23:50:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=gcjA/D1N6F29apXrVNtiB7cxyQefIwUG0Piy77ZFa00=; b=e2qVNFqbMue2rV7KpSz8oiizqGhv0jaDz+S7v3abMGbZ5xqQPVkya+z5RUS3itUo6A 1j6PkbqlIQuh/gY/koXNA12KXKqn5ULLSpkUSrxg4UuZ7LzSqtZgcgQIFF4CFMqc8s2z GE+4BgBFrSrqjJWANmEjSMXbibBF7EKTb7VwCj0Q2NIOG73uw6IsAYvCGSBBVLHGzo8A ArW+08xmfFtfzTns54FcKHsrtzPOadCFxTQUHTq9tjH90xSVvG5f65DozGw9VA/xMyAC wrePdthLVd1R17UCRUme4Qbxl34TmlRvUHzfD67qsktqJTfmZ2gaLX7rfAz9RE//gBnM WsTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=gcjA/D1N6F29apXrVNtiB7cxyQefIwUG0Piy77ZFa00=; b=FYHGKT4EpKkeLF66Ji94MXR2fyD0E4ZGrXkzZBojXzOEJAzNVWAxDbZyoQrU5G4UDU p7rgbKoWMFruycpWJDgUKuNEW5hql32zc8krpORyyRInrNwhsvK/RP7YSXAEG3Phc/ch xKk5wBiKCEsKMA1yeXWk/t5fooNyGAZkMZgIycguuRYrbRrrzViMehgmquCY5X+sTI0+ L3nt5nHPeLSSqigfrtjJnLRghvLA8RLvLPbHDYCkNJi3FnuawqTv5sxB74a6//+TdIP2 mOM+5vshukHci1L+LIKhwhiQdnv7D71t3EXMUky7IV7D8JXLHrs40Fm1XTT+mmQL2TdS NPag== X-Gm-Message-State: AOAM530aHu4tPUAFtzIjJYeW1sYnGcQt2k3I0PzN3SgPOkzgGobGb9OH 0NofDt1pF6gxTL8KgANUhUZnDQ== X-Google-Smtp-Source: ABdhPJyR5JlmxsGr7LTLbWT6s2wCa6c297ttH1DNwdGUznsJNrDOcsQpF6v/UhkoFMjJt2jTJ0qQhA== X-Received: by 2002:a17:907:c29:b0:704:fbb:1943 with SMTP id ga41-20020a1709070c2900b007040fbb1943mr25005900ejc.486.1654584650908; Mon, 06 Jun 2022 23:50:50 -0700 (PDT) Received: from [192.168.0.181] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id n24-20020aa7c698000000b0042bb229e81esm9694505edq.15.2022.06.06.23.50.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Jun 2022 23:50:50 -0700 (PDT) Message-ID: <3e4e504c-5a38-43cd-ea8d-afbbb72eacad@linaro.org> Date: Tue, 7 Jun 2022 08:50:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v4 1/4] dt-bindings: interconnect: qcom,sdm845-cpu-bwmon: add BWMON device Content-Language: en-US To: Bjorn Andersson Cc: Andy Gross , Georgi Djakov , Rob Herring , Catalin Marinas , Will Deacon , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Rob Herring References: <20220601101140.170504-1-krzysztof.kozlowski@linaro.org> <20220601101140.170504-2-krzysztof.kozlowski@linaro.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220606_235052_579052_31159549 X-CRM114-Status: GOOD ( 21.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 06/06/2022 23:11, Bjorn Andersson wrote: > On Wed 01 Jun 03:11 PDT 2022, Krzysztof Kozlowski wrote: > >> Add bindings for the Qualcomm Bandwidth Monitor device providing >> performance data on interconnects. The bindings describe only BWMON >> version 4, e.g. the instance on SDM845 between CPU and Last Level Cache >> Controller. >> >> Signed-off-by: Krzysztof Kozlowski >> Reviewed-by: Rob Herring >> Acked-by: Georgi Djakov >> --- >> .../interconnect/qcom,sdm845-cpu-bwmon.yaml | 97 +++++++++++++++++++ >> 1 file changed, 97 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,sdm845-cpu-bwmon.yaml >> >> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,sdm845-cpu-bwmon.yaml b/Documentation/devicetree/bindings/interconnect/qcom,sdm845-cpu-bwmon.yaml >> new file mode 100644 >> index 000000000000..8c82e06ee432 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/interconnect/qcom,sdm845-cpu-bwmon.yaml >> @@ -0,0 +1,97 @@ >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/interconnect/qcom,sdm845-cpu-bwmon.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm Interconnect Bandwidth Monitor >> + >> +maintainers: >> + - Krzysztof Kozlowski >> + >> +description: >> + Bandwidth Monitor measures current throughput on buses between various NoC >> + fabrics and provides information when it crosses configured thresholds. >> + >> +properties: >> + compatible: >> + enum: >> + - qcom,sdm845-cpu-bwmon # BWMON v4 > > It seems the thing that's called bwmon v4 is compatible with a number of > different platforms, should we add a generic compatible to the binding > as well, to avoid having to update the implementation for each SoC? > > (I.e. "qcom,sdm845-cpu-bwmon", "qcom,bwmon-v4") I am hesitant. I could not find BWMON IP block versioning in the Qualcomm docs. Only the downstream sources had it. Therefore I think it is more applicable to use this one as fallback for other boards, e.g.: "qcom,sdm660-cpu-bwmon", "qcom,sdm845-cpu-bwmon" (even if the number is a bit odd - newer comes as last compatible). What's your preference? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel