All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Linux regression tracking (Thorsten Leemhuis)" <regressions@leemhuis.info>
To: Karel Balej <balejk@matfyz.cz>, Jonathan Corbet <corbet@lwn.net>,
	regressions@lists.linux.dev, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, workflows@vger.kernel.org
Subject: Re: [PATCH 1/2] docs: *-regressions.rst: unify quoting, add missing word
Date: Wed, 3 Apr 2024 16:13:53 +0200	[thread overview]
Message-ID: <3e53f18c-12aa-4bf8-b3f7-7945bbca6882@leemhuis.info> (raw)
In-Reply-To: <20240328194342.11760-2-balejk@matfyz.cz>

On 28.03.24 20:29, Karel Balej wrote:
> Quoting of the '"no regressions" rule' expression differs between
> occurrences, sometimes being presented as '"no regressions rule"'. Unify
> the quoting using the first form which seems semantically correct or is
> at least used dominantly, albeit marginally.
> 
> One of the occurrences is obviously missing the 'rule' part -- add it.
> 
> Signed-off-by: Karel Balej <balejk@matfyz.cz>

Thx for this:

Reviewed-by: Thorsten Leemhuis <linux@leemhuis.info>

Ciao, Thorsten


> ---
>  Documentation/admin-guide/reporting-regressions.rst | 10 +++++-----
>  Documentation/process/handling-regressions.rst      |  2 +-
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/admin-guide/reporting-regressions.rst b/Documentation/admin-guide/reporting-regressions.rst
> index 76b246ecf21b..946518355a2c 100644
> --- a/Documentation/admin-guide/reporting-regressions.rst
> +++ b/Documentation/admin-guide/reporting-regressions.rst
> @@ -42,12 +42,12 @@ The important basics
>  --------------------
>  
>  
> -What is a "regression" and what is the "no regressions rule"?
> +What is a "regression" and what is the "no regressions" rule?
>  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>  
>  It's a regression if some application or practical use case running fine with
>  one Linux kernel works worse or not at all with a newer version compiled using a
> -similar configuration. The "no regressions rule" forbids this to take place; if
> +similar configuration. The "no regressions" rule forbids this to take place; if
>  it happens by accident, developers that caused it are expected to quickly fix
>  the issue.
>  
> @@ -173,7 +173,7 @@ Additional details about regressions
>  ------------------------------------
>  
>  
> -What is the goal of the "no regressions rule"?
> +What is the goal of the "no regressions" rule?
>  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>  
>  Users should feel safe when updating kernel versions and not have to worry
> @@ -199,8 +199,8 @@ Exceptions to this rule are extremely rare; in the past developers almost always
>  turned out to be wrong when they assumed a particular situation was warranting
>  an exception.
>  
> -Who ensures the "no regressions" is actually followed?
> -~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> +Who ensures the "no regressions" rule is actually followed?
> +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>  
>  The subsystem maintainers should take care of that, which are watched and
>  supported by the tree maintainers -- e.g. Linus Torvalds for mainline and
> diff --git a/Documentation/process/handling-regressions.rst b/Documentation/process/handling-regressions.rst
> index ce6753a674f3..49ba1410cfce 100644
> --- a/Documentation/process/handling-regressions.rst
> +++ b/Documentation/process/handling-regressions.rst
> @@ -284,7 +284,7 @@ What else is there to known about regressions?
>  Check out Documentation/admin-guide/reporting-regressions.rst, it covers a lot
>  of other aspects you want might want to be aware of:
>  
> - * the purpose of the "no regressions rule"
> + * the purpose of the "no regressions" rule
>  
>   * what issues actually qualify as regression
>  

  reply	other threads:[~2024-04-03 14:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-28 19:29 [PATCH 0/2] regressions documentation improvements Karel Balej
2024-03-28 19:29 ` [PATCH 1/2] docs: *-regressions.rst: unify quoting, add missing word Karel Balej
2024-04-03 14:13   ` Linux regression tracking (Thorsten Leemhuis) [this message]
2024-04-10 21:03     ` Jonathan Corbet
2024-03-28 19:29 ` [PATCH 2/2] docs: handling-regressions.rst: clarify that "Closes:" tags work too Karel Balej
2024-04-01  8:38   ` Thorsten Leemhuis
2024-04-01 15:19     ` Randy Dunlap
2024-04-02  9:27       ` Thorsten Leemhuis
2024-04-02 10:13         ` Karel Balej
2024-04-03 14:13           ` Thorsten Leemhuis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3e53f18c-12aa-4bf8-b3f7-7945bbca6882@leemhuis.info \
    --to=regressions@leemhuis.info \
    --cc=balejk@matfyz.cz \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=regressions@lists.linux.dev \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.