Re: [PATCH v6] sound: rawmidi: Add framing mode

[Jaroslav Kysela <perex@perex.cz>]

Dne 19. 04. 21 v 18:40 David Henningsson napsal(a):
> This commit adds a new framing mode that frames all MIDI data into
> 32-byte frames with a timestamp.
> 
> The main benefit is that we can get accurate timestamps even if
> userspace wakeup and processing is not immediate.
> 
> Testing on a Celeron N3150 with this mode has a max jitter of 2.8 ms,
> compared to the in-kernel seq implementation which has a max jitter
> of 5 ms during idle and much worse when running scheduler stress tests
> in parallel.
> 
> Signed-off-by: David Henningsson <coding@diwic.se>

Nice. Thank you.

Reviewed-by: Jaroslav Kysela <perex@perex.cz>


> @@ -1534,6 +1607,7 @@ static __poll_t snd_rawmidi_poll(struct file *file, poll_table *wait)
>  /*
>   */
>  
> +
>  static void snd_rawmidi_proc_info_read(struct snd_info_entry *entry,
>  				       struct snd_info_buffer *buffer)
>  {

This is probably a typo chunk?

						Jaroslav

-- 
Jaroslav Kysela <perex@perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.