From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58098) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1budZW-0003se-4p for qemu-devel@nongnu.org; Thu, 13 Oct 2016 06:49:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1budZQ-0004Fs-5e for qemu-devel@nongnu.org; Thu, 13 Oct 2016 06:49:09 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:48398 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1budZQ-0004EL-0H for qemu-devel@nongnu.org; Thu, 13 Oct 2016 06:49:04 -0400 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u9DAmomT051207 for ; Thu, 13 Oct 2016 06:49:01 -0400 Received: from e06smtp08.uk.ibm.com (e06smtp08.uk.ibm.com [195.75.94.104]) by mx0b-001b2d01.pphosted.com with ESMTP id 2626867vqt-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 13 Oct 2016 06:49:01 -0400 Received: from localhost by e06smtp08.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 13 Oct 2016 11:48:59 +0100 References: <1475519097-27611-1-git-send-email-duanj@linux.vnet.ibm.com> <1475519097-27611-4-git-send-email-duanj@linux.vnet.ibm.com> <60b19618-e725-710f-f512-3f6df471f6f2@linux.vnet.ibm.com> <1b5c6891-1cd2-bf92-0b8b-a0cd9312442f@linux.vnet.ibm.com> <1467348300.2794077.1476346928598.JavaMail.zimbra@redhat.com> From: Halil Pasic Date: Thu, 13 Oct 2016 12:48:54 +0200 MIME-Version: 1.0 In-Reply-To: <1467348300.2794077.1476346928598.JavaMail.zimbra@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="4HOlWUeA3NoxttGhEaTBGI7SgwugKnUAL" Message-Id: <3e8b8f66-883e-6ea2-c191-6feaf4268110@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v5 3/6] migration: extend VMStateInfo List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Jianjun Duan Cc: qemu-devel@nongnu.org, veroniabahaa@gmail.com, peter maydell , dgilbert@redhat.com, mst@redhat.com, quintela@redhat.com, mark cave-ayland , mdroth@linux.vnet.ibm.com, mreitz@redhat.com, blauwirbel@gmail.com, amit shah , qemu-ppc@nongnu.org, kraxel@redhat.com, kwolf@redhat.com, dmitry@daynix.com, rth@twiddle.net, leon alrae , aurelien@aurel32.net, david@gibson.dropbear.id.au This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --4HOlWUeA3NoxttGhEaTBGI7SgwugKnUAL From: Halil Pasic To: Paolo Bonzini , Jianjun Duan Cc: qemu-devel@nongnu.org, veroniabahaa@gmail.com, peter maydell , dgilbert@redhat.com, mst@redhat.com, quintela@redhat.com, mark cave-ayland , mdroth@linux.vnet.ibm.com, mreitz@redhat.com, blauwirbel@gmail.com, amit shah , qemu-ppc@nongnu.org, kraxel@redhat.com, kwolf@redhat.com, dmitry@daynix.com, rth@twiddle.net, leon alrae , aurelien@aurel32.net, david@gibson.dropbear.id.au Message-ID: <3e8b8f66-883e-6ea2-c191-6feaf4268110@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v5 3/6] migration: extend VMStateInfo References: <1475519097-27611-1-git-send-email-duanj@linux.vnet.ibm.com> <1475519097-27611-4-git-send-email-duanj@linux.vnet.ibm.com> <60b19618-e725-710f-f512-3f6df471f6f2@linux.vnet.ibm.com> <1b5c6891-1cd2-bf92-0b8b-a0cd9312442f@linux.vnet.ibm.com> <1467348300.2794077.1476346928598.JavaMail.zimbra@redhat.com> In-Reply-To: <1467348300.2794077.1476346928598.JavaMail.zimbra@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/13/2016 10:22 AM, Paolo Bonzini wrote: >>> No, I disagree. We shouldn't be worried about making intrusive chang= es >>> > > to all invocations or declarations, if that leads to a simpler AP= I. >> >=20 >> > If VMStateInfo was meant for complete customization, then it was mis= sing >> > some parts. I think the API is indeed simpler. Just like >> > definition for VMStateField. Not all of its fields are used all time= =2E > Code moves. We can decide how much customization to allow of VMStateIn= fo. >=20 > You said it: "Not all of its fields are used all time". Likewise, not > all arguments are used all time for get/put, but it's not an issue if t= hey > are still there! So this patch is good, but at the same time VMS_LINKE= D is > pointless. >=20 > Paolo >=20 I'm fine with this. I just think, it would be nice if the contract betwee= n the vmstate-core and the client code implementing VMStateInfo callbacks could be documented, including when are certain parameters valid, what they stand for, and how are they supposed to be used for the next version= of the patch. Just to improve readability. Would this be OK with everybody? By the way the flag VMS_SINGLE is documented as ignored. Should we drop it? --4HOlWUeA3NoxttGhEaTBGI7SgwugKnUAL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (GNU/Linux) iQIcBAEBAgAGBQJX/2aWAAoJEA0vhuyXGx0A1KwP/0mrf+0oG6wI7LbGMg0nz/DD z/x/nzXgNOAT24hXt5nneegMBW6nSrrqVUgaBk6QzNShgoPb2ElmSWRBYDkwfIbB BIZ8usvkjrxLs2LTwoUda9p7BDk1VaFLHrd4ESoXjlJnl+ajslsfhQeZKDpJEJx8 J+tqBP895GHq64JK/4rwX2ULMAVoa+sU00A4h+QAEgnpNYzkr1gQ/rFiiAOpkam5 EU38SVUsFfo9FngLSe0YrPnJY0Nq/rZ7IkkE+Nb12fPFm60xTE6g8FnxArmm4bN9 //dYzheRdm1d9lBogrgt/QyIOvLWWw2zpwUzaloodiNRLScZUZFJEWuDNgDbCqy3 8avOrSdm6SvsvtoF4Yl/9RNRkTLxLbm3mmy7dWc3Mx6BzpEBt2ebIws88Xw2Kh6u BHJHvrc6alIYl+nW6qwDxsEUYMHOSY9Ev1d11i/cl7KmtHXdsSOaCjuo9u2eqzJl tgv+DyNTDfunHxtMVsg9NXPPTLv9/B+naqbLZVsufh0dGfU9Pgoz8oemqs3j+Bc1 wSAvh8EPLZn+HK+nb7NyQ+v5+5KvIp16klqIYlKEwwu8eq1yaqWPzCgPRtc6KIhY yMJcFYxbJuK1+W43nm6obucAiR7k7aGRca+MMXguu9a0v05mOa2SZwruJ8qG9RtV pizhP8Z9DpdiPpPY8sT7 =tkzb -----END PGP SIGNATURE----- --4HOlWUeA3NoxttGhEaTBGI7SgwugKnUAL--