All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthieu Baerts <matthieu.baerts at tessares.net>
To: mptcp at lists.01.org
Subject: Re: [MPTCP] [PATCH] mptcp:init: panic in case of error
Date: Thu, 06 Jun 2019 17:03:44 +0200	[thread overview]
Message-ID: <3e982fa0-1e26-5bd6-edc3-f45a387e5f5e@tessares.net> (raw)
In-Reply-To: 8e63b0163210cc5a63d7aa04142cce2fbb9c57eb.camel@linux.intel.com

[-- Attachment #1: Type: text/plain, Size: 1401 bytes --]

Hi Peter,

On 05/06/2019 20:14, Peter Krystad wrote:
> 
> Looks good to me Matthieu, thanks for the improvements.

Thank you for your review!

> Peter.
> 
> On Fri, 2019-05-31 at 17:18 +0200, Matthieu Baerts wrote:
>> The idea is to mimic what is done in tcp_init() and not ignore errors
>> from the init phase. It also simplifies the code as we don't have to
>> manage exit parts anymore.
>>
>> Can be squashed in:
>> - "mptcp: Add MPTCP socket stubs" (mptcp_init())
>> - "mptcp: Associate MPTCP context with TCP socket" (subflow_init())
>> - "mptcp: Create SUBFLOW socket for incoming connections" (subflow_ops)

- c99bd3897382: "squashed" in "mptcp: Add MPTCP socket stubs"
- 9e915dbce7e6: conflict
- 7cf2e6c94084 + 5c49d37d3a1a: "squashed" in "mptcp: Associate MPTCP
context with TCP socket"
- 5168793274d7: conflict
- 612ce5b15729: conflict
- a8115b9c533d: conflict
- 239f3baa2dc0: "squashed" in "mptcp: Create SUBFLOW socket for incoming
connections"
- 3016eb29bc0c: conflict
- fe95c134e25a: remove an useless 'return' after having applied this
full patch
- 4c9253e8e57e + 483f621c7151: add missing '\n' in the two new panic()
- 78190143f7fb..227976e0d2de: result

Cheers,
Matt
-- 
Matthieu Baerts | R&D Engineer
matthieu.baerts(a)tessares.net
Tessares SA | Hybrid Access Solutions
www.tessares.net
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium

             reply	other threads:[~2019-06-06 15:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-06 15:03 Matthieu Baerts [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-06-05 18:14 [MPTCP] [PATCH] mptcp:init: panic in case of error Peter Krystad
2019-05-31 15:18 Matthieu Baerts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3e982fa0-1e26-5bd6-edc3-f45a387e5f5e@tessares.net \
    --to=unknown@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.