All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Limonciello, Mario" <mario.limonciello@amd.com>
To: "Kammela, Gayatri" <gayatri.kammela@intel.com>,
	Rajneesh Bhardwaj <irenic.rajneesh@gmail.com>
Cc: "platform-driver-x86@vger.kernel.org" 
	<platform-driver-x86@vger.kernel.org>,
	"mgross@linux.intel.com" <mgross@linux.intel.com>,
	"hdegoede@redhat.com" <hdegoede@redhat.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	"vicamo.yang@canonical.com" <vicamo.yang@canonical.com>,
	"Pandruvada, Srinivas" <srinivas.pandruvada@intel.com>,
	"Box, David E" <david.e.box@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Mashiah, Tamar" <tamar.mashiah@intel.com>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"rajatja@google.com" <rajatja@google.com>,
	"Shyam-sundar.S-k@amd.com" <Shyam-sundar.S-k@amd.com>,
	"Alexander.Deucher@amd.com" <Alexander.Deucher@amd.com>,
	"mlimonci@amd.com" <mlimonci@amd.com>
Subject: Re: [PATCH v2 0/5] Add Alder Lake PCH-S support to PMC core driver
Date: Fri, 9 Jul 2021 13:30:58 -0500	[thread overview]
Message-ID: <3ea67145-f22d-a8fd-bdd1-35e774c8a1bc@amd.com> (raw)
In-Reply-To: <MW3PR11MB4523BCD490ABA17CE3B5FD94F2189@MW3PR11MB4523.namprd11.prod.outlook.com>

On 7/9/2021 12:40, Kammela, Gayatri wrote:
>> -----Original Message-----
>> From: Rajneesh Bhardwaj <irenic.rajneesh@gmail.com>
>> Sent: Thursday, July 8, 2021 10:33 AM
>> To: Kammela, Gayatri <gayatri.kammela@intel.com>
>> Cc: platform-driver-x86@vger.kernel.org; mgross@linux.intel.com;
>> hdegoede@redhat.com; Andy Shevchenko
>> <andriy.shevchenko@linux.intel.com>; vicamo.yang@canonical.com;
>> Pandruvada, Srinivas <srinivas.pandruvada@intel.com>; Box, David E
>> <david.e.box@intel.com>; linux-kernel@vger.kernel.org; Mashiah, Tamar
>> <tamar.mashiah@intel.com>; gregkh@linuxfoundation.org;
>> rajatja@google.com; Shyam-sundar.S-k@amd.com;
>> Alexander.Deucher@amd.com; mlimonci@amd.com
>> Subject: Re: [PATCH v2 0/5] Add Alder Lake PCH-S support to PMC core driver
>>
>> Series looks good to me.
>>
>> Acked-by: Rajneesh Bhardwaj <irenic.rajneesh@gmail.com>
> Thanks Rajneesh!
>>
>> + AMD folks
>>
>> Hi Alex, Mario and Shaym - Perhaps AMD PMC files should also follow the
>> similar convention and it could probably evolve in future where both x86
>> based PMC drivers might use some common library helper functions. What
>> do you think?

Gayatri,

If there is going to be PMC subfolder, then yes of course amd-pmc.c 
should move into it too.

Are you also thinking to move uPEP code from drivers/acpi/x86/s2idle.c 
into the PMC drivers?  Or do you have some suggestions on what code 
could be shared between AMD and Intel PMC drivers?

Thanks,

>>
>>
>> On Wed, Jul 7, 2021 at 10:10 PM Gayatri Kammela
>> <gayatri.kammela@intel.com> wrote:
>>>
>>> Hi,
>>> The patch series move intel_pmc_core* files to pmc subfolder as well
>>> as add Alder Lake PCH-S support to PMC core driver.
>>>
>>> Patch 1: Move intel_pmc_core* files to pmc subfolder Patch 2: Add
>>> Alderlake support to pmc_core driver Patch 3: Add Latency Tolerance
>>> Reporting (LTR) support to Alder Lake Patch 4: Add Alder Lake low
>>> power mode support for pmc_core Patch 5: Add GBE Package C10 fix for
>>> Alder Lake
>>>
>>> Changes since v1:
>>> 1) Add patch 1 to v2 i.e., Move intel_pmc_core* files to pmc subfolder
>>> 2) Modify commit message for patch 2.
>>>
>>> David E. Box (1):
>>>    platform/x86: intel_pmc_core: Add GBE Package C10 fix for Alder Lake
>>>      PCH
>>>
>>> Gayatri Kammela (4):
>>>    platform/x86: intel_pmc_core: Move intel_pmc_core* files to pmc
>>>      subfolder
>>>    platform/x86/intel: intel_pmc_core: Add Alderlake support to pmc_core
>>>      driver
>>>    platform/x86/intel: intel_pmc_core: Add Latency Tolerance Reporting
>>>      (LTR) support to Alder Lake
>>>    platform/x86/intel: intel_pmc_core: Add Alder Lake low power mode
>>>      support for pmc_core
>>>
>>>   drivers/platform/x86/Kconfig                  |  21 --
>>>   drivers/platform/x86/Makefile                 |   1 -
>>>   drivers/platform/x86/intel/Kconfig            |   1 +
>>>   drivers/platform/x86/intel/Makefile           |   1 +
>>>   drivers/platform/x86/intel/pmc/Kconfig        |  22 ++
>>>   drivers/platform/x86/intel/pmc/Makefile       |   5 +
>>>   .../x86/{ => intel/pmc}/intel_pmc_core.c      | 307 +++++++++++++++++-
>>>   .../x86/{ => intel/pmc}/intel_pmc_core.h      |  17 +
>>>   .../{ => intel/pmc}/intel_pmc_core_pltdrv.c   |   0
>>>   9 files changed, 350 insertions(+), 25 deletions(-)  create mode
>>> 100644 drivers/platform/x86/intel/pmc/Kconfig
>>>   create mode 100644 drivers/platform/x86/intel/pmc/Makefile
>>>   rename drivers/platform/x86/{ => intel/pmc}/intel_pmc_core.c (85%)
>>> rename drivers/platform/x86/{ => intel/pmc}/intel_pmc_core.h (95%)
>>> rename drivers/platform/x86/{ => intel/pmc}/intel_pmc_core_pltdrv.c
>>> (100%)
>>>
>>> Cc: Srinivas Pandruvada <srinivas.pandruvada@intel.com>
>>> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>>> Cc: David Box <david.e.box@intel.com>
>>> Cc: You-Sheng Yang <vicamo.yang@canonical.com>
>>> Cc: Hans de Goede <hdegoede@redhat.com>
>>>
>>> base-commit: a931dd33d370896a683236bba67c0d6f3d01144d
>>> --
>>> 2.25.1
>>>
>>
>>
>> --
>> Thanks,
>> Rajneesh


  reply	other threads:[~2021-07-09 18:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-08  2:07 Gayatri Kammela
2021-07-08  2:07 ` [PATCH v2 1/5] platform/x86/intel: intel_pmc_core: Move intel_pmc_core* files to pmc subfolder Gayatri Kammela
2021-07-08  7:56   ` Andy Shevchenko
2021-07-09 17:39     ` Kammela, Gayatri
2021-07-08  2:07 ` [PATCH v2 2/5] platform/x86/intel: intel_pmc_core: Add Alderlake support to pmc_core driver Gayatri Kammela
2021-07-08  2:07 ` [PATCH v2 3/5] platform/x86/intel: intel_pmc_core: Add Latency Tolerance Reporting (LTR) support to Alder Lake Gayatri Kammela
2021-07-08  2:07 ` [PATCH v2 4/5] platform/x86/intel: intel_pmc_core: Add Alder Lake low power mode support for pmc_core Gayatri Kammela
2021-07-08  2:07 ` [PATCH v2 5/5] platform/x86/intel: intel_pmc_core: Add GBE Package C10 fix for Alder Lake PCH Gayatri Kammela
2021-07-08 17:32 ` [PATCH v2 0/5] Add Alder Lake PCH-S support to PMC core driver Rajneesh Bhardwaj
2021-07-09 17:40   ` Kammela, Gayatri
2021-07-09 18:30     ` Limonciello, Mario [this message]
2021-07-09 23:01       ` Kammela, Gayatri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ea67145-f22d-a8fd-bdd1-35e774c8a1bc@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=Alexander.Deucher@amd.com \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=david.e.box@intel.com \
    --cc=gayatri.kammela@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hdegoede@redhat.com \
    --cc=irenic.rajneesh@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgross@linux.intel.com \
    --cc=mlimonci@amd.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rajatja@google.com \
    --cc=srinivas.pandruvada@intel.com \
    --cc=tamar.mashiah@intel.com \
    --cc=vicamo.yang@canonical.com \
    --subject='Re: [PATCH v2 0/5] Add Alder Lake PCH-S support to PMC core driver' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.