From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751168AbdGNSb0 (ORCPT ); Fri, 14 Jul 2017 14:31:26 -0400 Received: from esa5.dell-outbound.iphmx.com ([68.232.153.95]:10996 "EHLO esa5.dell-outbound.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751003AbdGNSbY (ORCPT ); Fri, 14 Jul 2017 14:31:24 -0400 From: X-LoopCount0: from 10.175.218.62 X-IronPort-AV: E=Sophos;i="5.40,359,1496120400"; d="scan'208";a="964538027" X-DLP: DLP_GlobalPCIDSS To: , , , CC: , , , , , , , , , , , Subject: RE: [PATCH 17/22] platform/x86: alienware-wmi: fix format string overflow warning Thread-Topic: [PATCH 17/22] platform/x86: alienware-wmi: fix format string overflow warning Thread-Index: AQHS/JpkQOMssDvFTUGJ7pVu9YrXOaJTpPWQ Date: Fri, 14 Jul 2017 18:30:25 +0000 Message-ID: <3eaa1de8d1074c96a9491a823a6a4af2@ausx13mpc120.AMER.DELL.COM> References: <20170714120720.906842-1-arnd@arndb.de> <20170714120720.906842-18-arnd@arndb.de> In-Reply-To: <20170714120720.906842-18-arnd@arndb.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.143.242.75] Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v6EIVYm9030406 > -----Original Message----- > From: Arnd Bergmann [mailto:arnd@arndb.de] > Sent: Friday, July 14, 2017 7:07 AM > To: linux-kernel@vger.kernel.org; Darren Hart ; Andy > Shevchenko > Cc: Greg Kroah-Hartman ; Linus Torvalds > ; Guenter Roeck ; > akpm@linux-foundation.org; netdev@vger.kernel.org; David S . Miller > ; James E . J . Bottomley ; > Martin K . Petersen ; linux-scsi@vger.kernel.org; > x86@kernel.org; Arnd Bergmann ; Limonciello, Mario > ; Arvind Yadav ; > platform-driver-x86@vger.kernel.org > Subject: [PATCH 17/22] platform/x86: alienware-wmi: fix format string overflow > warning > > gcc points out a possible format string overflow for a large value of 'zone': > > drivers/platform/x86/alienware-wmi.c: In function 'alienware_wmi_init': > drivers/platform/x86/alienware-wmi.c:461:24: error: '%02X' directive writing > between 2 and 8 bytes into a region of size 6 [-Werror=format-overflow=] > sprintf(buffer, "zone%02X", i); > ^~~~ > drivers/platform/x86/alienware-wmi.c:461:19: note: directive argument in the > range [0, 2147483646] > sprintf(buffer, "zone%02X", i); > ^~~~~~~~~~ > drivers/platform/x86/alienware-wmi.c:461:3: note: 'sprintf' output between 7 and > 13 bytes into a destination of size 10 > > While the zone should never be that large, it's easy to make the > buffer a few bytes longer so gcc can prove this to be safe. > > Signed-off-by: Arnd Bergmann > --- > drivers/platform/x86/alienware-wmi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/alienware-wmi.c > b/drivers/platform/x86/alienware-wmi.c > index 0831b428c217..acc01242da82 100644 > --- a/drivers/platform/x86/alienware-wmi.c > +++ b/drivers/platform/x86/alienware-wmi.c > @@ -421,7 +421,7 @@ static DEVICE_ATTR(lighting_control_state, 0644, > show_control_state, > static int alienware_zone_init(struct platform_device *dev) > { > int i; > - char buffer[10]; > + char buffer[13]; > char *name; > > if (interface == WMAX) { > -- > 2.9.0 LGTM, Thanks. Signed-off-by: Mario Limonciello From mboxrd@z Thu Jan 1 00:00:00 1970 From: Subject: RE: [PATCH 17/22] platform/x86: alienware-wmi: fix format string overflow warning Date: Fri, 14 Jul 2017 18:30:25 +0000 Message-ID: <3eaa1de8d1074c96a9491a823a6a4af2@ausx13mpc120.AMER.DELL.COM> References: <20170714120720.906842-1-arnd@arndb.de> <20170714120720.906842-18-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20170714120720.906842-18-arnd@arndb.de> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: arnd@arndb.de, linux-kernel@vger.kernel.org, dvhart@infradead.org, andy@infradead.org Cc: gregkh@linuxfoundation.org, torvalds@linux-foundation.org, linux@roeck-us.net, akpm@linux-foundation.org, netdev@vger.kernel.org, davem@davemloft.net, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, x86@kernel.org, arvind.yadav.cs@gmail.com, platform-driver-x86@vger.kernel.org List-Id: platform-driver-x86.vger.kernel.org > -----Original Message----- > From: Arnd Bergmann [mailto:arnd@arndb.de] > Sent: Friday, July 14, 2017 7:07 AM > To: linux-kernel@vger.kernel.org; Darren Hart ; And= y > Shevchenko > Cc: Greg Kroah-Hartman ; Linus Torvalds > ; Guenter Roeck ; > akpm@linux-foundation.org; netdev@vger.kernel.org; David S . Miller > ; James E . J . Bottomley ; > Martin K . Petersen ; linux-scsi@vger.kernel.= org; > x86@kernel.org; Arnd Bergmann ; Limonciello, Mario > ; Arvind Yadav ; > platform-driver-x86@vger.kernel.org > Subject: [PATCH 17/22] platform/x86: alienware-wmi: fix format string ove= rflow > warning >=20 > gcc points out a possible format string overflow for a large value of 'zo= ne': >=20 > drivers/platform/x86/alienware-wmi.c: In function 'alienware_wmi_init': > drivers/platform/x86/alienware-wmi.c:461:24: error: '%02X' directive writ= ing > between 2 and 8 bytes into a region of size 6 [-Werror=3Dformat-overflow= =3D] > sprintf(buffer, "zone%02X", i); > ^~~~ > drivers/platform/x86/alienware-wmi.c:461:19: note: directive argument in = the > range [0, 2147483646] > sprintf(buffer, "zone%02X", i); > ^~~~~~~~~~ > drivers/platform/x86/alienware-wmi.c:461:3: note: 'sprintf' output betwee= n 7 and > 13 bytes into a destination of size 10 >=20 > While the zone should never be that large, it's easy to make the > buffer a few bytes longer so gcc can prove this to be safe. >=20 > Signed-off-by: Arnd Bergmann > --- > drivers/platform/x86/alienware-wmi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/platform/x86/alienware-wmi.c > b/drivers/platform/x86/alienware-wmi.c > index 0831b428c217..acc01242da82 100644 > --- a/drivers/platform/x86/alienware-wmi.c > +++ b/drivers/platform/x86/alienware-wmi.c > @@ -421,7 +421,7 @@ static DEVICE_ATTR(lighting_control_state, 0644, > show_control_state, > static int alienware_zone_init(struct platform_device *dev) > { > int i; > - char buffer[10]; > + char buffer[13]; > char *name; >=20 > if (interface =3D=3D WMAX) { > -- > 2.9.0 LGTM, Thanks. Signed-off-by: Mario Limonciello