From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935812AbcIUQeS (ORCPT ); Wed, 21 Sep 2016 12:34:18 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:35668 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933271AbcIUQeQ (ORCPT ); Wed, 21 Sep 2016 12:34:16 -0400 Reply-To: minyard@acm.org Subject: Re: [PATCH] ipmi: Fix ioremap error handling in bt-bmc References: <20160921100553.16314-1-joel@jms.id.au> <789d8d52-7ce0-deee-617b-2502a7a3eb93@kaod.org> To: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Joel Stanley Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org From: Corey Minyard Message-ID: <3eafb21f-f716-c04b-41c6-ce2f4e7701f7@acm.org> Date: Wed, 21 Sep 2016 11:34:10 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <789d8d52-7ce0-deee-617b-2502a7a3eb93@kaod.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/21/2016 05:17 AM, Cédric Le Goater wrote: > On 09/21/2016 12:05 PM, Joel Stanley wrote: >> devm_ioremap_resource returns ERR_PTR so we can't check for NULL. > Thanks for spotting this. > > Acked-by: Cédric Le Goater Thanks, I've pull this into my tree. -corey > C. > >> Signed-off-by: Joel Stanley >> --- >> drivers/char/ipmi/bt-bmc.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/char/ipmi/bt-bmc.c b/drivers/char/ipmi/bt-bmc.c >> index 2e880bf0be26..de64bf1f2f4d 100644 >> --- a/drivers/char/ipmi/bt-bmc.c >> +++ b/drivers/char/ipmi/bt-bmc.c >> @@ -438,8 +438,8 @@ static int bt_bmc_probe(struct platform_device *pdev) >> } >> >> bt_bmc->base = devm_ioremap_resource(&pdev->dev, res); >> - if (!bt_bmc->base) >> - return -ENOMEM; >> + if (IS_ERR(bt_bmc->base)) >> + return PTR_ERR(bt_bmc->base); >> >> mutex_init(&bt_bmc->mutex); >> init_waitqueue_head(&bt_bmc->queue); >>