From: John Crispin <john@phrozen.org>
To: kbuild test robot <lkp@intel.com>
Cc: Sean Wang <keyhaede@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mediatek@lists.infradead.org, kbuild-all@01.org,
"David S. Miller" <davem@davemloft.net>,
Felix Fietkau <nbd@nbd.name>
Subject: Re: [PATCH V2 2/4] net-next: mediatek: don't use intermediate variables to store IRQ masks
Date: Thu, 30 Jun 2016 09:33:33 +0200 [thread overview]
Message-ID: <3eb8dd5f-7b21-a2f5-dbd5-9016bf328753@phrozen.org> (raw)
In-Reply-To: <201606301404.EoyOs9Sz%fengguang.wu@intel.com>
On 30/06/2016 08:03, kbuild test robot wrote:
> Hi,
>
> [auto build test ERROR on net/master]
> [also build test ERROR on v4.7-rc5 next-20160629]
> [cannot apply to net-next/master]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url: https://github.com/0day-ci/linux/commits/John-Crispin/net-next-mediatek-IRQ-cleanups-fixes-and-grouping/20160629-194341
> config: arm-allmodconfig (attached as .config)
> compiler: arm-linux-gnueabi-gcc (Debian 5.3.1-8) 5.3.1 20160205
> reproduce:
> wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # save the attached .config to linux build tree
> make.cross ARCH=arm
>
> Note: the linux-review/John-Crispin/net-next-mediatek-IRQ-cleanups-fixes-and-grouping/20160629-194341 HEAD e8462c612b33003fba7c1a70328c7fb7872d8507 builds fine.
> It only hurts bisectibility.
>
> All errors (new ones prefixed by >>):
>
> drivers/net/ethernet/mediatek/mtk_eth_soc.c: In function 'mtk_poll':
>>> drivers/net/ethernet/mediatek/mtk_eth_soc.c:1003:16: error: 'tx_intr' undeclared (first use in this function)
> if (status & (tx_intr | rx_intr))
> ^
> drivers/net/ethernet/mediatek/mtk_eth_soc.c:1003:16: note: each undeclared identifier is reported only once for each function it appears in
>>> drivers/net/ethernet/mediatek/mtk_eth_soc.c:1003:26: error: 'rx_intr' undeclared (first use in this function)
> if (status & (tx_intr | rx_intr))
> ^
>
> vim +/tx_intr +1003 drivers/net/ethernet/mediatek/mtk_eth_soc.c
>
> 656e7052 John Crispin 2016-03-08 997 }
> 656e7052 John Crispin 2016-03-08 998
> 656e7052 John Crispin 2016-03-08 999 if (tx_again || rx_done == budget)
> 656e7052 John Crispin 2016-03-08 1000 return budget;
> 656e7052 John Crispin 2016-03-08 1001
> 656e7052 John Crispin 2016-03-08 1002 status = mtk_r32(eth, MTK_QMTK_INT_STATUS);
> 656e7052 John Crispin 2016-03-08 @1003 if (status & (tx_intr | rx_intr))
> 656e7052 John Crispin 2016-03-08 1004 return budget;
> 656e7052 John Crispin 2016-03-08 1005
> 656e7052 John Crispin 2016-03-08 1006 napi_complete(napi);
>
> :::::: The code at line 1003 was first introduced by commit
> :::::: 656e705243fd0c2864b89634ea16ed444ef64dc6 net-next: mediatek: add support for MT7623 ethernet
>
> :::::: TO: John Crispin <blogic@openwrt.org>
> :::::: CC: David S. Miller <davem@davemloft.net>
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
Hi,
This series depends on a previous series currently sitting in net.git
starting with
commit 562c5a70400c ("net: mediatek: only wake the queue if it is stopped")
up to
commit 82c6544dddc6 ("net: mediatek: remove superfluous queue wake up
call")
i just double checked and with the series applied this compile error is gone
John
next prev parent reply other threads:[~2016-06-30 7:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 11:38 [PATCH V2 0/4] net-next: mediatek: IRQ cleanups, fixes and grouping John Crispin
2016-06-29 11:38 ` [PATCH V2 1/4] net-next: mediatek: remove superfluous register reads John Crispin
2016-06-29 11:38 ` [PATCH V2 2/4] net-next: mediatek: don't use intermediate variables to store IRQ masks John Crispin
2016-06-29 11:38 ` John Crispin
2016-06-30 6:03 ` kbuild test robot
2016-06-30 6:03 ` kbuild test robot
2016-06-30 7:33 ` John Crispin [this message]
2016-06-29 11:38 ` [PATCH V2 3/4] net-next: mediatek: add IRQ locking John Crispin
2016-06-29 11:38 ` John Crispin
2016-06-29 11:38 ` [PATCH V2 4/4] net-next: mediatek: add support for IRQ grouping John Crispin
2016-06-29 11:38 ` John Crispin
2016-06-30 5:04 ` kbuild test robot
2016-06-30 5:04 ` kbuild test robot
2016-06-30 12:52 ` [PATCH V2 0/4] net-next: mediatek: IRQ cleanups, fixes and grouping David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3eb8dd5f-7b21-a2f5-dbd5-9016bf328753@phrozen.org \
--to=john@phrozen.org \
--cc=davem@davemloft.net \
--cc=kbuild-all@01.org \
--cc=keyhaede@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lkp@intel.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.