From: Martin Peres <martin.peres-GANU6spQydw@public.gmane.org>
To: Emil Velikov <emil.l.velikov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: ML nouveau <nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: Re: [PATCH v2] drm/nouveau: add a LED driver for the NVIDIA logo
Date: Wed, 24 Aug 2016 15:11:12 +0300 [thread overview]
Message-ID: <3ebd3427-7b8c-00bb-acce-6624fe8b8718@free.fr> (raw)
In-Reply-To: <CACvgo53YUjHyE=xqYHFENG7=pOsMSpQ+x-bNszd5ENNz305t5g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 23/08/16 17:43, Emil Velikov wrote:
> On 23 August 2016 at 00:42, Martin Peres <martin.peres@free.fr> wrote:
>> v2:
>> - guard LED framework calls with ifdef CONFIG_LEDS_CLASS
>>
> IIRC kernel has the tendency of using static inlines in the headers
> when CONFIG_foo is not set. Worth using that and removing the ifdef
> from the source file ?
Oh, you mean, re-defining the functions I use but make them do nothing.
However, I should do it in the source file and not in the header since I do
not want to export these symbols outside of the object.
Do you have an example to share? Anyway, this seems like a good
candidate to reduce the number of ifdefs. Thanks!
Martin
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
next prev parent reply other threads:[~2016-08-24 12:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 23:51 [PATCH] drm/nouveau: add a LED driver for the NVIDIA logo Martin Peres
[not found] ` <1462319465-29090-1-git-send-email-martin.peres-GANU6spQydw@public.gmane.org>
2016-05-03 23:57 ` Ilia Mirkin
[not found] ` <CAKb7UvgJtR=LEDC4cnpnq61E-e4EREpbB8xZ5aZtFpHuTdyCwQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-05-04 0:09 ` Martin Peres
2016-05-07 20:44 ` karol herbst
[not found] ` <CAEXux-aYNK0w=0vBgDv_MAbcrD9LOyf9X-2GVrFh4noESfViyA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-05-07 21:25 ` Martin Peres
2016-08-22 23:42 ` [PATCH v2] " Martin Peres
[not found] ` <20160822234257.6523-1-martin.peres-GANU6spQydw@public.gmane.org>
2016-08-23 14:43 ` Emil Velikov
[not found] ` <CACvgo53YUjHyE=xqYHFENG7=pOsMSpQ+x-bNszd5ENNz305t5g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-08-24 12:11 ` Martin Peres [this message]
[not found] ` <3ebd3427-7b8c-00bb-acce-6624fe8b8718-GANU6spQydw@public.gmane.org>
2016-08-24 12:22 ` Lukas Wunner
2016-08-24 12:38 ` Karol Herbst
2016-08-24 12:49 ` Emil Velikov
2016-08-23 8:31 ` Karol Herbst
[not found] ` <CAEXux-aiPzgA8dqfcekfx0-P91RPXiBVFYjVw-9=QmpsWCWiHA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-08-23 14:06 ` Martin Peres
[not found] ` <f8049c1c-d82c-e9c7-a2c6-632fe98dc0e7-GANU6spQydw@public.gmane.org>
2016-08-23 14:38 ` Karol Herbst
2016-08-25 0:48 ` [PATCH v3] " Martin Peres
2016-08-25 0:57 ` [PATCH v3 take 2] " Martin Peres
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ebd3427-7b8c-00bb-acce-6624fe8b8718@free.fr \
--to=martin.peres-ganu6spqydw@public.gmane.org \
--cc=emil.l.velikov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.