From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 6/7] ARM: imx: novena: Enable DM PCI
Date: Sun, 9 Jun 2019 03:49:57 +0200 [thread overview]
Message-ID: <3eca7537-0f24-1e45-e7ad-72741d7d27ee@denx.de> (raw)
In-Reply-To: <74fb4f6c-d30e-c339-ad4a-38beee38cbfe@denx.de>
On 6/8/19 10:45 PM, Stefano Babic wrote:
> Hi Marek,
>
> On 17/05/19 20:32, Marek Vasut wrote:
>> Enable DM PCI support on iMX6Q Novena.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Cc: Fabio Estevam <fabio.estevam@nxp.com>
>> Cc: Stefano Babic <sbabic@denx.de>
>> Cc: Vagrant Cascadian <vagrant@debian.org>
>> ---
>> V2: New patch
>> ---
>> configs/novena_defconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/configs/novena_defconfig b/configs/novena_defconfig
>> index c5dbbb0b4d..bbed972a44 100644
>> --- a/configs/novena_defconfig
>> +++ b/configs/novena_defconfig
>> @@ -56,6 +56,7 @@ CONFIG_PHY_MICREL=y
>> CONFIG_PHY_MICREL_KSZ90X1=y
>> CONFIG_MII=y
>> CONFIG_PCI=y
>> +CONFIG_DM_PCI=y
>> CONFIG_PINCTRL=y
>> CONFIG_PINCTRL_IMX6=y
>> CONFIG_DM_SCSI=y
>>
>
> I cannot build novena with this enabled - do you see the same error or
> am I missing something ?
>
> arm: + novena
> + pci_set_ops(hose,
> + ^~~~~~~~~~~
> +drivers/pci/pcie_imx.c:686:7: error:
> ?pci_hose_read_config_byte_via_dword? undeclared (first use in this
> function)
> + pci_hose_read_config_byte_via_dword,
> + ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> +drivers/pci/pcie_imx.c:686:7: note: each undeclared identifier is
> reported only once for each function it appears in
> +drivers/pci/pcie_imx.c:687:7: error:
> ?pci_hose_read_config_word_via_dword? undeclared (first use in this
> function)
> + pci_hose_read_config_word_via_dword,
> +drivers/pci/pcie_imx.c:689:7: error:
> ?pci_hose_write_config_byte_via_dword? undeclared (first use in this
> function)
> + pci_hose_write_config_byte_via_dword,
> + ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> +drivers/pci/pcie_imx.c:690:7: error:
> ?pci_hose_write_config_word_via_dword? undeclared (first use in this
> function)
> + pci_hose_write_config_word_via_dword,
> + pci_register_hose(hose);
> + ^~~~~~~~~~~~~~~~~
> + hose->last_busno = pci_hose_scan(hose);
> + ^~~~~~~~~~~~~
> +make[3]: *** [drivers/pci/pcie_imx.o] Error 1
> +make[2]: *** [drivers/pci] Error 2
> +make[1]: *** [drivers] Error 2
> +make: *** [sub-make] Error 2
> w+drivers/pci/pcie_imx.c: In function ?imx_pcie_init?:
> w+drivers/pci/pcie_imx.c:685:2: warning: implicit declaration of
> function ?pci_set_ops? [-Wimplicit-function-declaration]
> w+drivers/pci/pcie_imx.c:697:3: warning: implicit declaration of
> function ?pci_register_hose? [-Wimplicit-function-declaration]
> w+drivers/pci/pcie_imx.c:698:22: warning: implicit declaration of
> function ?pci_hose_scan? [-Wimplicit-function-declaration]
I collected the patches here [1], CI passed:
https://github.com/marex/u-boot-imx/tree/imx-dm
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2019-06-09 1:49 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 18:32 [U-Boot] [PATCH V2 0/7] ARM: imx: Update Novena to DM/DT Marek Vasut
2019-05-17 18:32 ` [U-Boot] [PATCH V2 1/7] ARM: dts: imx: novena: Import Novena DT from Linux Marek Vasut
2019-06-10 9:59 ` [U-Boot] [PATCH V2 1/7] ARM: dts: imx: novena: Import Novena DT sbabic at denx.de
2019-05-17 18:32 ` [U-Boot] [PATCH V2 2/7] ARM: imx: novena: Enable DM pin control Marek Vasut
2019-06-10 9:49 ` sbabic at denx.de
2019-05-17 18:32 ` [U-Boot] [PATCH V2 3/7] ARM: imx: novena: Enable DM GPIO Marek Vasut
2019-06-10 9:49 ` sbabic at denx.de
2019-05-17 18:32 ` [U-Boot] [PATCH V2 4/7] ARM: imx: novena: Convert block devices to DM Marek Vasut
2019-06-10 9:40 ` sbabic at denx.de
2019-05-17 18:32 ` [U-Boot] [PATCH V2 5/7] ARM: imx: novena: Enable DM USB Marek Vasut
2019-06-10 9:41 ` sbabic at denx.de
2019-05-17 18:32 ` [U-Boot] [PATCH V2 6/7] ARM: imx: novena: Enable DM PCI Marek Vasut
2019-06-08 20:45 ` Stefano Babic
2019-06-09 1:49 ` Marek Vasut [this message]
2019-06-09 7:34 ` Stefano Babic
2019-06-10 9:39 ` sbabic at denx.de
2019-05-17 18:32 ` [U-Boot] [PATCH V2 7/7] ARM: imx: novena: Convert to DM VIDEO Marek Vasut
2019-06-10 9:59 ` sbabic at denx.de
2019-06-04 7:06 ` [U-Boot] [PATCH V2 0/7] ARM: imx: Update Novena to DM/DT Vagrant Cascadian
2019-06-06 17:17 ` Vagrant Cascadian
2019-06-07 19:09 ` Marek Vasut
2019-08-19 12:37 ` Marek Vasut
2019-08-20 17:41 ` Vagrant Cascadian
2019-09-26 18:52 ` [U-Boot] dcache issues with wandboard too (was: [PATCH V2 0/7] ARM: imx: Update Novena to DM/DT) Vagrant Cascadian
2019-09-26 19:59 ` Marek Vasut
2020-01-27 0:02 ` [PATCH V2 0/7] ARM: imx: Update Novena to DM/DT Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3eca7537-0f24-1e45-e7ad-72741d7d27ee@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.