From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51C5BC38A2D for ; Wed, 26 Oct 2022 10:30:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230057AbiJZKaQ (ORCPT ); Wed, 26 Oct 2022 06:30:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233180AbiJZKaO (ORCPT ); Wed, 26 Oct 2022 06:30:14 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A139741D3C for ; Wed, 26 Oct 2022 03:30:13 -0700 (PDT) Received: from [192.168.1.15] (91-154-32-225.elisa-laajakaista.fi [91.154.32.225]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id AEF214F8; Wed, 26 Oct 2022 12:30:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1666780210; bh=Sfk+sY2PkQcCuOdrWM5zFeMRlAQPq29owCfvhuwKSnw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=uzWSslpIUV03O4VvsgzSSuTbXe7YSsT0Oi6To9+A+lXHLQXqJDzpn7YHrEckAl+zR f0pnetIgMuorppSTy4aErSJ1QqgzF7wn9jedA1JyVL+En50db61QVxAMhjW9aQBbT1 AJzL6ReMShmBMpkJCg44wDSBqDZeJb/QkNFRMMgI= Message-ID: <3ee50202-30c5-3c24-2cda-d1ee7cff65e8@ideasonboard.com> Date: Wed, 26 Oct 2022 13:30:07 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v2 2/7] drm/probe-helper: enable and disable HPD on connectors Content-Language: en-US To: Dmitry Baryshkov , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Laurentiu Palcu , Lucas Stach , Philipp Zabel , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rob Clark , Sean Paul , Abhinav Kumar Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org References: <20221024153926.3222225-1-dmitry.baryshkov@linaro.org> <20221024153926.3222225-3-dmitry.baryshkov@linaro.org> From: Tomi Valkeinen In-Reply-To: <20221024153926.3222225-3-dmitry.baryshkov@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 24/10/2022 18:39, Dmitry Baryshkov wrote: > Intruct two drm_connector_helper_funcs: enable_hpd() and disable_hpd(). "Introduce"? > They are called by drm_kms_helper_poll_enable() and > drm_kms_helper_poll_disable() (and thus drm_kms_helper_poll_init() and > drm_kms_helper_poll_fini()) respectively. > > This allows drivers to rely on drm_kms_helper_poll for enabling and > disabling HPD detection rather than doing that manually. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/drm_probe_helper.c | 19 +++++++++++++++++++ > include/drm/drm_modeset_helper_vtables.h | 22 ++++++++++++++++++++++ > 2 files changed, 41 insertions(+) > > diff --git a/drivers/gpu/drm/drm_probe_helper.c b/drivers/gpu/drm/drm_probe_helper.c > index f97fda3b1d34..a7b4590d8ec1 100644 > --- a/drivers/gpu/drm/drm_probe_helper.c > +++ b/drivers/gpu/drm/drm_probe_helper.c > @@ -251,6 +251,12 @@ void drm_kms_helper_poll_enable(struct drm_device *dev) > > drm_connector_list_iter_begin(dev, &conn_iter); > drm_for_each_connector_iter(connector, &conn_iter) { > + const struct drm_connector_helper_funcs *funcs = > + connector->helper_private; > + > + if (funcs && funcs->enable_hpd) > + funcs->enable_hpd(connector); > + > if (connector->polled & (DRM_CONNECTOR_POLL_CONNECT | > DRM_CONNECTOR_POLL_DISCONNECT)) > poll = true; > @@ -805,12 +811,25 @@ EXPORT_SYMBOL(drm_kms_helper_is_poll_worker); > > static void drm_kms_helper_poll_disable_fini(struct drm_device *dev, bool fini) > { > + struct drm_connector *connector; > + struct drm_connector_list_iter conn_iter; > + > if (!dev->mode_config.poll_enabled) > return; > > if (fini) > dev->mode_config.poll_enabled = false; > > + drm_connector_list_iter_begin(dev, &conn_iter); > + drm_for_each_connector_iter(connector, &conn_iter) { > + const struct drm_connector_helper_funcs *funcs = > + connector->helper_private; > + > + if (funcs && funcs->disable_hpd) > + funcs->disable_hpd(connector); > + } > + drm_connector_list_iter_end(&conn_iter); > + > cancel_delayed_work_sync(&dev->mode_config.output_poll_work); > } > > diff --git a/include/drm/drm_modeset_helper_vtables.h b/include/drm/drm_modeset_helper_vtables.h > index fafa70ac1337..7aa1f01223f9 100644 > --- a/include/drm/drm_modeset_helper_vtables.h > +++ b/include/drm/drm_modeset_helper_vtables.h > @@ -1143,6 +1143,28 @@ struct drm_connector_helper_funcs { > */ > void (*cleanup_writeback_job)(struct drm_writeback_connector *connector, > struct drm_writeback_job *job); > + > + /** > + * @enable_hpd: > + * > + * Enable hot-plug detection for the connector. > + * > + * This operation is optional. > + * > + * This callback is used by the drm_kms_helper_poll_enable() helpers. > + */ > + void (*enable_hpd)(struct drm_connector *connector); > + > + /** > + * @disable_hpd: > + * > + * Disable hot-plug detection for the connector. > + * > + * This operation is optional. > + * > + * This callback is used by the drm_kms_helper_poll_disable() helpers. > + */ > + void (*disable_hpd)(struct drm_connector *connector); > }; > > /** From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF1CAC433FE for ; Wed, 26 Oct 2022 10:30:21 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DAD8110E4A8; Wed, 26 Oct 2022 10:30:19 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2F5D410E26A; Wed, 26 Oct 2022 10:30:12 +0000 (UTC) Received: from [192.168.1.15] (91-154-32-225.elisa-laajakaista.fi [91.154.32.225]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id AEF214F8; Wed, 26 Oct 2022 12:30:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1666780210; bh=Sfk+sY2PkQcCuOdrWM5zFeMRlAQPq29owCfvhuwKSnw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=uzWSslpIUV03O4VvsgzSSuTbXe7YSsT0Oi6To9+A+lXHLQXqJDzpn7YHrEckAl+zR f0pnetIgMuorppSTy4aErSJ1QqgzF7wn9jedA1JyVL+En50db61QVxAMhjW9aQBbT1 AJzL6ReMShmBMpkJCg44wDSBqDZeJb/QkNFRMMgI= Message-ID: <3ee50202-30c5-3c24-2cda-d1ee7cff65e8@ideasonboard.com> Date: Wed, 26 Oct 2022 13:30:07 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v2 2/7] drm/probe-helper: enable and disable HPD on connectors Content-Language: en-US To: Dmitry Baryshkov , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Laurentiu Palcu , Lucas Stach , Philipp Zabel , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rob Clark , Sean Paul , Abhinav Kumar References: <20221024153926.3222225-1-dmitry.baryshkov@linaro.org> <20221024153926.3222225-3-dmitry.baryshkov@linaro.org> From: Tomi Valkeinen In-Reply-To: <20221024153926.3222225-3-dmitry.baryshkov@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 24/10/2022 18:39, Dmitry Baryshkov wrote: > Intruct two drm_connector_helper_funcs: enable_hpd() and disable_hpd(). "Introduce"? > They are called by drm_kms_helper_poll_enable() and > drm_kms_helper_poll_disable() (and thus drm_kms_helper_poll_init() and > drm_kms_helper_poll_fini()) respectively. > > This allows drivers to rely on drm_kms_helper_poll for enabling and > disabling HPD detection rather than doing that manually. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/drm_probe_helper.c | 19 +++++++++++++++++++ > include/drm/drm_modeset_helper_vtables.h | 22 ++++++++++++++++++++++ > 2 files changed, 41 insertions(+) > > diff --git a/drivers/gpu/drm/drm_probe_helper.c b/drivers/gpu/drm/drm_probe_helper.c > index f97fda3b1d34..a7b4590d8ec1 100644 > --- a/drivers/gpu/drm/drm_probe_helper.c > +++ b/drivers/gpu/drm/drm_probe_helper.c > @@ -251,6 +251,12 @@ void drm_kms_helper_poll_enable(struct drm_device *dev) > > drm_connector_list_iter_begin(dev, &conn_iter); > drm_for_each_connector_iter(connector, &conn_iter) { > + const struct drm_connector_helper_funcs *funcs = > + connector->helper_private; > + > + if (funcs && funcs->enable_hpd) > + funcs->enable_hpd(connector); > + > if (connector->polled & (DRM_CONNECTOR_POLL_CONNECT | > DRM_CONNECTOR_POLL_DISCONNECT)) > poll = true; > @@ -805,12 +811,25 @@ EXPORT_SYMBOL(drm_kms_helper_is_poll_worker); > > static void drm_kms_helper_poll_disable_fini(struct drm_device *dev, bool fini) > { > + struct drm_connector *connector; > + struct drm_connector_list_iter conn_iter; > + > if (!dev->mode_config.poll_enabled) > return; > > if (fini) > dev->mode_config.poll_enabled = false; > > + drm_connector_list_iter_begin(dev, &conn_iter); > + drm_for_each_connector_iter(connector, &conn_iter) { > + const struct drm_connector_helper_funcs *funcs = > + connector->helper_private; > + > + if (funcs && funcs->disable_hpd) > + funcs->disable_hpd(connector); > + } > + drm_connector_list_iter_end(&conn_iter); > + > cancel_delayed_work_sync(&dev->mode_config.output_poll_work); > } > > diff --git a/include/drm/drm_modeset_helper_vtables.h b/include/drm/drm_modeset_helper_vtables.h > index fafa70ac1337..7aa1f01223f9 100644 > --- a/include/drm/drm_modeset_helper_vtables.h > +++ b/include/drm/drm_modeset_helper_vtables.h > @@ -1143,6 +1143,28 @@ struct drm_connector_helper_funcs { > */ > void (*cleanup_writeback_job)(struct drm_writeback_connector *connector, > struct drm_writeback_job *job); > + > + /** > + * @enable_hpd: > + * > + * Enable hot-plug detection for the connector. > + * > + * This operation is optional. > + * > + * This callback is used by the drm_kms_helper_poll_enable() helpers. > + */ > + void (*enable_hpd)(struct drm_connector *connector); > + > + /** > + * @disable_hpd: > + * > + * Disable hot-plug detection for the connector. > + * > + * This operation is optional. > + * > + * This callback is used by the drm_kms_helper_poll_disable() helpers. > + */ > + void (*disable_hpd)(struct drm_connector *connector); > }; > > /** From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95D81C433FE for ; Wed, 26 Oct 2022 10:31:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iJOItqN5mgvrsxoyCkge666UTukf24RefS9CCsRxmrE=; b=Ds1wDKUfYY0keM FStS3pNM2GrzQcjmaVij5nHymLWQRp3z0EY2qtPM6iO1TcrzJ4yWjakvctpOuz5c5Nhy6o7ZlGptq hw/l8gYWWjvM6GNbQakDx5XBa+LbNxHFBcKBlz2dnOSVZoSd5eyp7NoqBt9PblYDe3ES8UXOW/lsj EkGEhozyNglRnjQUwpXBJ9biDNO48YsTnEyKFkfkDmuhyDQMirDwnODwIPb+/i/S6897Va5JmlH8D 7wI/mCRNnVtTLsmI2rxr0STrNPl6Ib+AQ7Jtw52T5qLRJ6yfu/iCfQ/TMafbFrU0SCoMsf8A4pR85 4ZRCmxgmZkdGaiHun/Vg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ondg3-008va3-8C; Wed, 26 Oct 2022 10:30:27 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ondfz-008vYp-9O for linux-arm-kernel@lists.infradead.org; Wed, 26 Oct 2022 10:30:24 +0000 Received: from [192.168.1.15] (91-154-32-225.elisa-laajakaista.fi [91.154.32.225]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id AEF214F8; Wed, 26 Oct 2022 12:30:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1666780210; bh=Sfk+sY2PkQcCuOdrWM5zFeMRlAQPq29owCfvhuwKSnw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=uzWSslpIUV03O4VvsgzSSuTbXe7YSsT0Oi6To9+A+lXHLQXqJDzpn7YHrEckAl+zR f0pnetIgMuorppSTy4aErSJ1QqgzF7wn9jedA1JyVL+En50db61QVxAMhjW9aQBbT1 AJzL6ReMShmBMpkJCg44wDSBqDZeJb/QkNFRMMgI= Message-ID: <3ee50202-30c5-3c24-2cda-d1ee7cff65e8@ideasonboard.com> Date: Wed, 26 Oct 2022 13:30:07 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v2 2/7] drm/probe-helper: enable and disable HPD on connectors Content-Language: en-US To: Dmitry Baryshkov , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Laurentiu Palcu , Lucas Stach , Philipp Zabel , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rob Clark , Sean Paul , Abhinav Kumar Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org References: <20221024153926.3222225-1-dmitry.baryshkov@linaro.org> <20221024153926.3222225-3-dmitry.baryshkov@linaro.org> From: Tomi Valkeinen In-Reply-To: <20221024153926.3222225-3-dmitry.baryshkov@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221026_033023_529415_F87051F9 X-CRM114-Status: GOOD ( 18.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 24/10/2022 18:39, Dmitry Baryshkov wrote: > Intruct two drm_connector_helper_funcs: enable_hpd() and disable_hpd(). "Introduce"? > They are called by drm_kms_helper_poll_enable() and > drm_kms_helper_poll_disable() (and thus drm_kms_helper_poll_init() and > drm_kms_helper_poll_fini()) respectively. > > This allows drivers to rely on drm_kms_helper_poll for enabling and > disabling HPD detection rather than doing that manually. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/drm_probe_helper.c | 19 +++++++++++++++++++ > include/drm/drm_modeset_helper_vtables.h | 22 ++++++++++++++++++++++ > 2 files changed, 41 insertions(+) > > diff --git a/drivers/gpu/drm/drm_probe_helper.c b/drivers/gpu/drm/drm_probe_helper.c > index f97fda3b1d34..a7b4590d8ec1 100644 > --- a/drivers/gpu/drm/drm_probe_helper.c > +++ b/drivers/gpu/drm/drm_probe_helper.c > @@ -251,6 +251,12 @@ void drm_kms_helper_poll_enable(struct drm_device *dev) > > drm_connector_list_iter_begin(dev, &conn_iter); > drm_for_each_connector_iter(connector, &conn_iter) { > + const struct drm_connector_helper_funcs *funcs = > + connector->helper_private; > + > + if (funcs && funcs->enable_hpd) > + funcs->enable_hpd(connector); > + > if (connector->polled & (DRM_CONNECTOR_POLL_CONNECT | > DRM_CONNECTOR_POLL_DISCONNECT)) > poll = true; > @@ -805,12 +811,25 @@ EXPORT_SYMBOL(drm_kms_helper_is_poll_worker); > > static void drm_kms_helper_poll_disable_fini(struct drm_device *dev, bool fini) > { > + struct drm_connector *connector; > + struct drm_connector_list_iter conn_iter; > + > if (!dev->mode_config.poll_enabled) > return; > > if (fini) > dev->mode_config.poll_enabled = false; > > + drm_connector_list_iter_begin(dev, &conn_iter); > + drm_for_each_connector_iter(connector, &conn_iter) { > + const struct drm_connector_helper_funcs *funcs = > + connector->helper_private; > + > + if (funcs && funcs->disable_hpd) > + funcs->disable_hpd(connector); > + } > + drm_connector_list_iter_end(&conn_iter); > + > cancel_delayed_work_sync(&dev->mode_config.output_poll_work); > } > > diff --git a/include/drm/drm_modeset_helper_vtables.h b/include/drm/drm_modeset_helper_vtables.h > index fafa70ac1337..7aa1f01223f9 100644 > --- a/include/drm/drm_modeset_helper_vtables.h > +++ b/include/drm/drm_modeset_helper_vtables.h > @@ -1143,6 +1143,28 @@ struct drm_connector_helper_funcs { > */ > void (*cleanup_writeback_job)(struct drm_writeback_connector *connector, > struct drm_writeback_job *job); > + > + /** > + * @enable_hpd: > + * > + * Enable hot-plug detection for the connector. > + * > + * This operation is optional. > + * > + * This callback is used by the drm_kms_helper_poll_enable() helpers. > + */ > + void (*enable_hpd)(struct drm_connector *connector); > + > + /** > + * @disable_hpd: > + * > + * Disable hot-plug detection for the connector. > + * > + * This operation is optional. > + * > + * This callback is used by the drm_kms_helper_poll_disable() helpers. > + */ > + void (*disable_hpd)(struct drm_connector *connector); > }; > > /** _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel