From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "oohall@gmail.com" <oohall@gmail.com>
Cc: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH v3 1/6] libndctl: Use the supported_alignment attribute
Date: Mon, 28 Jan 2019 23:15:28 +0000 [thread overview]
Message-ID: <3ee5757d6730c601aae7a9c69ef3d0c8297c96a8.camel@intel.com> (raw)
In-Reply-To: <CAOSf1CHjGmOt31_wXbabEE=Qjcc11iuK=2VsM1HzVBaDmFwCOg@mail.gmail.com>
On Tue, 2019-01-29 at 10:11 +1100, Oliver wrote:
> On Thu, Jan 24, 2019 at 6:32 AM Verma, Vishal L
> <vishal.l.verma@intel.com> wrote:
> >
> > On Wed, 2019-01-16 at 20:49 +1100, Oliver O'Halloran wrote:
> > > Newer kernels provide the "supported_alignments" sysfs attribute that
> > > indicates what alignments can be used with a PFN or DAX namespace. This
> > > patch adds the plumbing inside of libndctl to allow users to query this
> > > information through using:
> > > ndctl_{dax|pfn}_get_supported_alignment(), and
> > > ndctl_{dax|pfn}_get_num_alignments()
> > >
> > > Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
> > > ---
> > > v3: Changed the return type of the *_get_supported_alignment() functions
> > > to unsigned long to match the existing *_get_alignment() functions.
> > > ---
> > > ndctl/lib/libndctl.c | 40 ++++++++++++++++++++++++++++++++++++++++
> > > ndctl/lib/libndctl.sym | 7 +++++++
> > > ndctl/libndctl.h | 6 ++++++
> > > 3 files changed, 53 insertions(+)
> >
> > Hi Oliver,
> >
> > Thanks for resubmitting this series. I had a few comments below:
>
> Hi Vishal,
>
> Sorry about the late response. I've been out of the office for the last week.
No worries. Also if you wouldn't mind, rebasing to the latest pending
branch on github would be helpful.
Thanks!
-Vishal
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2019-01-28 23:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 9:49 [PATCH v3 1/6] libndctl: Use the supported_alignment attribute Oliver O'Halloran
2019-01-16 9:49 ` [PATCH v3 2/6] ndctl/namespace: Check for seed namespaces earlier Oliver O'Halloran
2019-01-16 9:49 ` [PATCH v3 3/6] ndctl/namespace: Use seed alignment as the default Oliver O'Halloran
2019-01-16 9:49 ` [PATCH v3 4/6] ndctl/namespace: Validate alignment from the {pfn|dax} seed Oliver O'Halloran
2019-01-16 9:49 ` [PATCH v3 5/6] ndctl: Add alignment to the namespace JSON output Oliver O'Halloran
2019-01-16 9:49 ` [PATCH v3 6/6] ndctl: Add supported_alignments to the " Oliver O'Halloran
2019-01-29 14:40 ` Oliver
2019-01-29 19:28 ` Verma, Vishal L
2019-01-29 19:43 ` Dan Williams
2019-01-23 19:32 ` [PATCH v3 1/6] libndctl: Use the supported_alignment attribute Verma, Vishal L
2019-01-28 23:11 ` Oliver
2019-01-28 23:15 ` Verma, Vishal L [this message]
2019-01-28 23:20 ` Oliver
2019-01-28 23:22 ` Verma, Vishal L
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ee5757d6730c601aae7a9c69ef3d0c8297c96a8.camel@intel.com \
--to=vishal.l.verma@intel.com \
--cc=linux-nvdimm@lists.01.org \
--cc=oohall@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.