From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 773FFC41604 for ; Wed, 7 Oct 2020 15:04:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 25B5220797 for ; Wed, 7 Oct 2020 15:04:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728310AbgJGPEF (ORCPT ); Wed, 7 Oct 2020 11:04:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728271AbgJGPEF (ORCPT ); Wed, 7 Oct 2020 11:04:05 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65D82C061755 for ; Wed, 7 Oct 2020 08:04:05 -0700 (PDT) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1kQAyT-000yll-Ph; Wed, 07 Oct 2020 17:03:32 +0200 Message-ID: <3f0aab8f38971360240e1e04bd6b90a8dcadec86.camel@sipsolutions.net> Subject: Re: [RFC v7 18/21] um: host: add utilities functions From: Johannes Berg To: Anton Ivanov , Hajime Tazaki , linux-um@lists.infradead.org, jdike@addtoit.com, richard@nod.at Cc: tavi.purdila@gmail.com, linux-kernel-library@freelists.org, linux-arch@vger.kernel.org, retrage01@gmail.com Date: Wed, 07 Oct 2020 17:03:24 +0200 In-Reply-To: <6d8dd929722e419894824a07792ac8c5b2659de9.camel@sipsolutions.net> References: <7a39c85a38658227d3daf6443babb7733d1a1ff4.1601960644.git.thehajime@gmail.com> <27868819-fbd7-9eec-0520-d2fb9b6bf4a6@cambridgegreys.com> <6d8dd929722e419894824a07792ac8c5b2659de9.camel@sipsolutions.net> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On Wed, 2020-10-07 at 17:02 +0200, Johannes Berg wrote: > On Wed, 2020-10-07 at 15:53 +0100, Anton Ivanov wrote: > > These are actually different on different architectures. These look > > like the x86 values. > > > > IMHO a kernel strerror() would be the right way of dealing with this > > in the long term (i understand that we cannot call the platform one, > > because it may be different from the internal Linux errors). It will > > be useful in a lot of other places. > > > > If we leave it as is, we need to make this arch specific at some > > point. > > > > > + > > > +static const char * const lkl_err_strings[] = { > > > + "Success", > > > + "Operation not permitted", > > Might be possible to more or less address this (except for arch-specific > errors that don't always exist) but using C99 initializers? > > [0] = "Success", > [EPERM] = "Operation not permitted", > .. But, on the other hand, is it needed at all? I don't think the kernel ever prints out the actual string ... johannes From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from s3.sipsolutions.net ([2a01:4f8:191:4433::2] helo=sipsolutions.net) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQAz2-0001DO-MR for linux-um@lists.infradead.org; Wed, 07 Oct 2020 15:04:01 +0000 Message-ID: <3f0aab8f38971360240e1e04bd6b90a8dcadec86.camel@sipsolutions.net> Subject: Re: [RFC v7 18/21] um: host: add utilities functions From: Johannes Berg Date: Wed, 07 Oct 2020 17:03:24 +0200 In-Reply-To: <6d8dd929722e419894824a07792ac8c5b2659de9.camel@sipsolutions.net> References: <7a39c85a38658227d3daf6443babb7733d1a1ff4.1601960644.git.thehajime@gmail.com> <27868819-fbd7-9eec-0520-d2fb9b6bf4a6@cambridgegreys.com> <6d8dd929722e419894824a07792ac8c5b2659de9.camel@sipsolutions.net> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Anton Ivanov , Hajime Tazaki , linux-um@lists.infradead.org, jdike@addtoit.com, richard@nod.at Cc: tavi.purdila@gmail.com, linux-kernel-library@freelists.org, retrage01@gmail.com, linux-arch@vger.kernel.org On Wed, 2020-10-07 at 17:02 +0200, Johannes Berg wrote: > On Wed, 2020-10-07 at 15:53 +0100, Anton Ivanov wrote: > > These are actually different on different architectures. These look > > like the x86 values. > > > > IMHO a kernel strerror() would be the right way of dealing with this > > in the long term (i understand that we cannot call the platform one, > > because it may be different from the internal Linux errors). It will > > be useful in a lot of other places. > > > > If we leave it as is, we need to make this arch specific at some > > point. > > > > > + > > > +static const char * const lkl_err_strings[] = { > > > + "Success", > > > + "Operation not permitted", > > Might be possible to more or less address this (except for arch-specific > errors that don't always exist) but using C99 initializers? > > [0] = "Success", > [EPERM] = "Operation not permitted", > .. But, on the other hand, is it needed at all? I don't think the kernel ever prints out the actual string ... johannes _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um