All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 1/2] Adding the ofono_sim_initialized_notify function after ofono_sim_inserted_notify, as suggested by Denis Kenzior in this commit : 54d56d763e40bc44c99a9b24aa0477bd373ea085
Date: Wed, 23 May 2018 09:44:55 -0500	[thread overview]
Message-ID: <3f11e274-de3d-4c68-dc8c-548fa5750a40@gmail.com> (raw)
In-Reply-To: <1526994511-302-2-git-send-email-florent.beillonnet@ext.actia.fr>

[-- Attachment #1: Type: text/plain, Size: 765 bytes --]

Hi Florent,

On 05/22/2018 08:08 AM, Florent Beillonnet wrote:
> ---
>   plugins/gemalto.c | 2 ++
>   1 file changed, 2 insertions(+)

You really shouldn't need to do this given that you have a URC inside 
gemalto_ciev_notify() that does exactly this already.

No, I think there's a tiny bug in the core introduced by the commit you 
reference above.  Try this change?

@@ -847,7 +847,7 @@ static void sim_enter_pin_cb(const struct 
ofono_error *error, void *data)

         __ofono_dbus_pending_reply(&sim->pending, reply);

-       if (sim->initialized)
+       if (sim->initialized || error->type != OFONO_ERROR_TYPE_NO_ERROR)
                 goto recheck;

         if (sim->pin_type == OFONO_SIM_PASSWORD_SIM_PIN ||

Regards,
-Denis

  reply	other threads:[~2018-05-23 14:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-22 13:08 [PATCH 0/2] *** code puk fix *** Florent Beillonnet
2018-05-22 13:08 ` [PATCH 1/2] Adding the ofono_sim_initialized_notify function after ofono_sim_inserted_notify, as suggested by Denis Kenzior in this commit : 54d56d763e40bc44c99a9b24aa0477bd373ea085 Florent Beillonnet
2018-05-23 14:44   ` Denis Kenzior [this message]
2018-05-25  9:15     ` Florent Beillonnet
2018-05-22 13:08 ` [PATCH 2/2] Rework at_pin_send_puk It seems that the function at_pin_send_puk should have been changed along with at_pin_send, because it's also refering to the at_pin_send_cb callback See this commit : ba9f126716db3ae0bf6a3139088d9657cfb8b851 Florent Beillonnet
2018-05-23 14:05   ` Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3f11e274-de3d-4c68-dc8c-548fa5750a40@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.