From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751645AbdDBOfA (ORCPT ); Sun, 2 Apr 2017 10:35:00 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:40044 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751460AbdDBOe6 (ORCPT ); Sun, 2 Apr 2017 10:34:58 -0400 Subject: Re: [RFC PATCH v2 4/4] ARM: sun8i: h3: add support for the thermal sensor in H3 To: icenowy@aosc.io, Lee Jones , Maxime Ripard , Chen-Yu Tsai , Jonathan Cameron , Zhang Rui References: <20170402133304.56824-1-icenowy@aosc.io> <20170402133304.56824-5-icenowy@aosc.io> Cc: devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-sunxi@googlegroups.com From: Quentin Schulz Message-ID: <3f13c07d-be6a-0350-6d86-de1a4d4e33a8@free-electrons.com> Date: Sun, 2 Apr 2017 16:34:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170402133304.56824-5-icenowy@aosc.io> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Icenowy, On 02/04/2017 15:33, Icenowy Zheng wrote: > As we have gained the support for the thermal sensor in H3, we can now > add its device nodes to the device tree. > > Add them to the H3 device tree. > > The H5 thermal sensor has some differences, and will be added furtherly. > > Signed-off-by: Icenowy Zheng > --- > arch/arm/boot/dts/sun8i-h3.dtsi | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi > index b36f9f423c39..552217bb9266 100644 > --- a/arch/arm/boot/dts/sun8i-h3.dtsi > +++ b/arch/arm/boot/dts/sun8i-h3.dtsi > @@ -72,6 +72,32 @@ > }; > }; > > + iio-hwmon { > + compatible = "iio-hwmon"; > + io-channels = <&ths>; > + }; > + > + soc { > + ths: ths@01c25000 { > + compatible = "allwinner,sun8i-h3-ths"; > + reg = <0x01c25000 0x100>; > + clocks = <&ccu CLK_BUS_THS>, <&ccu CLK_THS>; > + clock-names = "bus", "ths"; > + resets = <&ccu RST_BUS_THS>; > + #thermal-sensor-cells = <0>; > + #io-channel-cells = <0>; > + }; > + }; > + > + thermal-zones { > + cpu_thermal { > + /* milliseconds */ > + polling-delay-passive = <250>; > + polling-delay = <1000>; > + thermal-sensors = <&ths>; > + }; Would it make sense to add the CPU temp trip points in this patch? Or do we wait to have CPU OPPs and thermal throttling to add them? I guess you can find them either in the datasheet or in vendor tree. Thanks, Quentin -- Quentin Schulz, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: quentin.schulz@free-electrons.com (Quentin Schulz) Date: Sun, 2 Apr 2017 16:34:55 +0200 Subject: [RFC PATCH v2 4/4] ARM: sun8i: h3: add support for the thermal sensor in H3 In-Reply-To: <20170402133304.56824-5-icenowy@aosc.io> References: <20170402133304.56824-1-icenowy@aosc.io> <20170402133304.56824-5-icenowy@aosc.io> Message-ID: <3f13c07d-be6a-0350-6d86-de1a4d4e33a8@free-electrons.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Icenowy, On 02/04/2017 15:33, Icenowy Zheng wrote: > As we have gained the support for the thermal sensor in H3, we can now > add its device nodes to the device tree. > > Add them to the H3 device tree. > > The H5 thermal sensor has some differences, and will be added furtherly. > > Signed-off-by: Icenowy Zheng > --- > arch/arm/boot/dts/sun8i-h3.dtsi | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi > index b36f9f423c39..552217bb9266 100644 > --- a/arch/arm/boot/dts/sun8i-h3.dtsi > +++ b/arch/arm/boot/dts/sun8i-h3.dtsi > @@ -72,6 +72,32 @@ > }; > }; > > + iio-hwmon { > + compatible = "iio-hwmon"; > + io-channels = <&ths>; > + }; > + > + soc { > + ths: ths at 01c25000 { > + compatible = "allwinner,sun8i-h3-ths"; > + reg = <0x01c25000 0x100>; > + clocks = <&ccu CLK_BUS_THS>, <&ccu CLK_THS>; > + clock-names = "bus", "ths"; > + resets = <&ccu RST_BUS_THS>; > + #thermal-sensor-cells = <0>; > + #io-channel-cells = <0>; > + }; > + }; > + > + thermal-zones { > + cpu_thermal { > + /* milliseconds */ > + polling-delay-passive = <250>; > + polling-delay = <1000>; > + thermal-sensors = <&ths>; > + }; Would it make sense to add the CPU temp trip points in this patch? Or do we wait to have CPU OPPs and thermal throttling to add them? I guess you can find them either in the datasheet or in vendor tree. Thanks, Quentin -- Quentin Schulz, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com