From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234034AbiEZOWR (ORCPT ); Thu, 26 May 2022 10:22:17 -0400 Received: from smtp.smtpout.orange.fr (smtp07.smtpout.orange.fr [80.12.242.129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82B87C5DB3 for ; Thu, 26 May 2022 07:22:15 -0700 (PDT) Message-ID: <3f1bb327-1af8-232d-7f85-b908c72c89d9@wanadoo.fr> Date: Thu, 26 May 2022 16:22:13 +0200 MIME-Version: 1.0 Subject: Re: [RFC PATCH] check_freeing_devm: Also track erroneous usage of kfree when the pointer has been re-assigned Content-Language: fr References: <6e88b795e1283cc306f9d009dcec70ff162943e8.1653548169.git.christophe.jaillet@wanadoo.fr> <20220526095154.GD2146@kadam> <58ca2e95-4086-96f4-7c50-8206212b144b@wanadoo.fr> <20220526110702.GD2168@kadam> <20220526120016.GE2168@kadam> <20220526134923.GG2168@kadam> From: Christophe JAILLET In-Reply-To: <20220526134923.GG2168@kadam> Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: 8bit List-ID: To: Dan Carpenter Cc: smatch@vger.kernel.org Le 26/05/2022 à 15:49, Dan Carpenter a écrit : > On Thu, May 26, 2022 at 03:37:58PM +0200, Christophe JAILLET wrote: >> Le 26/05/2022 à 14:00, Dan Carpenter a écrit : >>> On Thu, May 26, 2022 at 01:40:51PM +0200, Marion & Christophe JAILLET wrote: >>>> Le 26/05/2022 à 13:07, Dan Carpenter a écrit : >>>>> On Thu, May 26, 2022 at 12:30:05PM +0200, Christophe JAILLET wrote: >>>>>> Le 26/05/2022 à 11:51, Dan Carpenter a écrit : >>>>>>>> All I know is that it seams to work for me, even if it has not detected any >>>>>>>> issue yet :) (compiling takes SO MUCH time on my machine) >>>>>>> Yeah. :/ How big is your smatch_db.sqlite file? >>>>>> I don't use any up-to-now. >>>>> Basically all my changes are targetted at making the smatch_db.sqlite >>>>> file smaller so they won't help you. Are you at least doing a parallel >>>>> build? The smatch_scripts/test_kernel.sh script does a make -j${NR_CPU}. >>>> Yep. >>>> >>>> I've also tweaked smatch_scripts/kchecker which doesn't have any -j, IIUC. >>> Normally, I only use kchecker on one file... The problem with doing >>> parallel builds is that you have to print the warnings to a file instead >>> of to stdout. >> smatch.txt: >> >> You can also build a directory like this: >> >>     ~/progs/smatch/devel/smatch_scripts/kchecker drivers/whatever/ >> >> and up no now, it is mostly the wayIi use it, :) >> > I guess -j has no downside if you're building a single file. > > The only problem is that if you're building a directory and sending > everything to stdout then the lines can get smooshed together. Is it > better to just let them smoosh or build the whole directory and then > find -name \*.c.smatch -exec cat \{\} \;? Not sure to follow you. I've not seen any problem yet with using:    ../git_smatch/smatch_scripts/kchecker drivers/net/ > results.txt CJ > > regards, > dan carpenter >