From: Heiner Kallweit <hkallweit1@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Jean Delvare <jdelvare@suse.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH v2 1/9] i2c: i801: Improve disabling runtime pm
Date: Wed, 11 Aug 2021 22:03:12 +0200 [thread overview]
Message-ID: <3f225422-b343-eaef-0a95-9d15a5a378f2@gmail.com> (raw)
In-Reply-To: <YRPvtPid3EeMylSr@smile.fi.intel.com>
On 11.08.2021 17:41, Andy Shevchenko wrote:
> On Fri, Aug 06, 2021 at 11:12:18PM +0200, Heiner Kallweit wrote:
>> Setting the autosuspend delay to a negative value disables runtime pm in
>> a little bit smarter way, because we need no cleanup when removing the
>> driver. Note that this is safe when reloading the driver, because the
>> call to pm_runtime_set_autosuspend_delay() in probe() will reverse the
>> effect. See update_autosuspend() for details.
>
> ...
>
>> * BIOS is accessing the host controller so prevent it from
>> * suspending automatically from now on.
>> */
>> - pm_runtime_get_sync(&pdev->dev);
>> + pm_runtime_set_autosuspend_delay(&pdev->dev, -1);
>
> I dunno if it's being discussed, but with this you effectively allow user to
> override the setting. It may screw things up AFAIU the comment above.
>
No, this hasn't been discussed. At least not now. Thanks for the hint.
This attribute is writable for the root user, so we could argue that
the root user has several options to break the system anyway.
next prev parent reply other threads:[~2021-08-11 21:05 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 21:10 [PATCH v2 0/9] i2c: i801: Series with improvements Heiner Kallweit
2021-08-06 21:12 ` [PATCH v2 1/9] i2c: i801: Improve disabling runtime pm Heiner Kallweit
2021-08-10 20:37 ` Wolfram Sang
2021-08-11 15:41 ` Andy Shevchenko
2021-08-11 20:03 ` Heiner Kallweit [this message]
2021-08-12 9:48 ` Andy Shevchenko
2021-08-17 20:15 ` Wolfram Sang
2021-08-26 14:00 ` Jean Delvare
2021-08-26 14:34 ` Andy Shevchenko
2021-08-31 6:05 ` Heiner Kallweit
2021-08-31 11:26 ` Jean Delvare
2021-08-31 20:43 ` Heiner Kallweit
2021-09-01 6:22 ` Heiner Kallweit
2021-08-06 21:13 ` [PATCH v2 2/9] i2c: i801: make p2sb_spinlock a mutex Heiner Kallweit
2021-08-10 20:38 ` Wolfram Sang
2021-08-11 15:43 ` Andy Shevchenko
2021-08-11 20:27 ` Heiner Kallweit
2021-08-12 9:53 ` Andy Shevchenko
2021-08-06 21:14 ` [PATCH v2 3/9] i2c: i801: Remove not needed debug message Heiner Kallweit
2021-08-10 20:39 ` Wolfram Sang
2021-08-06 21:15 ` [PATCH v2 4/9] i2c: i801: Improve is_dell_system_with_lis3lv02d Heiner Kallweit
2021-08-11 15:45 ` Andy Shevchenko
2021-08-11 20:28 ` Heiner Kallweit
2021-08-12 9:55 ` Andy Shevchenko
2021-08-26 14:19 ` Jean Delvare
2021-08-26 13:21 ` Jean Delvare
2021-09-29 19:38 ` Wolfram Sang
2021-08-06 21:15 ` [PATCH v2 5/9] i2c: i801: Remove not needed check for PCI_COMMAND_INTX_DISABLE Heiner Kallweit
2021-08-11 15:46 ` Andy Shevchenko
2021-08-26 15:18 ` Jean Delvare
2021-09-29 19:38 ` Wolfram Sang
2021-08-06 21:16 ` [PATCH v2 6/9] i2c: i801: Improve i801_acpi_probe/remove functions Heiner Kallweit
2021-09-29 19:38 ` Wolfram Sang
2021-08-06 21:17 ` [PATCH v2 7/9] i2c: i801: Improve i801_add_mux Heiner Kallweit
2021-09-29 19:38 ` Wolfram Sang
2021-08-06 21:18 ` [PATCH v2 8/9] i2c: i801: Improve register_dell_lis3lv02d_i2c_device Heiner Kallweit
2021-08-11 15:52 ` Andy Shevchenko
2021-08-11 21:05 ` Heiner Kallweit
2021-08-12 9:57 ` Andy Shevchenko
2021-08-27 16:21 ` Jean Delvare
2021-09-29 20:11 ` Wolfram Sang
2021-10-01 11:46 ` Jean Delvare
2021-08-06 21:18 ` [PATCH v2 9/9] i2c: i801: Improve handling platform data for tco device Heiner Kallweit
2021-08-11 15:53 ` Andy Shevchenko
2021-10-02 7:44 ` Wolfram Sang
2021-11-29 8:58 ` Wolfram Sang
2021-11-29 19:54 ` Heiner Kallweit
2021-11-29 19:53 ` [PATCH v3] " Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f225422-b343-eaef-0a95-9d15a5a378f2@gmail.com \
--to=hkallweit1@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=jdelvare@suse.com \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.