From: Martin Wilck <mwilck@suse.com>
To: Benjamin Marzinski <bmarzins@redhat.com>
Cc: dm-devel@redhat.com
Subject: Re: [PATCH v2 76/80] libmultipath: select_action(): force udev reload for uninitialized maps
Date: Tue, 18 Aug 2020 09:37:00 +0200 [thread overview]
Message-ID: <3f3a9bf677107e868f8935db7e82fc39b916a272.camel@suse.com> (raw)
In-Reply-To: <20200817213105.GH19233@octiron.msp.redhat.com>
On Mon, 2020-08-17 at 16:31 -0500, Benjamin Marzinski wrote:
> On Wed, Aug 12, 2020 at 01:35:40PM +0200, mwilck@suse.com wrote:
> > From: Martin Wilck <mwilck@suse.com>
> >
> > If we are in the reconfigure() code path, and we encounter maps to
> > be reloaded, we usually set the DM_SUBSYSTEM_UDEV_FLAG0 flag to
> > tell
> > udev not to repeat device detection steps above the multipath
> > layer.
> > However, if the map was previously uninitialized, we have to force
> > udev to reload.
>
> Actually, this patch looks all broken now. select_reload_action()
> doesn't have a cmpp argument, but still has
>
> mpp_ud = get_udev_for_mpp(cmpp);
>
> Also, it's setting the action on cmpp from select_action, not mpp.
> I'm
> pretty sure that the next patch makes everything work o.k. again.
Right. Thank you for reviewing and spotting it, and apologies for the
mistake.
Martin
next prev parent reply other threads:[~2020-08-18 7:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-12 11:35 [PATCH v2 00/80] multipath-tools series part VI: incomplete udev initialization mwilck
2020-08-12 11:35 ` [PATCH v2 76/80] libmultipath: select_action(): force udev reload for uninitialized maps mwilck
2020-08-17 21:31 ` Benjamin Marzinski
2020-08-18 7:37 ` Martin Wilck [this message]
2020-08-12 11:35 ` [PATCH v2 77/80] libmultipath: log dm_task_run() errors mwilck
2020-08-17 21:33 ` Benjamin Marzinski
2020-08-12 11:35 ` [PATCH v2 79/80] multipathd: rename update_path_groups() -> reload_and_sync_map() mwilck
2020-08-12 11:35 ` [PATCH v2 80/80] libmultipath: select_action(): don't drop map if alias clashes mwilck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f3a9bf677107e868f8935db7e82fc39b916a272.camel@suse.com \
--to=mwilck@suse.com \
--cc=bmarzins@redhat.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.