From: Felix Fietkau <nbd@nbd.name>
To: Stanislaw Gruszka <sgruszka@redhat.com>, linux-wireless@vger.kernel.org
Cc: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
Xose Vazquez Perez <xose.vazquez@gmail.com>
Subject: Re: [PATCH] mt76x02u: check chip version on probe
Date: Thu, 7 Mar 2019 13:09:32 +0100 [thread overview]
Message-ID: <3f40e7c5-3451-9461-5711-30498952ddb5@nbd.name> (raw)
In-Reply-To: <1551954316-18985-1-git-send-email-sgruszka@redhat.com>
On 2019-03-07 11:25, Stanislaw Gruszka wrote:
> Since some USB device IDs are duplicated between mt76x0u, mt7601u
> and mt76x2u device, check chip version on probe and return error if
> not match the driver.
>
> Don't think this is serious issue, probe most likely will fail at
> some other point for wrong device, but we do not have to configure
> it if we know is not our device.
>
> Reported-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
You should probably return -ENODEV instead.
If there are multiple matching drivers and the wrong one probes first,
it will print a kernel warning.
- Felix
prev parent reply other threads:[~2019-03-07 12:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 10:25 [PATCH] mt76x02u: check chip version on probe Stanislaw Gruszka
2019-03-07 12:09 ` Felix Fietkau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f40e7c5-3451-9461-5711-30498952ddb5@nbd.name \
--to=nbd@nbd.name \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=sgruszka@redhat.com \
--cc=xose.vazquez@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.