From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FE4EC433B4 for ; Wed, 21 Apr 2021 14:03:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4EE916144D for ; Wed, 21 Apr 2021 14:03:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243201AbhDUODw (ORCPT ); Wed, 21 Apr 2021 10:03:52 -0400 Received: from linux.microsoft.com ([13.77.154.182]:36468 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243185AbhDUODp (ORCPT ); Wed, 21 Apr 2021 10:03:45 -0400 Received: from [192.168.86.30] (c-73-38-52-84.hsd1.vt.comcast.net [73.38.52.84]) by linux.microsoft.com (Postfix) with ESMTPSA id 5904820B8001; Wed, 21 Apr 2021 07:03:09 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 5904820B8001 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1619013792; bh=KD/DUiMPEiLQj+0ajVc+9N7DwqSG/RI78g2xsXCrEoU=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=P9THrmyXwBQGjg5NjlXt/p+rL5Xfnl3W0WI9fTmUeKvNOA+H2lMWhruR4hdRgjjn3 /iHidBD/t/54/PjtxiK75Bq3aF3V0RBIeDhoSUWq0oeuk/sQsbe8RKN94CQItbPbbX vV9hZEXsichv5WootFQ555l6gIrTOZeWX7F7gq9M= Subject: Re: [PATCH v2 5/7] KVM: SVM: hyper-v: Remote TLB flush for SVM To: Vitaly Kuznetsov Cc: "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "K. Y. Srinivasan" , x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, Lan Tianyu , Michael Kelley , Paolo Bonzini , Sean Christopherson , Wanpeng Li , Jim Mattson , Joerg Roedel , Wei Liu , Stephen Hemminger , Haiyang Zhang , viremana@linux.microsoft.com References: <959f6cc899a17c709a2f5a71f6b2dc8c072ae600.1618492553.git.viremana@linux.microsoft.com> <87sg3q7g7b.fsf@vitty.brq.redhat.com> From: Vineeth Pillai Message-ID: <3f410c6a-ed30-216e-af54-33855a2963b1@linux.microsoft.com> Date: Wed, 21 Apr 2021 10:03:12 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/16/2021 1:26 PM, Vineeth Pillai wrote: > >> >>   +#if IS_ENABLED(CONFIG_HYPERV) >> +static void hv_init_vmcb(struct vmcb *vmcb) >> +{ >> +    struct hv_enlightenments *hve = &vmcb->hv_enlightenments; >> + >> +    if (npt_enabled && >> +        ms_hyperv.nested_features & HV_X64_NESTED_ENLIGHTENED_TLB) >> Nitpick: we can probably have a 'static inline' for >> >>   "npt_enabled && ms_hyperv.nested_features & >> HV_X64_NESTED_ENLIGHTENED_TLB" >> >> e.g. 'hv_svm_enlightened_tlbflush()' > Makes sense, will do. On a second thought, this function itself is small and just does this one check. So, might not make sense to add one more function. I shall rather change this function to be an inline. Thanks, Vineeth