All of lore.kernel.org
 help / color / mirror / Atom feed
From: moyufeng <moyufeng@huawei.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>,
	<shenjian15@huawei.com>, <lipeng321@huawei.com>,
	<yisen.zhuang@huawei.com>, <linyunsheng@huawei.com>,
	<huangguangbin2@huawei.com>, <chenhao288@hisilicon.com>,
	<salil.mehta@huawei.com>, <linuxarm@huawei.com>,
	<linuxarm@openeuler.org>, <dledford@redhat.com>, <jgg@ziepe.ca>,
	<netanel@amazon.com>, <akiyano@amazon.com>,
	<thomas.lendacky@amd.com>, <irusskikh@marvell.com>,
	<michael.chan@broadcom.com>, <edwin.peer@broadcom.com>,
	<rohitm@chelsio.com>, <jacob.e.keller@intel.com>,
	<ioana.ciornei@nxp.com>, <vladimir.oltean@nxp.com>,
	<sgoutham@marvell.com>, <sbhatta@marvell.com>,
	<saeedm@nvidia.com>, <ecree.xilinx@gmail.com>,
	<grygorii.strashko@ti.com>, <merez@codeaurora.org>,
	<kvalo@codeaurora.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH net-next 2/4] ethtool: extend coalesce setting uAPI with CQE mode
Date: Wed, 18 Aug 2021 09:58:51 +0800	[thread overview]
Message-ID: <3f45d740-a732-7f18-92ef-2cea8cf2b84c@huawei.com> (raw)
In-Reply-To: <20210817064003.00733801@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>



On 2021/8/17 21:40, Jakub Kicinski wrote:
> On Tue, 17 Aug 2021 10:36:05 +0800 Yufeng Mo wrote:
>>  include/linux/ethtool.h                            | 16 ++++++++++--
>>  net/ethtool/coalesce.c                             | 29 ++++++++++++++++++----
>>  net/ethtool/ioctl.c                                | 15 ++++++++---
>>  net/ethtool/netlink.h                              |  2 +-
> 
> I'd move changes to these files to the first patch, otherwise 
> they're hard to find in all the driver modifications.
> .
> 
ok, thanks.

  reply	other threads:[~2021-08-18  1:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-17  2:36 [PATCH net-next 0/4] ethtool: extend coalesce uAPI Yufeng Mo
2021-08-17  2:36 ` [PATCH net-next 1/4] ethtool: add two coalesce attributes for CQE mode Yufeng Mo
2021-08-17  2:36 ` [PATCH net-next 2/4] ethtool: extend coalesce setting uAPI with " Yufeng Mo
2021-08-17 13:39   ` Jakub Kicinski
2021-08-18  1:57     ` moyufeng
2021-08-17 13:40   ` Jakub Kicinski
2021-08-18  1:58     ` moyufeng [this message]
2021-08-17  2:36 ` [PATCH net-next 3/4] net: hns3: add support for EQE/CQE mode configuration Yufeng Mo
2021-08-17  2:36 ` [PATCH net-next 4/4] net: hns3: add ethtool support for CQE/EQE " Yufeng Mo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3f45d740-a732-7f18-92ef-2cea8cf2b84c@huawei.com \
    --to=moyufeng@huawei.com \
    --cc=akiyano@amazon.com \
    --cc=chenhao288@hisilicon.com \
    --cc=davem@davemloft.net \
    --cc=dledford@redhat.com \
    --cc=ecree.xilinx@gmail.com \
    --cc=edwin.peer@broadcom.com \
    --cc=grygorii.strashko@ti.com \
    --cc=huangguangbin2@huawei.com \
    --cc=ioana.ciornei@nxp.com \
    --cc=irusskikh@marvell.com \
    --cc=jacob.e.keller@intel.com \
    --cc=jgg@ziepe.ca \
    --cc=kuba@kernel.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=linuxarm@openeuler.org \
    --cc=linyunsheng@huawei.com \
    --cc=lipeng321@huawei.com \
    --cc=merez@codeaurora.org \
    --cc=michael.chan@broadcom.com \
    --cc=netanel@amazon.com \
    --cc=netdev@vger.kernel.org \
    --cc=rohitm@chelsio.com \
    --cc=saeedm@nvidia.com \
    --cc=salil.mehta@huawei.com \
    --cc=sbhatta@marvell.com \
    --cc=sgoutham@marvell.com \
    --cc=shenjian15@huawei.com \
    --cc=thomas.lendacky@amd.com \
    --cc=vladimir.oltean@nxp.com \
    --cc=yisen.zhuang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.