* [PATCH] drm/amd/display: Correct VGA handoff for DCN1 devices
@ 2018-03-15 13:47 Tom St Denis
[not found] ` <20180315134722.25718-1-tom.stdenis-5C7GfCeVMHo@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Tom St Denis @ 2018-03-15 13:47 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Tom St Denis
Partial revert of 1b0ff66bc0bf1a0559255cb7b066a65d55491974
Signed-off-by: Tom St Denis <tom.stdenis@amd.com>
---
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
index 4365906b14ee..7688ed5724b9 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
@@ -228,6 +228,9 @@ static void disable_vga(
return;
REG_WRITE(D1VGA_CONTROL, 0);
+ REG_WRITE(D2VGA_CONTROL, 0);
+ REG_WRITE(D3VGA_CONTROL, 0);
+ REG_WRITE(D4VGA_CONTROL, 0);
/* HW Engineer's Notes:
* During switch from vga->extended, if we set the VGA_TEST_ENABLE and
--
2.14.3
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/amd/display: Correct VGA handoff for DCN1 devices
[not found] ` <20180315134722.25718-1-tom.stdenis-5C7GfCeVMHo@public.gmane.org>
@ 2018-03-15 15:09 ` Harry Wentland
0 siblings, 0 replies; 2+ messages in thread
From: Harry Wentland @ 2018-03-15 15:09 UTC (permalink / raw)
To: Tom St Denis, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
On 2018-03-15 09:47 AM, Tom St Denis wrote:
> Partial revert of 1b0ff66bc0bf1a0559255cb7b066a65d55491974
>
> Signed-off-by: Tom St Denis <tom.stdenis@amd.com>
Thanks for your patch.
It seems like on some systems this is not enough as D1 is off and D2-4 are on, which would still early return from this function. I sent a patch that should resolve this in all cases.
Harry
> ---
> drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> index 4365906b14ee..7688ed5724b9 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> @@ -228,6 +228,9 @@ static void disable_vga(
> return;
>
> REG_WRITE(D1VGA_CONTROL, 0);
> + REG_WRITE(D2VGA_CONTROL, 0);
> + REG_WRITE(D3VGA_CONTROL, 0);
> + REG_WRITE(D4VGA_CONTROL, 0);
>
> /* HW Engineer's Notes:
> * During switch from vga->extended, if we set the VGA_TEST_ENABLE and
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-15 15:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-15 13:47 [PATCH] drm/amd/display: Correct VGA handoff for DCN1 devices Tom St Denis
[not found] ` <20180315134722.25718-1-tom.stdenis-5C7GfCeVMHo@public.gmane.org>
2018-03-15 15:09 ` Harry Wentland
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.