From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932840AbcJZPBM (ORCPT ); Wed, 26 Oct 2016 11:01:12 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:14383 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753284AbcJZPBJ (ORCPT ); Wed, 26 Oct 2016 11:01:09 -0400 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Wed, 26 Oct 2016 08:01:07 -0700 Subject: Re: [PATCH v9 02/12] vfio: VFIO based driver for Mediated devices To: "Tian, Kevin" , "alex.williamson@redhat.com" , "pbonzini@redhat.com" , "kraxel@redhat.com" , "cjia@nvidia.com" References: <1476739332-4911-1-git-send-email-kwankhede@nvidia.com> <1476739332-4911-3-git-send-email-kwankhede@nvidia.com> CC: "qemu-devel@nongnu.org" , "kvm@vger.kernel.org" , "Song, Jike" , "bjsdjshi@linux.vnet.ibm.com" , "linux-kernel@vger.kernel.org" X-Nvconfidentiality: public From: Kirti Wankhede Message-ID: <3f4d0fd5-89c2-d478-446c-8c21d7db51bd@nvidia.com> Date: Wed, 26 Oct 2016 20:31:02 +0530 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.24.216.210] X-ClientProxiedBy: BGMAIL103.nvidia.com (10.25.59.12) To bgmail102.nvidia.com (10.25.59.11) Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> +static void vfio_mdev_release(void *device_data) >> +{ >> + struct mdev_device *mdev = device_data; >> + struct parent_device *parent = mdev->parent; >> + >> + if (parent->ops->release) > > likely() > >> + parent->ops->release(mdev); >> + >> + module_put(THIS_MODULE); >> +} >> + Thanks for pointing that out. Fixing this in next set of patch. Kirti From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41212) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzPhZ-00016L-TU for qemu-devel@nongnu.org; Wed, 26 Oct 2016 11:01:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bzPhV-0004Nb-SS for qemu-devel@nongnu.org; Wed, 26 Oct 2016 11:01:14 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:14392) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bzPhV-0004My-Nn for qemu-devel@nongnu.org; Wed, 26 Oct 2016 11:01:09 -0400 References: <1476739332-4911-1-git-send-email-kwankhede@nvidia.com> <1476739332-4911-3-git-send-email-kwankhede@nvidia.com> From: Kirti Wankhede Message-ID: <3f4d0fd5-89c2-d478-446c-8c21d7db51bd@nvidia.com> Date: Wed, 26 Oct 2016 20:31:02 +0530 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v9 02/12] vfio: VFIO based driver for Mediated devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Tian, Kevin" , "alex.williamson@redhat.com" , "pbonzini@redhat.com" , "kraxel@redhat.com" , "cjia@nvidia.com" Cc: "qemu-devel@nongnu.org" , "kvm@vger.kernel.org" , "Song, Jike" , "bjsdjshi@linux.vnet.ibm.com" , "linux-kernel@vger.kernel.org" >> +static void vfio_mdev_release(void *device_data) >> +{ >> + struct mdev_device *mdev = device_data; >> + struct parent_device *parent = mdev->parent; >> + >> + if (parent->ops->release) > > likely() > >> + parent->ops->release(mdev); >> + >> + module_put(THIS_MODULE); >> +} >> + Thanks for pointing that out. Fixing this in next set of patch. Kirti