From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CA79C3E8C5 for ; Sat, 28 Nov 2020 01:51:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F35712224C for ; Sat, 28 Nov 2020 01:51:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726250AbgK1BuY (ORCPT ); Fri, 27 Nov 2020 20:50:24 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:8053 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730815AbgK1BqA (ORCPT ); Fri, 27 Nov 2020 20:46:00 -0500 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4CjYn11CFnzhjY5; Sat, 28 Nov 2020 09:29:09 +0800 (CST) Received: from [10.174.178.154] (10.174.178.154) by smtp.huawei.com (10.3.19.208) with Microsoft SMTP Server (TLS) id 14.3.487.0; Sat, 28 Nov 2020 09:29:27 +0800 Subject: Re: [PATCH -next] fs/ntfs: fix set but not used variable 'log_page_mask' To: CC: , References: <20200312041353.19877-1-zhengzengkai@huawei.com> From: Zheng Zengkai Message-ID: <3f52b53a-d7b4-7246-c1f6-7f57cc1c311f@huawei.com> Date: Sat, 28 Nov 2020 09:29:27 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20200312041353.19877-1-zhengzengkai@huawei.com> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.154] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ping... > Fixes gcc '-Wunused-but-set-variable' warning: > > fs/ntfs/logfile.c: In function ntfs_check_logfile: > fs/ntfs/logfile.c:481:21: > warning: variable log_page_mask set but not used [-Wunused-but-set-variable] > > Actually log_page_mask can be used to replace 'log_page_size - 1' as it is set. > > Signed-off-by: Zheng Zengkai > --- > fs/ntfs/logfile.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ntfs/logfile.c b/fs/ntfs/logfile.c > index a0c40f1be7ac..c35fcf389369 100644 > --- a/fs/ntfs/logfile.c > +++ b/fs/ntfs/logfile.c > @@ -507,7 +507,7 @@ bool ntfs_check_logfile(struct inode *log_vi, RESTART_PAGE_HEADER **rp) > * optimize log_page_size and log_page_bits into constants. > */ > log_page_bits = ntfs_ffs(log_page_size) - 1; > - size &= ~(s64)(log_page_size - 1); > + size &= ~(s64)(log_page_mask); > /* > * Ensure the log file is big enough to store at least the two restart > * pages and the minimum number of log record pages.