From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB7B3C433F5 for ; Wed, 19 Jan 2022 16:51:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243518AbiASQvm (ORCPT ); Wed, 19 Jan 2022 11:51:42 -0500 Received: from smtp-out1.suse.de ([195.135.220.28]:33810 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243495AbiASQvi (ORCPT ); Wed, 19 Jan 2022 11:51:38 -0500 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A2C3921126; Wed, 19 Jan 2022 16:51:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1642611097; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dcNkutNEUdp9tNCGv2eq1CnHkXbyaGxeNqKqSZ28AG8=; b=zVHxQO4Xv8Woim81RYvQnEF/90eYeX7QaT6p/QjrJcePnJFi85h9bqzpC3GBpn/jrixuRv gv/FEAXdlQrvDbQ8dPBcr+zYisQr6NQyczJsLshSbS0N+F0MXJbCShXTmRW61mDHzllcm2 AYb2whyA9oiJtPvrPWw01+riG1X9o9g= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1642611097; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dcNkutNEUdp9tNCGv2eq1CnHkXbyaGxeNqKqSZ28AG8=; b=4QThA5FBH2vf2Fqu5ss7T4AoRKDjRJboGbAyNcRe8QS2mLcNHt+gspF2HyI8/k6T24CEoK BkA/g76kOjZhGXCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5E8ED13B77; Wed, 19 Jan 2022 16:51:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id KoVRFplB6GHVLwAAMHmgww (envelope-from ); Wed, 19 Jan 2022 16:51:37 +0000 Message-ID: <3f565267-078e-ad4c-dfd2-36dba2201afe@suse.cz> Date: Wed, 19 Jan 2022 17:51:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v4 48/66] fork: Use VMA iterator Content-Language: en-US To: Liam Howlett , "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton Cc: Song Liu , Davidlohr Bueso , "Paul E . McKenney" , Matthew Wilcox , Laurent Dufour , David Rientjes , Axel Rasmussen , Suren Baghdasaryan , Rik van Riel , Peter Zijlstra , Michel Lespinasse , Jerome Glisse , Minchan Kim , Joel Fernandes , Rom Lemarchand References: <20211201142918.921493-1-Liam.Howlett@oracle.com> <20211201142918.921493-49-Liam.Howlett@oracle.com> From: Vlastimil Babka In-Reply-To: <20211201142918.921493-49-Liam.Howlett@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/1/21 15:30, Liam Howlett wrote: > From: "Liam R. Howlett" > > The VMA iterator is faster than the linked list and removing the linked > list will shrink the vm_area_struct. > > Signed-off-by: Matthew Wilcox (Oracle) > Signed-off-by: Liam R. Howlett Acked-by: Vlastimil Babka > --- > kernel/fork.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/kernel/fork.c b/kernel/fork.c > index 3493117c8d35..6de302e93519 100644 > --- a/kernel/fork.c > +++ b/kernel/fork.c > @@ -1228,13 +1228,16 @@ int replace_mm_exe_file(struct mm_struct *mm, struct file *new_exe_file) > /* Forbid mm->exe_file change if old file still mapped. */ > old_exe_file = get_mm_exe_file(mm); > if (old_exe_file) { > + VMA_ITERATOR(vmi, mm, 0); > mmap_read_lock(mm); > - for (vma = mm->mmap; vma && !ret; vma = vma->vm_next) { > + for_each_vma(vmi, vma) { > if (!vma->vm_file) > continue; > if (path_equal(&vma->vm_file->f_path, > - &old_exe_file->f_path)) > + &old_exe_file->f_path)) { > ret = -EBUSY; > + break; > + } > } > mmap_read_unlock(mm); > fput(old_exe_file);