From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Guo, Jia" <jia.guo@intel.com>
Subject: Re: [PATCH v4 17/17] net/i40e: flush tunnel filters
Date: Tue, 3 Jan 2017 11:25:19 +0800
Message-ID: <3f58d1aa-a688-0281-6ffe-db37124c3680@intel.com>
References: <1483027473-89042-1-git-send-email-beilei.xing@intel.com>
 <1483068352-32272-1-git-send-email-beilei.xing@intel.com>
 <1483068352-32272-18-git-send-email-beilei.xing@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Beilei Xing <beilei.xing@intel.com>, jingjing.wu@intel.com,
 helin.zhang@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id D51DF2C36
 for <dev@dpdk.org>; Tue,  3 Jan 2017 04:25:21 +0100 (CET)
In-Reply-To: <1483068352-32272-18-git-send-email-beilei.xing@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



On 12/30/2016 11:25 AM, Beilei Xing wrote:
> This patch adds i40e_tunnel_filter_flush function
> to flush all tunnel filters, including filters in
> SW and HW.
>
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> ---
>   drivers/net/i40e/i40e_flow.c | 37 +++++++++++++++++++++++++++++++++++++
>   1 file changed, 37 insertions(+)
>
> diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c
> index 5c16fb8..fd0f0ec 100644
> --- a/drivers/net/i40e/i40e_flow.c
> +++ b/drivers/net/i40e/i40e_flow.c
> @@ -105,6 +105,7 @@ static int i40e_dev_destroy_tunnel_filter(struct i40e_pf *pf,
>   					  struct i40e_tunnel_filter *filter);
>   static int i40e_fdir_filter_flush(struct i40e_pf *pf);
>   static int i40e_ethertype_filter_flush(struct i40e_pf *pf);
> +static int i40e_tunnel_filter_flush(struct i40e_pf *pf);
>   
>   const struct rte_flow_ops i40e_flow_ops = {
>   	.validate = i40e_flow_validate,
> @@ -1671,6 +1672,14 @@ i40e_flow_flush(struct rte_eth_dev *dev, struct rte_flow_error *error)
>   		return -rte_errno;
>   	}
>   
> +	ret = i40e_tunnel_filter_flush(pf);
> +	if (ret) {
> +		rte_flow_error_set(error, -ret,
> +				   RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
> +				   "Failed to flush tunnel flows.");
> +		return -rte_errno;
> +	}
> +
>   	return ret;
>   }
>   
> @@ -1733,3 +1742,31 @@ i40e_ethertype_filter_flush(struct i40e_pf *pf)
>   
>   	return ret;
>   }
> +
> +/* Flush all tunnel filters */
> +static int
> +i40e_tunnel_filter_flush(struct i40e_pf *pf)
> +{
> +	struct i40e_tunnel_filter_list
> +		*tunnel_list = &pf->tunnel.tunnel_list;
> +	struct i40e_tunnel_filter *f;
Just a mini comment, could you replace the variables name from "f" to 
any other obvious name , to let code to be more readable.
>   
> +	struct i40e_flow *flow;
> +	void *temp;
> +	int ret = 0;
> +
> +	while ((f = TAILQ_FIRST(tunnel_list))) {
> +		ret = i40e_dev_destroy_tunnel_filter(pf, f);
> +		if (ret)
> +			return ret;
> +	}
> +
> +	/* Delete tunnel flows in flow list. */
> +	TAILQ_FOREACH_SAFE(flow, &pf->flow_list, node, temp) {
> +		if (flow->filter_type == RTE_ETH_FILTER_TUNNEL) {
> +			TAILQ_REMOVE(&pf->flow_list, flow, node);
> +			rte_free(flow);
> +		}
> +	}
> +
> +	return ret;
> +}