From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E9B7C433F5 for ; Fri, 15 Oct 2021 11:10:24 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 33AE4610E8 for ; Fri, 15 Oct 2021 11:10:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 33AE4610E8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CF40841216; Fri, 15 Oct 2021 13:10:20 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id C9F7841214 for ; Fri, 15 Oct 2021 13:10:18 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10137"; a="208009278" X-IronPort-AV: E=Sophos;i="5.85,375,1624345200"; d="scan'208";a="208009278" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2021 04:10:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,375,1624345200"; d="scan'208";a="442489960" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga006.jf.intel.com with ESMTP; 15 Oct 2021 04:10:16 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 15 Oct 2021 04:10:16 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 15 Oct 2021 04:10:16 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.171) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 15 Oct 2021 04:10:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JewbKp2edG0x1zzoCKmjg+58CLBAXcfVTB4AEcRb7jnmWzSK8uwIgfivnxg5/WEV9L6qdBCcuY9GODZ4Dk7JUMTaHecDLPFSjdkerGPHIzwoPvrfRmh8sjLdMFtfo07A7s53elZoxi68dRktJmk84IzOhf0Vu/fehg+2/n4jdyzbK1b/89nOPsqzC6NC6Fe5YtQpFagteqnZYktWXpiqxq/KM+gDoE6eJkHgaYIG38Q3UIqwRUPFnSv4Soyelk/Zj8zbZ/CMtQwuaQYjMWU7ajUDDH5wvg5v6bVyV50xM7k4f3UPsjPP8XACObmHJTKDIIQ1zOakajTrRb0HFg/jdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OAcL4O62vmnNx1IOpTj6KfO9k8cTK/4RPiodIUiDMbA=; b=nG0WUe/4bkH7Q+n8HO9FLuteFl3J73dLJoMoKN7QHL641u7TgYGvKb35rw7Kfn6eDHk76GTDlGSRVPHwan+M/Y5u6zHpLDtILZEPNsQ9hT09fWJK/JkaKPUEXL6pGK4jzyvnAIRmn1det6fnzbkIEYHKt4bVKZH7OTdUQPrHaLkVpoczDN8AYq3jdvBoVnKEd9ltF4DPmmiaZ9Z/rRUU2y+BNjb+Yefqozn14/h6EIaRpt8BuhVA7RDMpbYlZ3+H0AxPUO2UWOvHIF0xNgjOJLK4O5cg+rSCztkJCrEeMpZLSDrxnUqFlfQy6lcUMC3X/oXLSlfMB4Z7DvqmZOtWwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OAcL4O62vmnNx1IOpTj6KfO9k8cTK/4RPiodIUiDMbA=; b=NCESupyhHdf8vUf788jYxMqusn7/LzV8mXGJk13WnfQgKBpjdv++p0JahNYTM3IVDPIZLKw0HW8dNTBcD5lyB0xM2tpImNLugt8qydmPHzacqb6qgit0I1y/+yQkt4f23tADWzW5lmKLjyGb2gCAx9taSP6V1d31w1Im5tIVL2g= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH7PR11MB5819.namprd11.prod.outlook.com (2603:10b6:510:13b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.20; Fri, 15 Oct 2021 11:10:15 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4608.017; Fri, 15 Oct 2021 11:10:15 +0000 Message-ID: <3f6290ed-3f0f-6833-1064-19a2ec3258b1@intel.com> Date: Fri, 15 Oct 2021 12:10:08 +0100 Content-Language: en-US To: Jie Wang , CC: , , , , , , , References: <20211012102508.275790-1-jie1x.wang@intel.com> <20211015095823.701188-1-jie1x.wang@intel.com> <20211015095823.701188-2-jie1x.wang@intel.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211015095823.701188-2-jie1x.wang@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB8PR04CA0030.eurprd04.prod.outlook.com (2603:10a6:10:110::40) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB8PR04CA0030.eurprd04.prod.outlook.com (2603:10a6:10:110::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.26 via Frontend Transport; Fri, 15 Oct 2021 11:10:12 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 921559f8-782d-4852-1b0b-08d98fcc5d23 X-MS-TrafficTypeDiagnostic: PH7PR11MB5819: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2582; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: t/Z7TKF7BguQrmi61ZckBYzcwEWL1GWAJrRSPkKuSTdGggK+K4on5lf7JPfAKOlmWp6XGhR8aAJ+Mc75Z3l+Cfu6bifzTrc9VQGamy5ojfbbYNl8LKVGpwiU5jRNxIQa/NYZN/ijJBH0WVYaXJbTf9A4oodJJQtkai/+JGBRT0futryoQFt1lKFin+tC5uX+3BOIlF6yANMQbC229c1TuAYFDT1Gv2X3CByw5BNYt5xvxiW+v6BgqIg2FLhFHstvzzXI/ZarReZFk/HqxZ7t15ROQjXXmAP9zejmK66/t3XgSs8qZE4O6Ug91uzezpwTsUH3pw0bLza71rSUdSN3wZN5gKU1QS2qa19N25huR59aP+ZNjgx01iBev0AnwjLjGwtu1CyBR9U5UMgKKLHeT3mDnhMqSYGUN1lDycFytr1yNF+3sZ5D+N9m813hCAkjnC15V2svlMlyBsdpEjXVNkTmALsOAI9Zs/CqTcBGk+9UrHQp5JJvz6AbvmdYlkBjF0LFaIXR5JTSGWrvs394RI0kdsgdHP5SKRRtUGrlmQrpz1Zqm/AtT3rmvhD/HIZkXJazycDUKU0DsjwQqJqLUICTPc3twRLUv5NRn/GT6p91c+WvYzD6b7THM1xhfsW+WDPdNDIZS5c1gLj3AQmg+cJGtCWxtj3P0Vi+Jd8SOwlnWTeySoh54+So1Y0vqregofkjx5GKU2+cdyEW/5NTog== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(8936002)(44832011)(66476007)(6486002)(4744005)(956004)(66556008)(83380400001)(16576012)(5660300002)(26005)(316002)(508600001)(6666004)(82960400001)(186003)(2616005)(66946007)(36756003)(8676002)(107886003)(53546011)(86362001)(31696002)(31686004)(38100700002)(4326008)(2906002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dTRuQUZlUmJmbGZRQzYzUGpTcmtQTFpPaVY4Mjlqd29oZWoyOGh0ZVV3RnpI?= =?utf-8?B?azJIRzdkWmlMd1krbkV6N2krdXREWC81Z0xobzRXRkdXbndzU2hJbGJQM0Y1?= =?utf-8?B?UnJ3TUdMSjdkSzFoNXBQU3lROE5HZmlIV0lvVm01WFJXbXg1QzlNS1hvWDgz?= =?utf-8?B?RDhqT0lUM3YvMjVZditTMmw4S0VXUHFWTEVQbWxIOWFDTkRRZ0lTeGZmT3hB?= =?utf-8?B?TW5sYlFic2d4ZkN4YTNSNkkwWkpHYzFSSXl3Slc1aXlyT2tMaWJNbkQzY1Bv?= =?utf-8?B?R2xYUm9LT2lHVlRUUTYwMFh3c3NpdklNWEkwczNlcytiSWxJbGNIVmtSZ25P?= =?utf-8?B?cy8vNjU1M2lRR243SmQxUzBWR3pHeWh0NU9UaFB5V2R2NG5rcHVBaWxGNjlq?= =?utf-8?B?bTN3emV6eUZvZDhPb0tIai9OUkZhZ296S3VSU1RYTnJENk14Q25OUU9iZ2Zl?= =?utf-8?B?UkhFeUtScms4eWxXemozdi9MOVBTcG1JR0g4azZ2dmVNbjFYODhPcXZjdFpJ?= =?utf-8?B?Ym9Db2syTmRUMVV2Yk1GU2NYcGMxNlN3bjR5TnR6M2VLYXgvQUM0Q3VTcjJI?= =?utf-8?B?VkJwZkV3UHlPME1JSGhWTzU1Z0xQVHI2VGkzKzc5eE1HOTBreWgyRjYzYXdX?= =?utf-8?B?dnJvVXpNZTVIMkZoN2dXQkQ3Q1p2Rklzd0pBcElaWEl4bzVRaUFUSHNEOHRU?= =?utf-8?B?NXFIZU1yQ3FsQnErM05RWlVaZHl6VXNpd1hlZkhVdGVRQU5OMTlRWExHVGY1?= =?utf-8?B?S1dXVXNYSzY1TytkbVRJTjRZL3kyWkRlYVFLUFN6d3FDdGN4bkd0MUNEVk1N?= =?utf-8?B?MGMxS2xWb21pTHdhZzhjTEVrS1F2M1l6UGdrd1RjY0Z2SHpIc3JOaFhnNXRI?= =?utf-8?B?YVIwUzJKWWFPYi8zWE5GVFhjQkRVVmFhVlBmRFMyM20rcDZsUDZrQXZYdm9u?= =?utf-8?B?a3NMU2dCT3ZNdm94SytQdi9xNVpDcThXMWRWRWgxSDdhQ0JtWFNnMU9YdERo?= =?utf-8?B?SEU5MndkTVZKbkxScDl3akc0eTdHK3NFT1U5dWdjbmdFRGlsNFUwYXB2VmRM?= =?utf-8?B?ZTIvdDRrOWJWSzhFQ1Y1dCtTOTgrZEs3eFpabGNYdStrVGcvbnFweE5iL1FX?= =?utf-8?B?TUpDMU9lZWlwc2V1d0tUd2M5MS85dExwSSt4T2V4RkdKK0w1NGcvT2FLblVU?= =?utf-8?B?blNCaVdOWGVlWUZTMjRGZldiK01BWC9iR2d6bDRzb2w0Tm1raDNxM3FtN2kw?= =?utf-8?B?NW12THkvMktRZVl1SWgrM05sTVpQTUFrN2tzZnpobk9LYXhONHhLbjdIUHFl?= =?utf-8?B?anpJcmk0amNXbkNqN1paK3lkUzhZNXBvTlVXV2hOallSMXdJMFpEakVrQzlm?= =?utf-8?B?NjU2YVRjUUVRNXhIUTZlYUZZVnBscmdGY3gyTnE0eVRxWGxWaUhYbWJ0YnVa?= =?utf-8?B?OWRUMjVxbUNieVpBN05ZRnY1eTZEZEUxUXZReVB2LzNSZmhkWUYrMVVXWHBE?= =?utf-8?B?SUU3YVV2K3VNMjVQUHROL1JIb1IyUU1wYjZxc3VhNEhnek43UnZOOWNSRm9Q?= =?utf-8?B?QnJMQXZqZHVjOE5BL05qRVhpU0dKR1dBWkxKUTBXdUNXZUNQZmpOeDd1ZUZq?= =?utf-8?B?dG9Ca0MyM1RiU3lEbXVDdGV0S0JwVzZVMG1USFh1VkowSTlNT0d5TXdtS3hm?= =?utf-8?B?THJEK3RTcWc1ajl3NXNGUGpRc29OMS9pZ2VEUkMzVjVmV1lDTzdvK0FsNkVt?= =?utf-8?Q?6zb9Q116rxibjjho4JtpZRdxHDI68L5DcJsieIa?= X-MS-Exchange-CrossTenant-Network-Message-Id: 921559f8-782d-4852-1b0b-08d98fcc5d23 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 11:10:15.1643 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ubboN3m0qYyFZ7cJXNTm57LS6YifCfvkrPtuGhYZ7OcLIkb5hn5DJcnjjAaIZLfaePcoKg/9tyxm80ewJ8sppw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5819 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 1/3] ethdev: support PPP and L2TPV2 procotol X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/15/2021 10:58 AM, Jie Wang wrote: > +/** > + * @warning > + * @b EXPERIMENTAL: this structure may change without prior notice > + * RTE_FLOW_ITEM_TYPE_PPP > + * > + * Matches PPP Header > + */ > +struct rte_flow_item_ppp { > + uint8_t addr; /**< ppp address(8) */ > + uint8_t ctrl; /**< ppp control(8) */ > + rte_be16_t proto_id; /**< ppp protocol id(16) */ > +}; Hi Jie, Can't we do same thing for ppp, have the protocol header in the lib/net and use it within the 'rte_flow_item_ppp'?