From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Daniel Wagner <dwagner@suse.de>, Keith Busch <kbusch@meta.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"hch@lst.de" <hch@lst.de>, "sagi@grimberg.me" <sagi@grimberg.me>,
Keith Busch <kbusch@kernel.org>,
Martin Belanger <Martin.Belanger@dell.com>
Subject: Re: [PATCH 3/3] blk-mq: directly poll requests
Date: Wed, 22 Mar 2023 18:16:41 +0000 [thread overview]
Message-ID: <3f670ca7-908d-db55-3da1-4090f116005d@nvidia.com> (raw)
In-Reply-To: <20230322083747.ljos4iqkklworudl@carbon.lan>
On 3/22/23 01:37, Daniel Wagner wrote:
> On Tue, Mar 21, 2023 at 05:23:50PM -0700, Keith Busch wrote:
>> From: Keith Busch <kbusch@kernel.org>
>>
>> Polling needs a bio with a valid bi_bdev, but neither of those are
>> guaranteed for polled driver requests. Make request based polling use
>> directly use blk-mq's polling function.
>>
>> When executing a request from a polled hctx, we know the request's
>> cookie, and that it's from a live multi-queue that supports polling, so
>> we can safely skip everything that bio_poll provides.
>>
>> Link: http://lists.infradead.org/pipermail/linux-nvme/2023-March/038340.html
>> Reported-by: Martin Belanger <Martin.Belanger@dell.com>
>> Reported-by: Daniel Wagner <dwagner@suse.de>
>> Signed-off-by: Keith Busch <kbusch@kernel.org>
> I've tested the whole series and this patch alone with rdma and tcp.
>
> Tested-by: Daniel Wagner <dwagner@suse.de>
> Revieded-by: Daniel Wagner <dwagner@suse.de>
Thanks Daniel, please add my tag also.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
next prev parent reply other threads:[~2023-03-22 18:16 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 0:23 [PATCH 0/3] nvme fabrics polling fixes Keith Busch
2023-03-22 0:23 ` [PATCH 1/3] nvme-fabrics: add queue setup helpers Keith Busch
2023-03-22 1:46 ` Chaitanya Kulkarni
2023-03-22 4:38 ` kernel test robot
2023-03-22 5:21 ` Chaitanya Kulkarni
2023-03-22 7:35 ` Sagi Grimberg
2023-03-22 8:27 ` Christoph Hellwig
2023-03-22 9:07 ` Sagi Grimberg
2023-03-22 9:25 ` kernel test robot
2023-03-22 0:23 ` [PATCH 2/3] nvme: add polling options for loop target Keith Busch
2023-03-22 1:47 ` Chaitanya Kulkarni
2023-03-22 7:44 ` Sagi Grimberg
2023-03-22 8:23 ` Christoph Hellwig
2023-03-22 8:46 ` Daniel Wagner
2023-03-22 13:52 ` Christoph Hellwig
2023-03-22 14:06 ` Daniel Wagner
2023-03-22 14:20 ` Christoph Hellwig
2023-03-22 14:30 ` Keith Busch
2023-03-22 0:23 ` [PATCH 3/3] blk-mq: directly poll requests Keith Busch
2023-03-22 7:36 ` Sagi Grimberg
2023-03-22 8:23 ` Christoph Hellwig
2023-03-22 9:08 ` Sagi Grimberg
2023-03-22 8:37 ` Daniel Wagner
2023-03-22 18:16 ` Chaitanya Kulkarni [this message]
2023-03-31 7:57 ` Shinichiro Kawasaki
2023-03-22 7:31 ` [PATCH 0/3] nvme fabrics polling fixes Sagi Grimberg
2023-03-22 8:48 ` Daniel Wagner
2023-03-22 13:24 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f670ca7-908d-db55-3da1-4090f116005d@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=Martin.Belanger@dell.com \
--cc=axboe@kernel.dk \
--cc=dwagner@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.