From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtps.newmedia-net.de ([185.84.6.167]:54591 "EHLO webmail.newmedia-net.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750821AbeEEJpb (ORCPT ); Sat, 5 May 2018 05:45:31 -0400 Subject: Re: [PATCH 2/2] ath10k: DFS Host Confirmation To: Kalle Valo , Peter Oh Cc: Sriram R , ath10k@lists.infradead.org, linux-wireless@vger.kernel.org References: <1525110339-25326-1-git-send-email-srirrama@codeaurora.org> <1525110339-25326-3-git-send-email-srirrama@codeaurora.org> <0c224b54-dd10-576f-944f-2d20d1cb2c46@bowerswilkins.com> <87d0ye2t75.fsf@kamboji.qca.qualcomm.com> From: Sebastian Gottschall Message-ID: <3f762586-a757-636c-2eb4-3fa3e193b3dd@dd-wrt.com> (sfid-20180505_114535_935633_BF93CE2A) Date: Sat, 5 May 2018 11:45:28 +0200 MIME-Version: 1.0 In-Reply-To: <87d0ye2t75.fsf@kamboji.qca.qualcomm.com> Content-Type: text/plain; charset=utf-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: Am 02.05.2018 um 13:27 schrieb Kalle Valo: > Peter Oh writes: > >> On 04/30/2018 10:45 AM, Sriram R wrote: >>> In the 10.4-3.6 firmware branch there's a new DFS Host confirmation >>> feature which is advertised using WMI_SERVICE_HOST_DFS_CHECK_SUPPORT flag. >>> >>> This new features enables the ath10k host to send information to the >>> firmware on the specifications of detected radar type. This allows the >>> firmware to validate if the host's radar pattern detector unit is >>> operational and check if the radar information shared by host matches >>> the radar pulses sent as phy error events from firmware. If the check >>> fails the firmware won't allow use of DFS channels on AP mode when using >>> FCC regulatory region. >> What's the main reason you introduce this feature? >> What are you trying to solve with this change? > Otherwise one cannot use DFS channels on FCC regions with a firmware > from 10.4-3.6 branch. > >>> @@ -3765,25 +3834,46 @@ static void ath10k_dfs_radar_report(struct ath10k *ar, >>> ATH10K_DFS_STAT_INC(ar, pulses_detected); >>> - if (!ar->dfs_detector->add_pulse(ar->dfs_detector, &pe, NULL)) >>> { >>> + if (!ar->dfs_detector->add_pulse(ar->dfs_detector, &pe, &rs)) { >>> ath10k_dbg(ar, ATH10K_DBG_REGULATORY, >>> "dfs no pulse pattern detected, yet\n"); >>> return; >>> } >>> -radar_detected: >>> - ath10k_dbg(ar, ATH10K_DBG_REGULATORY, "dfs radar detected\n"); >>> - ATH10K_DFS_STAT_INC(ar, radar_detected); >>> + if ((test_bit(WMI_SERVICE_HOST_DFS_CHECK_SUPPORT, ar->wmi.svc_map)) && >>> + ar->dfs_detector->region == NL80211_DFS_FCC) { >> I feel risky that host drivers have no way to control this new feature >> and totally rely on FW feature mask. We should have a host drivers' >> feature mask such as module param and set it false (don't use) by >> default until it proves safe to use. > This is for regulatory enforcement so it's not possible to disable the > feature from host. mmh from what i see it is possible to disable it from host since the firmware seem to be sensitive on the regdomain set by the host so if host sets anything else than a FCC regdomain, it will still work in the old way. so its more a pseudo enforcement. dont know if this is usefull and it also will it make impossible to fix radar detection issues for certification as mentioned by peter and adrian. Sebastian > -- Mit freundlichen Grüssen / Regards Sebastian Gottschall / CTO NewMedia-NET GmbH - DD-WRT Firmensitz: Stubenwaldallee 21a, 64625 Bensheim Registergericht: Amtsgericht Darmstadt, HRB 25473 Geschäftsführer: Peter Steinhäuser, Christian Scheele http://www.dd-wrt.com email: s.gottschall@dd-wrt.com Tel.: +496251-582650 / Fax: +496251-5826565 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtps.newmedia-net.de ([2a05:a1c0:0:de::167] helo=webmail.newmedia-net.de) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fEtlA-0006sh-60 for ath10k@lists.infradead.org; Sat, 05 May 2018 09:45:46 +0000 Subject: Re: [PATCH 2/2] ath10k: DFS Host Confirmation References: <1525110339-25326-1-git-send-email-srirrama@codeaurora.org> <1525110339-25326-3-git-send-email-srirrama@codeaurora.org> <0c224b54-dd10-576f-944f-2d20d1cb2c46@bowerswilkins.com> <87d0ye2t75.fsf@kamboji.qca.qualcomm.com> From: Sebastian Gottschall Message-ID: <3f762586-a757-636c-2eb4-3fa3e193b3dd@dd-wrt.com> Date: Sat, 5 May 2018 11:45:28 +0200 MIME-Version: 1.0 In-Reply-To: <87d0ye2t75.fsf@kamboji.qca.qualcomm.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Kalle Valo , Peter Oh Cc: linux-wireless@vger.kernel.org, Sriram R , ath10k@lists.infradead.org QW0gMDIuMDUuMjAxOCB1bSAxMzoyNyBzY2hyaWViIEthbGxlIFZhbG86Cj4gUGV0ZXIgT2ggPHBl dGVyLm9oQGJvd2Vyc3dpbGtpbnMuY29tPiB3cml0ZXM6Cj4KPj4gT24gMDQvMzAvMjAxOCAxMDo0 NSBBTSwgU3JpcmFtIFIgd3JvdGU6Cj4+PiBJbiB0aGUgMTAuNC0zLjYgZmlybXdhcmUgYnJhbmNo IHRoZXJlJ3MgYSBuZXcgREZTIEhvc3QgY29uZmlybWF0aW9uCj4+PiBmZWF0dXJlIHdoaWNoIGlz IGFkdmVydGlzZWQgdXNpbmcgV01JX1NFUlZJQ0VfSE9TVF9ERlNfQ0hFQ0tfU1VQUE9SVCBmbGFn Lgo+Pj4KPj4+IFRoaXMgbmV3IGZlYXR1cmVzIGVuYWJsZXMgdGhlIGF0aDEwayBob3N0IHRvIHNl bmQgaW5mb3JtYXRpb24gdG8gdGhlCj4+PiBmaXJtd2FyZSBvbiB0aGUgc3BlY2lmaWNhdGlvbnMg b2YgZGV0ZWN0ZWQgcmFkYXIgdHlwZS4gVGhpcyBhbGxvd3MgdGhlCj4+PiBmaXJtd2FyZSB0byB2 YWxpZGF0ZSBpZiB0aGUgaG9zdCdzIHJhZGFyIHBhdHRlcm4gZGV0ZWN0b3IgdW5pdCBpcwo+Pj4g b3BlcmF0aW9uYWwgYW5kIGNoZWNrIGlmIHRoZSByYWRhciBpbmZvcm1hdGlvbiBzaGFyZWQgYnkg aG9zdCBtYXRjaGVzCj4+PiB0aGUgcmFkYXIgcHVsc2VzIHNlbnQgYXMgcGh5IGVycm9yIGV2ZW50 cyBmcm9tIGZpcm13YXJlLiBJZiB0aGUgY2hlY2sKPj4+IGZhaWxzIHRoZSBmaXJtd2FyZSB3b24n dCBhbGxvdyB1c2Ugb2YgREZTIGNoYW5uZWxzIG9uIEFQIG1vZGUgd2hlbiB1c2luZwo+Pj4gRkND IHJlZ3VsYXRvcnkgcmVnaW9uLgo+PiBXaGF0J3MgdGhlIG1haW4gcmVhc29uIHlvdSBpbnRyb2R1 Y2UgdGhpcyBmZWF0dXJlPwo+PiBXaGF0IGFyZSB5b3UgdHJ5aW5nIHRvIHNvbHZlIHdpdGggdGhp cyBjaGFuZ2U/Cj4gT3RoZXJ3aXNlIG9uZSBjYW5ub3QgdXNlIERGUyBjaGFubmVscyBvbiBGQ0Mg cmVnaW9ucyB3aXRoIGEgZmlybXdhcmUKPiBmcm9tIDEwLjQtMy42IGJyYW5jaC4KPgo+Pj4gQEAg LTM3NjUsMjUgKzM4MzQsNDYgQEAgc3RhdGljIHZvaWQgYXRoMTBrX2Rmc19yYWRhcl9yZXBvcnQo c3RydWN0IGF0aDEwayAqYXIsCj4+PiAgICAgIAlBVEgxMEtfREZTX1NUQVRfSU5DKGFyLCBwdWxz ZXNfZGV0ZWN0ZWQpOwo+Pj4gICAgLQlpZiAoIWFyLT5kZnNfZGV0ZWN0b3ItPmFkZF9wdWxzZShh ci0+ZGZzX2RldGVjdG9yLCAmcGUsIE5VTEwpKQo+Pj4gewo+Pj4gKwlpZiAoIWFyLT5kZnNfZGV0 ZWN0b3ItPmFkZF9wdWxzZShhci0+ZGZzX2RldGVjdG9yLCAmcGUsICZycykpIHsKPj4+ICAgIAkJ YXRoMTBrX2RiZyhhciwgQVRIMTBLX0RCR19SRUdVTEFUT1JZLAo+Pj4gICAgCQkJICAgImRmcyBu byBwdWxzZSBwYXR0ZXJuIGRldGVjdGVkLCB5ZXRcbiIpOwo+Pj4gICAgCQlyZXR1cm47Cj4+PiAg ICAJfQo+Pj4gICAgLXJhZGFyX2RldGVjdGVkOgo+Pj4gLQlhdGgxMGtfZGJnKGFyLCBBVEgxMEtf REJHX1JFR1VMQVRPUlksICJkZnMgcmFkYXIgZGV0ZWN0ZWRcbiIpOwo+Pj4gLQlBVEgxMEtfREZT X1NUQVRfSU5DKGFyLCByYWRhcl9kZXRlY3RlZCk7Cj4+PiArCWlmICgodGVzdF9iaXQoV01JX1NF UlZJQ0VfSE9TVF9ERlNfQ0hFQ0tfU1VQUE9SVCwgYXItPndtaS5zdmNfbWFwKSkgJiYKPj4+ICsJ ICAgIGFyLT5kZnNfZGV0ZWN0b3ItPnJlZ2lvbiA9PSBOTDgwMjExX0RGU19GQ0MpIHsKPj4gSSBm ZWVsIHJpc2t5IHRoYXQgaG9zdCBkcml2ZXJzIGhhdmUgbm8gd2F5IHRvIGNvbnRyb2wgdGhpcyBu ZXcgZmVhdHVyZQo+PiBhbmQgdG90YWxseSByZWx5IG9uIEZXIGZlYXR1cmUgbWFzay4gV2Ugc2hv dWxkIGhhdmUgYSBob3N0IGRyaXZlcnMnCj4+IGZlYXR1cmUgbWFzayBzdWNoIGFzIG1vZHVsZSBw YXJhbSBhbmQgc2V0IGl0IGZhbHNlIChkb24ndCB1c2UpIGJ5Cj4+IGRlZmF1bHQgdW50aWwgaXQg cHJvdmVzIHNhZmUgdG8gdXNlLgo+IFRoaXMgaXMgZm9yIHJlZ3VsYXRvcnkgZW5mb3JjZW1lbnQg c28gaXQncyBub3QgcG9zc2libGUgdG8gZGlzYWJsZSB0aGUKPiBmZWF0dXJlIGZyb20gaG9zdC4K bW1oIGZyb20gd2hhdCBpIHNlZSBpdCBpcyBwb3NzaWJsZSB0byBkaXNhYmxlIGl0IGZyb20gaG9z dCBzaW5jZSB0aGUgCmZpcm13YXJlIHNlZW0gdG8gYmUgc2Vuc2l0aXZlIG9uIHRoZSByZWdkb21h aW4gc2V0IGJ5IHRoZSBob3N0CnNvIGlmIGhvc3Qgc2V0cyBhbnl0aGluZyBlbHNlIHRoYW4gYSBG Q0MgcmVnZG9tYWluLCBpdCB3aWxsIHN0aWxsIHdvcmsgCmluIHRoZSBvbGQgd2F5LiBzbyBpdHMg bW9yZSBhIHBzZXVkbyBlbmZvcmNlbWVudC4gZG9udCBrbm93IGlmIHRoaXMgaXMKdXNlZnVsbCBh bmQgaXQgYWxzbyB3aWxsIGl0IG1ha2UgaW1wb3NzaWJsZSB0byBmaXggcmFkYXIgZGV0ZWN0aW9u IAppc3N1ZXMgZm9yIGNlcnRpZmljYXRpb24gYXMgbWVudGlvbmVkIGJ5IHBldGVyIGFuZCBhZHJp YW4uCgpTZWJhc3RpYW4KPgoKLS0gCk1pdCBmcmV1bmRsaWNoZW4gR3LDvHNzZW4gLyBSZWdhcmRz CgpTZWJhc3RpYW4gR290dHNjaGFsbCAvIENUTwoKTmV3TWVkaWEtTkVUIEdtYkggLSBERC1XUlQK RmlybWVuc2l0ejogIFN0dWJlbndhbGRhbGxlZSAyMWEsIDY0NjI1IEJlbnNoZWltClJlZ2lzdGVy Z2VyaWNodDogQW10c2dlcmljaHQgRGFybXN0YWR0LCBIUkIgMjU0NzMKR2VzY2jDpGZ0c2bDvGhy ZXI6IFBldGVyIFN0ZWluaMOkdXNlciwgQ2hyaXN0aWFuIFNjaGVlbGUKaHR0cDovL3d3dy5kZC13 cnQuY29tCmVtYWlsOiBzLmdvdHRzY2hhbGxAZGQtd3J0LmNvbQpUZWwuOiArNDk2MjUxLTU4MjY1 MCAvIEZheDogKzQ5NjI1MS01ODI2NTY1CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KYXRoMTBrIG1haWxpbmcgbGlzdAphdGgxMGtAbGlzdHMuaW5mcmFk ZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2F0aDEw awo=