From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50993C4361B for ; Fri, 18 Dec 2020 08:47:31 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B7FB3233E2 for ; Fri, 18 Dec 2020 08:47:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B7FB3233E2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38088 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kqBQ9-0002ze-OT for qemu-devel@archiver.kernel.org; Fri, 18 Dec 2020 03:47:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51904) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kqBOt-0001lE-PW; Fri, 18 Dec 2020 03:46:13 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:2567) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kqBOl-0006RJ-LO; Fri, 18 Dec 2020 03:46:11 -0500 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4Cy2W42NYwzhsBK; Fri, 18 Dec 2020 16:45:20 +0800 (CST) Received: from [10.174.187.37] (10.174.187.37) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.498.0; Fri, 18 Dec 2020 16:45:41 +0800 Subject: Ping: [PATCH v2] bugfix: hostmem: Free host_nodes list right after visited To: Peter Maydell References: <20201210075226.20196-1-zhukeqian1@huawei.com> From: Keqian Zhu Message-ID: <3f8e6aa5-f5eb-9a84-3089-e82a7de74ad0@huawei.com> Date: Fri, 18 Dec 2020 16:45:41 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20201210075226.20196-1-zhukeqian1@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.187.37] X-CFilter-Loop: Reflected Received-SPF: pass client-ip=45.249.212.32; envelope-from=zhukeqian1@huawei.com; helo=szxga06-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , wanghaibin.wang@huawei.com, qemu-devel@nongnu.org, alex.chen@huawei.com, qemu-arm@nongnu.org, kuhn.chenqun@huawei.com, Igor Mammedov Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi Peter, Friendly ping :-) Are you going to queue this? Thanks, Keqian On 2020/12/10 15:52, Keqian Zhu wrote: > In host_memory_backend_get_host_nodes, we build host_nodes > list and output it to v (a StringOutputVisitor) but forget > to free the list. This fixes the memory leak. > > The memory leak stack: > > Direct leak of 32 byte(s) in 2 object(s) allocated from: > #0 0xfffda30b3393 in __interceptor_calloc (/usr/lib64/libasan.so.4+0xd3393) > #1 0xfffda1d28b9b in g_malloc0 (/usr/lib64/libglib-2.0.so.0+0x58b9b) > #2 0xaaab05ca6e43 in host_memory_backend_get_host_nodes backends/hostmem.c:94 > #3 0xaaab061ddf83 in object_property_get_uint16List qom/object.c:1478 > #4 0xaaab05866513 in query_memdev hw/core/machine-qmp-cmds.c:312 > #5 0xaaab061d980b in do_object_child_foreach qom/object.c:1001 > #6 0xaaab0586779b in qmp_query_memdev hw/core/machine-qmp-cmds.c:328 > #7 0xaaab0615ed3f in qmp_marshal_query_memdev qapi/qapi-commands-machine.c:327 > #8 0xaaab0632d647 in do_qmp_dispatch qapi/qmp-dispatch.c:147 > #9 0xaaab0632d647 in qmp_dispatch qapi/qmp-dispatch.c:190 > #10 0xaaab0610f74b in monitor_qmp_dispatch monitor/qmp.c:120 > #11 0xaaab0611074b in monitor_qmp_bh_dispatcher monitor/qmp.c:209 > #12 0xaaab063caefb in aio_bh_poll util/async.c:117 > #13 0xaaab063d30fb in aio_dispatch util/aio-posix.c:459 > #14 0xaaab063cac8f in aio_ctx_dispatch util/async.c:268 > #15 0xfffda1d22a6b in g_main_context_dispatch (/usr/lib64/libglib-2.0.so.0+0x52a6b) > #16 0xaaab063d0e97 in glib_pollfds_poll util/main-loop.c:218 > #17 0xaaab063d0e97 in os_host_main_loop_wait util/main-loop.c:241 > #18 0xaaab063d0e97 in main_loop_wait util/main-loop.c:517 > #19 0xaaab05c8bfa7 in main_loop /root/rpmbuild/BUILD/qemu-4.1.0/vl.c:1791 > #20 0xaaab05713bc3 in main /root/rpmbuild/BUILD/qemu-4.1.0/vl.c:4473 > #21 0xfffda0a83ebf in __libc_start_main (/usr/lib64/libc.so.6+0x23ebf) > #22 0xaaab0571ed5f (aarch64-softmmu/qemu-system-aarch64+0x88ed5f) > SUMMARY: AddressSanitizer: 32 byte(s) leaked in 2 allocation(s). > > Fixes: 4cf1b76bf1e2 (hostmem: add properties for NUMA memory policy) > Reported-by: Euler Robot > Tested-by: Chen Qun > Reviewed-by: Igor Mammedov > Signed-off-by: Keqian Zhu > --- > backends/hostmem.c | 1 + > 1 file changed, 1 insertion(+) > --- > > v2: > - Update commit message. > - Add Chen Qun's T.b. > - Add Igor's R.b. > > diff --git a/backends/hostmem.c b/backends/hostmem.c > index 4bde00e8e7..9f9ac95edd 100644 > --- a/backends/hostmem.c > +++ b/backends/hostmem.c > @@ -105,6 +105,7 @@ host_memory_backend_get_host_nodes(Object *obj, Visitor *v, const char *name, > > ret: > visit_type_uint16List(v, name, &host_nodes, errp); > + qapi_free_uint16List(host_nodes); > } > > static void >