From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932882AbdCGQVy (ORCPT <rfc822;w@1wt.eu>);
        Tue, 7 Mar 2017 11:21:54 -0500
Received: from mail-io0-f178.google.com ([209.85.223.178]:34071 "EHLO
        mail-io0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755763AbdCGQVb (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 7 Mar 2017 11:21:31 -0500
Subject: Re: [PATCH] blk: improve order of bio handling in
 generic_make_request()
To: Pavel Machek <pavel@ucw.cz>, Jack Wang <jinpu.wang@profitbricks.com>
References: <87h93blz6g.fsf@notabene.neil.brown.name>
 <71562c2c-97f4-9a0a-32ec-30e0702ca575@profitbricks.com>
 <87lgsjj9w8.fsf@notabene.neil.brown.name>
 <3f261bbe-dcec-db4b-947c-357a5b86a515@profitbricks.com>
 <20170307154652.GA8515@amd>
Cc: NeilBrown <neilb@suse.com>, LKML <linux-kernel@vger.kernel.org>,
        Lars Ellenberg <lars.ellenberg@linbit.com>,
        Kent Overstreet <kent.overstreet@gmail.com>,
        Mike Snitzer <snitzer@redhat.com>,
        Mikulas Patocka <mpatocka@redhat.com>
From: Jens Axboe <axboe@kernel.dk>
Message-ID: <3f93fde3-f6df-33da-fdc8-bb9234d5d695@kernel.dk>
Date: Tue, 7 Mar 2017 09:21:26 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.0
MIME-Version: 1.0
In-Reply-To: <20170307154652.GA8515@amd>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 03/07/2017 08:46 AM, Pavel Machek wrote:
> On Mon 2017-03-06 10:43:59, Jack Wang wrote:
>>
>>
>> On 06.03.2017 05:40, NeilBrown wrote:
>>> On Fri, Mar 03 2017, Jack Wang wrote:
>>>>
>>>> Thanks Neil for pushing the fix.
>>>>
>>>> We can optimize generic_make_request a little bit:
>>>> - assign bio_list struct hold directly instead init and merge
>>>> - remove duplicate code
>>>>
>>>> I think better to squash into your fix.
>>>
>>> Hi Jack,
>>>  I don't object to your changes, but I'd like to see a response from
>>>  Jens first.
>>>  My preference would be to get the original patch in, then other changes
>>>  that build on it, such as this one, can be added.  Until the core
>>>  changes lands, any other work is pointless.
>>>
>>>  Of course if Jens wants a this merged before he'll apply it, I'll
>>>  happily do that.
>>>
>>> Thanks,
>>> NeilBrown
>>
>> Hi Neil,
>>
>> Totally agree, let's wait for Jens's decision.
>>
>> Hi Jens,
>>
>> Please consider this fix also for stable 4.3+ 
> 
> Stable? We don't put this into stable, with exception of minimal fixes
> for real bugs...

What are you smoking? How is this not a real bug?

-- 
Jens Axboe