From mboxrd@z Thu Jan 1 00:00:00 1970 From: Logan Gunthorpe Subject: Re: [PATCH v2 00/17] kunit: introduce KUnit, the Linux kernel unit testing framework Date: Fri, 10 May 2019 10:17:56 -0600 Message-ID: <3faa022b-0b70-0375-aa6d-12ea83a2671f@deltatee.com> References: <20190509015856.GB7031@mit.edu> <580e092f-fa4e-eedc-9e9a-a57dd085f0a6@gmail.com> <20190509032017.GA29703@mit.edu> <7fd35df81c06f6eb319223a22e7b93f29926edb9.camel@oracle.com> <20190509133551.GD29703@mit.edu> <875c546d-9713-bb59-47e4-77a1d2c69a6d@gmail.com> <20190509214233.GA20877@mit.edu> <20190509233043.GC20877@mit.edu> <8914afef-1e66-e6e3-f891-5855768d3018@deltatee.com> <6d6e91ec-33d3-830b-4895-4d7a20ba7d45@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <6d6e91ec-33d3-830b-4895-4d7a20ba7d45@gmail.com> Content-Language: en-CA Sender: linux-kernel-owner@vger.kernel.org To: Frank Rowand , Theodore Ts'o , Tim.Bird@sony.com, knut.omang@oracle.com, gregkh@linuxfoundation.org, brendanhiggins@google.com, keescook@google.com, kieran.bingham@ideasonboard.com, mcgrof@kernel.org, robh@kernel.org, sboyd@kernel.org, shuah@kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, kunit-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-nvdimm@lists.01.org, linux-um@lists.infradead.org, Alexander.Levin@microsoft.com, amir73il@gmail.com, dan.carpenter@oracle.com, dan.j.williams@intel.com, daniel@ffwll.ch, jdike@addtoit.com, joel@jms.id.au, julia.lawall@lip6.fr, khilman@baylibre. List-Id: linux-nvdimm@lists.01.org On 2019-05-09 11:18 p.m., Frank Rowand wrote: > YES, kselftest has in-kernel tests. (Excuse the shouting...) Cool. From my cursory look, in my opinion, these would be greatly improved by converting them to the framework Brendan is proposing for Kunit. >> If they do exists, it seems like it would make sense to >> convert those to kunit and have Kunit tests run-able in a VM or >> baremetal instance. > > They already run in a VM. > > They already run on bare metal. > > They already run in UML. Simply being able to run in UML is not the only thing here. Kunit provides the infrastructure to quickly build, run and report results for all the tests from userspace without needing to worry about the details of building and running a UML kernel, then parsing dmesg to figure out what tests were run or not. > This is not to say that KUnit does not make sense. But I'm still trying > to get a better description of the KUnit features (and there are > some). So read the patches, or the documentation[1] or the LWN article[2]. It's pretty well described in a lot of places -- that's one of the big advantages of it. In contrast, few people seems to have any concept of what kselftests are or where they are or how to run them (I was surprised to find the in-kernel tests in the lib tree). Logan [1] https://google.github.io/kunit-docs/third_party/kernel/docs/ [2] https://lwn.net/Articles/780985/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07049C04A6B for ; Fri, 10 May 2019 16:18:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D3EA12070D for ; Fri, 10 May 2019 16:18:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727678AbfEJQSg (ORCPT ); Fri, 10 May 2019 12:18:36 -0400 Received: from ale.deltatee.com ([207.54.116.67]:36628 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727271AbfEJQSg (ORCPT ); Fri, 10 May 2019 12:18:36 -0400 Received: from guinness.priv.deltatee.com ([172.16.1.162]) by ale.deltatee.com with esmtp (Exim 4.89) (envelope-from ) id 1hP8Dm-0006xr-3M; Fri, 10 May 2019 10:18:07 -0600 To: Frank Rowand , Theodore Ts'o , Tim.Bird@sony.com, knut.omang@oracle.com, gregkh@linuxfoundation.org, brendanhiggins@google.com, keescook@google.com, kieran.bingham@ideasonboard.com, mcgrof@kernel.org, robh@kernel.org, sboyd@kernel.org, shuah@kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, kunit-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-nvdimm@lists.01.org, linux-um@lists.infradead.org, Alexander.Levin@microsoft.com, amir73il@gmail.com, dan.carpenter@oracle.com, dan.j.williams@intel.com, daniel@ffwll.ch, jdike@addtoit.com, joel@jms.id.au, julia.lawall@lip6.fr, khilman@baylibre.com, mpe@ellerman.id.au, pmladek@suse.com, richard@nod.at, rientjes@google.com, rostedt@goodmis.org, wfg@linux.intel.com References: <20190509015856.GB7031@mit.edu> <580e092f-fa4e-eedc-9e9a-a57dd085f0a6@gmail.com> <20190509032017.GA29703@mit.edu> <7fd35df81c06f6eb319223a22e7b93f29926edb9.camel@oracle.com> <20190509133551.GD29703@mit.edu> <875c546d-9713-bb59-47e4-77a1d2c69a6d@gmail.com> <20190509214233.GA20877@mit.edu> <20190509233043.GC20877@mit.edu> <8914afef-1e66-e6e3-f891-5855768d3018@deltatee.com> <6d6e91ec-33d3-830b-4895-4d7a20ba7d45@gmail.com> From: Logan Gunthorpe Message-ID: <3faa022b-0b70-0375-aa6d-12ea83a2671f@deltatee.com> Date: Fri, 10 May 2019 10:17:56 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <6d6e91ec-33d3-830b-4895-4d7a20ba7d45@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-CA Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.162 X-SA-Exim-Rcpt-To: wfg@linux.intel.com, rostedt@goodmis.org, rientjes@google.com, richard@nod.at, pmladek@suse.com, mpe@ellerman.id.au, khilman@baylibre.com, julia.lawall@lip6.fr, joel@jms.id.au, jdike@addtoit.com, daniel@ffwll.ch, dan.j.williams@intel.com, dan.carpenter@oracle.com, amir73il@gmail.com, Alexander.Levin@microsoft.com, linux-um@lists.infradead.org, linux-nvdimm@lists.01.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, kunit-dev@googlegroups.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, shuah@kernel.org, sboyd@kernel.org, robh@kernel.org, mcgrof@kernel.org, kieran.bingham@ideasonboard.com, keescook@google.com, brendanhiggins@google.com, gregkh@linuxfoundation.org, knut.omang@oracle.com, Tim.Bird@sony.com, tytso@mit.edu, frowand.list@gmail.com X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH v2 00/17] kunit: introduce KUnit, the Linux kernel unit testing framework X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019-05-09 11:18 p.m., Frank Rowand wrote: > YES, kselftest has in-kernel tests. (Excuse the shouting...) Cool. From my cursory look, in my opinion, these would be greatly improved by converting them to the framework Brendan is proposing for Kunit. >> If they do exists, it seems like it would make sense to >> convert those to kunit and have Kunit tests run-able in a VM or >> baremetal instance. > > They already run in a VM. > > They already run on bare metal. > > They already run in UML. Simply being able to run in UML is not the only thing here. Kunit provides the infrastructure to quickly build, run and report results for all the tests from userspace without needing to worry about the details of building and running a UML kernel, then parsing dmesg to figure out what tests were run or not. > This is not to say that KUnit does not make sense. But I'm still trying > to get a better description of the KUnit features (and there are > some). So read the patches, or the documentation[1] or the LWN article[2]. It's pretty well described in a lot of places -- that's one of the big advantages of it. In contrast, few people seems to have any concept of what kselftests are or where they are or how to run them (I was surprised to find the in-kernel tests in the lib tree). Logan [1] https://google.github.io/kunit-docs/third_party/kernel/docs/ [2] https://lwn.net/Articles/780985/ From mboxrd@z Thu Jan 1 00:00:00 1970 From: logang at deltatee.com (Logan Gunthorpe) Date: Fri, 10 May 2019 10:17:56 -0600 Subject: [PATCH v2 00/17] kunit: introduce KUnit, the Linux kernel unit testing framework In-Reply-To: <6d6e91ec-33d3-830b-4895-4d7a20ba7d45@gmail.com> References: <20190509015856.GB7031@mit.edu> <580e092f-fa4e-eedc-9e9a-a57dd085f0a6@gmail.com> <20190509032017.GA29703@mit.edu> <7fd35df81c06f6eb319223a22e7b93f29926edb9.camel@oracle.com> <20190509133551.GD29703@mit.edu> <875c546d-9713-bb59-47e4-77a1d2c69a6d@gmail.com> <20190509214233.GA20877@mit.edu> <20190509233043.GC20877@mit.edu> <8914afef-1e66-e6e3-f891-5855768d3018@deltatee.com> <6d6e91ec-33d3-830b-4895-4d7a20ba7d45@gmail.com> Message-ID: <3faa022b-0b70-0375-aa6d-12ea83a2671f@deltatee.com> On 2019-05-09 11:18 p.m., Frank Rowand wrote: > YES, kselftest has in-kernel tests. (Excuse the shouting...) Cool. From my cursory look, in my opinion, these would be greatly improved by converting them to the framework Brendan is proposing for Kunit. >> If they do exists, it seems like it would make sense to >> convert those to kunit and have Kunit tests run-able in a VM or >> baremetal instance. > > They already run in a VM. > > They already run on bare metal. > > They already run in UML. Simply being able to run in UML is not the only thing here. Kunit provides the infrastructure to quickly build, run and report results for all the tests from userspace without needing to worry about the details of building and running a UML kernel, then parsing dmesg to figure out what tests were run or not. > This is not to say that KUnit does not make sense. But I'm still trying > to get a better description of the KUnit features (and there are > some). So read the patches, or the documentation[1] or the LWN article[2]. It's pretty well described in a lot of places -- that's one of the big advantages of it. In contrast, few people seems to have any concept of what kselftests are or where they are or how to run them (I was surprised to find the in-kernel tests in the lib tree). Logan [1] https://google.github.io/kunit-docs/third_party/kernel/docs/ [2] https://lwn.net/Articles/780985/ From mboxrd@z Thu Jan 1 00:00:00 1970 From: logang@deltatee.com (Logan Gunthorpe) Date: Fri, 10 May 2019 10:17:56 -0600 Subject: [PATCH v2 00/17] kunit: introduce KUnit, the Linux kernel unit testing framework In-Reply-To: <6d6e91ec-33d3-830b-4895-4d7a20ba7d45@gmail.com> References: <20190509015856.GB7031@mit.edu> <580e092f-fa4e-eedc-9e9a-a57dd085f0a6@gmail.com> <20190509032017.GA29703@mit.edu> <7fd35df81c06f6eb319223a22e7b93f29926edb9.camel@oracle.com> <20190509133551.GD29703@mit.edu> <875c546d-9713-bb59-47e4-77a1d2c69a6d@gmail.com> <20190509214233.GA20877@mit.edu> <20190509233043.GC20877@mit.edu> <8914afef-1e66-e6e3-f891-5855768d3018@deltatee.com> <6d6e91ec-33d3-830b-4895-4d7a20ba7d45@gmail.com> Message-ID: <3faa022b-0b70-0375-aa6d-12ea83a2671f@deltatee.com> Content-Type: text/plain; charset="UTF-8" Message-ID: <20190510161756.sY9RgK-tUIiBgn8ryt1VeuiVeMCxdmJiLIS0gl2pEvo@z> On 2019-05-09 11:18 p.m., Frank Rowand wrote: > YES, kselftest has in-kernel tests. (Excuse the shouting...) Cool. From my cursory look, in my opinion, these would be greatly improved by converting them to the framework Brendan is proposing for Kunit. >> If they do exists, it seems like it would make sense to >> convert those to kunit and have Kunit tests run-able in a VM or >> baremetal instance. > > They already run in a VM. > > They already run on bare metal. > > They already run in UML. Simply being able to run in UML is not the only thing here. Kunit provides the infrastructure to quickly build, run and report results for all the tests from userspace without needing to worry about the details of building and running a UML kernel, then parsing dmesg to figure out what tests were run or not. > This is not to say that KUnit does not make sense. But I'm still trying > to get a better description of the KUnit features (and there are > some). So read the patches, or the documentation[1] or the LWN article[2]. It's pretty well described in a lot of places -- that's one of the big advantages of it. In contrast, few people seems to have any concept of what kselftests are or where they are or how to run them (I was surprised to find the in-kernel tests in the lib tree). Logan [1] https://google.github.io/kunit-docs/third_party/kernel/docs/ [2] https://lwn.net/Articles/780985/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ale.deltatee.com ([207.54.116.67]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hP8EC-0000h4-QH for linux-um@lists.infradead.org; Fri, 10 May 2019 16:18:34 +0000 References: <20190509015856.GB7031@mit.edu> <580e092f-fa4e-eedc-9e9a-a57dd085f0a6@gmail.com> <20190509032017.GA29703@mit.edu> <7fd35df81c06f6eb319223a22e7b93f29926edb9.camel@oracle.com> <20190509133551.GD29703@mit.edu> <875c546d-9713-bb59-47e4-77a1d2c69a6d@gmail.com> <20190509214233.GA20877@mit.edu> <20190509233043.GC20877@mit.edu> <8914afef-1e66-e6e3-f891-5855768d3018@deltatee.com> <6d6e91ec-33d3-830b-4895-4d7a20ba7d45@gmail.com> From: Logan Gunthorpe Message-ID: <3faa022b-0b70-0375-aa6d-12ea83a2671f@deltatee.com> Date: Fri, 10 May 2019 10:17:56 -0600 MIME-Version: 1.0 In-Reply-To: <6d6e91ec-33d3-830b-4895-4d7a20ba7d45@gmail.com> Content-Language: en-CA Subject: Re: [PATCH v2 00/17] kunit: introduce KUnit, the Linux kernel unit testing framework List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Frank Rowand , Theodore Ts'o , Tim.Bird@sony.com, knut.omang@oracle.com, gregkh@linuxfoundation.org, brendanhiggins@google.com, keescook@google.com, kieran.bingham@ideasonboard.com, mcgrof@kernel.org, robh@kernel.org, sboyd@kernel.org, shuah@kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, kunit-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-nvdimm@lists.01.org, linux-um@lists.infradead.org, Alexander.Levin@microsoft.com, amir73il@gmail.com, dan.carpenter@oracle.com, dan.j.williams@intel.com, daniel@ffwll.ch, jdike@addtoit.com, joel@jms.id.au, julia.lawall@lip6.fr, khilman@baylibre.com, mpe@ellerman.id.au, pmladek@suse.com, richard@nod.at, rientjes@google.com, rostedt@goodmis.org, wfg@linux.intel.com On 2019-05-09 11:18 p.m., Frank Rowand wrote: > YES, kselftest has in-kernel tests. (Excuse the shouting...) Cool. From my cursory look, in my opinion, these would be greatly improved by converting them to the framework Brendan is proposing for Kunit. >> If they do exists, it seems like it would make sense to >> convert those to kunit and have Kunit tests run-able in a VM or >> baremetal instance. > > They already run in a VM. > > They already run on bare metal. > > They already run in UML. Simply being able to run in UML is not the only thing here. Kunit provides the infrastructure to quickly build, run and report results for all the tests from userspace without needing to worry about the details of building and running a UML kernel, then parsing dmesg to figure out what tests were run or not. > This is not to say that KUnit does not make sense. But I'm still trying > to get a better description of the KUnit features (and there are > some). So read the patches, or the documentation[1] or the LWN article[2]. It's pretty well described in a lot of places -- that's one of the big advantages of it. In contrast, few people seems to have any concept of what kselftests are or where they are or how to run them (I was surprised to find the in-kernel tests in the lib tree). Logan [1] https://google.github.io/kunit-docs/third_party/kernel/docs/ [2] https://lwn.net/Articles/780985/ _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um