From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5F85C433EF for ; Wed, 27 Oct 2021 07:46:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A09FF60E05 for ; Wed, 27 Oct 2021 07:46:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240626AbhJ0HtM (ORCPT ); Wed, 27 Oct 2021 03:49:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:39602 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240621AbhJ0HtL (ORCPT ); Wed, 27 Oct 2021 03:49:11 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 50601610A4; Wed, 27 Oct 2021 07:46:46 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mfde0-001qv7-6d; Wed, 27 Oct 2021 08:46:44 +0100 MIME-Version: 1.0 Date: Wed, 27 Oct 2021 08:46:44 +0100 From: Marc Zyngier To: Qian Cai Cc: James Morse , Ard Biesheuvel , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: arm64: Remove unused TRNG_NO_ENTROPY In-Reply-To: <20211026210913.57006-1-quic_qiancai@quicinc.com> References: <20211026210913.57006-1-quic_qiancai@quicinc.com> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <3fac8ddb626205286f79adde96ea527b@kernel.org> X-Sender: maz@kernel.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: quic_qiancai@quicinc.com, james.morse@arm.com, ardb@kernel.org, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-10-26 22:09, Qian Cai wrote: > TRNG_NO_ENTROPY was unused when introduced and now. This is also caught > by > GCC (W=2): > > arch/arm64/kvm/trng.c:17: warning: macro "TRNG_NO_ENTROPY" is not used > [-Wunused-macros] > 17 | #define TRNG_NO_ENTROPY ((unsigned long)-3) > > Signed-off-by: Qian Cai > --- > arch/arm64/kvm/trng.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/kvm/trng.c b/arch/arm64/kvm/trng.c > index 99bdd7103c9c..6a46b3ac3970 100644 > --- a/arch/arm64/kvm/trng.c > +++ b/arch/arm64/kvm/trng.c > @@ -14,7 +14,6 @@ > #define TRNG_SUCCESS 0UL > #define TRNG_NOT_SUPPORTED ((unsigned long)-1) > #define TRNG_INVALID_PARAMETER ((unsigned long)-2) > -#define TRNG_NO_ENTROPY ((unsigned long)-3) > > #define TRNG_MAX_BITS64 192 That's an architectural definition that doesn't cause any problem. If anything, that's documentation. We have *tons* of other definitions with no user all over the arm64 code. They save the exact same purpose. M. -- Jazz is not dead. It just smells funny... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6AB5C433FE for ; Wed, 27 Oct 2021 07:46:52 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 45E7F610C7 for ; Wed, 27 Oct 2021 07:46:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 45E7F610C7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id B498F4B11F; Wed, 27 Oct 2021 03:46:51 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AzG35vAo59H4; Wed, 27 Oct 2021 03:46:50 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 500F64B0B9; Wed, 27 Oct 2021 03:46:50 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 82FCF4B0B9 for ; Wed, 27 Oct 2021 03:46:48 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3obpcddqozs2 for ; Wed, 27 Oct 2021 03:46:47 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 4EDAE4B08B for ; Wed, 27 Oct 2021 03:46:47 -0400 (EDT) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 50601610A4; Wed, 27 Oct 2021 07:46:46 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mfde0-001qv7-6d; Wed, 27 Oct 2021 08:46:44 +0100 MIME-Version: 1.0 Date: Wed, 27 Oct 2021 08:46:44 +0100 From: Marc Zyngier To: Qian Cai Subject: Re: [PATCH] KVM: arm64: Remove unused TRNG_NO_ENTROPY In-Reply-To: <20211026210913.57006-1-quic_qiancai@quicinc.com> References: <20211026210913.57006-1-quic_qiancai@quicinc.com> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <3fac8ddb626205286f79adde96ea527b@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: quic_qiancai@quicinc.com, james.morse@arm.com, ardb@kernel.org, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: Will Deacon , linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu, Catalin Marinas , linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On 2021-10-26 22:09, Qian Cai wrote: > TRNG_NO_ENTROPY was unused when introduced and now. This is also caught > by > GCC (W=2): > > arch/arm64/kvm/trng.c:17: warning: macro "TRNG_NO_ENTROPY" is not used > [-Wunused-macros] > 17 | #define TRNG_NO_ENTROPY ((unsigned long)-3) > > Signed-off-by: Qian Cai > --- > arch/arm64/kvm/trng.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/kvm/trng.c b/arch/arm64/kvm/trng.c > index 99bdd7103c9c..6a46b3ac3970 100644 > --- a/arch/arm64/kvm/trng.c > +++ b/arch/arm64/kvm/trng.c > @@ -14,7 +14,6 @@ > #define TRNG_SUCCESS 0UL > #define TRNG_NOT_SUPPORTED ((unsigned long)-1) > #define TRNG_INVALID_PARAMETER ((unsigned long)-2) > -#define TRNG_NO_ENTROPY ((unsigned long)-3) > > #define TRNG_MAX_BITS64 192 That's an architectural definition that doesn't cause any problem. If anything, that's documentation. We have *tons* of other definitions with no user all over the arm64 code. They save the exact same purpose. M. -- Jazz is not dead. It just smells funny... _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A133DC433FE for ; Wed, 27 Oct 2021 07:48:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6427D610CA for ; Wed, 27 Oct 2021 07:48:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6427D610CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6ZP4t2oEsxCHJwf88DynZ+hHUQSMFk+B6tW0so28vwo=; b=orr6uw/06WdNA8+9WV063xVpAI XxZGO7BY6FKkS/KfKartyumH0+UmN/Cqu24FRVIXhp20ogakZlD1qGARteBT16aObysNLchKbT5+S 2hDWNRWMhE1G8pmw8vKmZO8MNhHLD+vOzMU8TV8k1xouSk3ZBGmiE4l9lwgtUBileV13vgt0JDMqA 6d1mmMCwkm7VFH9aLMD3g1r9L19TUO6Od9LEnd+VO2lKorGfRCwgbW1jozNtVxilKyLVwaR0GHTNi cVDEQNdvOH56KNyhhqwy3a8dgM4JOXwEeLg5wqmzagMCJKZ1y6mUsznJkuvfTyg4Qg1NaqwsMYjP+ 3oxpG5cQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mfde7-004Cnd-TD; Wed, 27 Oct 2021 07:46:52 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mfde3-004Cml-K9 for linux-arm-kernel@lists.infradead.org; Wed, 27 Oct 2021 07:46:48 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 50601610A4; Wed, 27 Oct 2021 07:46:46 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mfde0-001qv7-6d; Wed, 27 Oct 2021 08:46:44 +0100 MIME-Version: 1.0 Date: Wed, 27 Oct 2021 08:46:44 +0100 From: Marc Zyngier To: Qian Cai Cc: James Morse , Ard Biesheuvel , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: arm64: Remove unused TRNG_NO_ENTROPY In-Reply-To: <20211026210913.57006-1-quic_qiancai@quicinc.com> References: <20211026210913.57006-1-quic_qiancai@quicinc.com> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <3fac8ddb626205286f79adde96ea527b@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: quic_qiancai@quicinc.com, james.morse@arm.com, ardb@kernel.org, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211027_004647_712078_9F5DC7B7 X-CRM114-Status: GOOD ( 15.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2021-10-26 22:09, Qian Cai wrote: > TRNG_NO_ENTROPY was unused when introduced and now. This is also caught > by > GCC (W=2): > > arch/arm64/kvm/trng.c:17: warning: macro "TRNG_NO_ENTROPY" is not used > [-Wunused-macros] > 17 | #define TRNG_NO_ENTROPY ((unsigned long)-3) > > Signed-off-by: Qian Cai > --- > arch/arm64/kvm/trng.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/kvm/trng.c b/arch/arm64/kvm/trng.c > index 99bdd7103c9c..6a46b3ac3970 100644 > --- a/arch/arm64/kvm/trng.c > +++ b/arch/arm64/kvm/trng.c > @@ -14,7 +14,6 @@ > #define TRNG_SUCCESS 0UL > #define TRNG_NOT_SUPPORTED ((unsigned long)-1) > #define TRNG_INVALID_PARAMETER ((unsigned long)-2) > -#define TRNG_NO_ENTROPY ((unsigned long)-3) > > #define TRNG_MAX_BITS64 192 That's an architectural definition that doesn't cause any problem. If anything, that's documentation. We have *tons* of other definitions with no user all over the arm64 code. They save the exact same purpose. M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel