All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: "Pali Rohár" <pali@kernel.org>, "Marek Behún" <marek.behun@nic.cz>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH 1/2] pci: pci_mvebu: Remove unused SELECT and lane_mask
Date: Fri, 18 Feb 2022 15:17:52 +0100	[thread overview]
Message-ID: <3fbed9c4-ad3f-aef8-90b8-7eb54a0f7968@denx.de> (raw)
In-Reply-To: <20220218112523.10121-1-pali@kernel.org>

On 2/18/22 12:25, Pali Rohár wrote:
> Macro SELECT() is unused and struct mvebu_pcie field lane_mask is unused
> too. Remove them.
> 
> Signed-off-by: Pali Rohár <pali@kernel.org>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
>   drivers/pci/pci_mvebu.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/pci/pci_mvebu.c b/drivers/pci/pci_mvebu.c
> index 5a0a59a8b9ec..16fe54fd366f 100644
> --- a/drivers/pci/pci_mvebu.c
> +++ b/drivers/pci/pci_mvebu.c
> @@ -30,8 +30,6 @@
>   #include <linux/sizes.h>
>   
>   /* PCIe unit register offsets */
> -#define SELECT(x, n)			((x >> n) & 1UL)
> -
>   #define PCIE_DEV_ID_OFF			0x0000
>   #define PCIE_CMD_OFF			0x0004
>   #define PCIE_DEV_REV_OFF		0x0008
> @@ -77,7 +75,6 @@ struct mvebu_pcie {
>   	u32 lane;
>   	bool is_x4;
>   	int devfn;
> -	u32 lane_mask;
>   	int sec_busno;
>   	char name[16];
>   	unsigned int mem_target;

Viele Grüße,
Stefan Roese

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de

  parent reply	other threads:[~2022-02-18 14:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-18 11:25 [PATCH 1/2] pci: pci_mvebu: Remove unused SELECT and lane_mask Pali Rohár
2022-02-18 11:25 ` [PATCH 2/2] pci: pci_mvebu: Cleanup macro names Pali Rohár
2022-02-18 13:12   ` Marek Behún
2022-02-18 14:18   ` Stefan Roese
2022-03-04 12:21     ` Stefan Roese
2022-02-18 13:12 ` [PATCH 1/2] pci: pci_mvebu: Remove unused SELECT and lane_mask Marek Behún
2022-02-18 14:17 ` Stefan Roese [this message]
2022-03-04 12:21   ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3fbed9c4-ad3f-aef8-90b8-7eb54a0f7968@denx.de \
    --to=sr@denx.de \
    --cc=marek.behun@nic.cz \
    --cc=pali@kernel.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.