All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Bajjuri, Praneeth" <praneeth@ti.com>
To: Denys Dmytriyenko <denis@denix.org>
Cc: meta-arago@arago-project.org
Subject: Re: [dunfell/master][PATCH] optee-os: as meta-ti now has upstream 3.11, drop local fork
Date: Tue, 5 Jan 2021 10:04:03 -0600	[thread overview]
Message-ID: <3fcd6f7b-7ef4-aed8-4e88-ec6084d383ca@ti.com> (raw)
In-Reply-To: <20201221235902.GF24670@denix.org>



On 12/21/2020 5:59 PM, Denys Dmytriyenko wrote:
> On Thu, Dec 17, 2020 at 05:31:23PM -0600, Bajjuri, Praneeth wrote:
>>
>>
>> On 12/17/2020 3:42 PM, Denys Dmytriyenko wrote:
>>> There's no need for ti-optee-os fork any more, as it's exactly the same as upstream
>>
>> Thanks Denys for the fix.
>>
>> This along with the meta-ti patch helped in building 3.11 on sdk builds.
>>
>> One question though, While there is no difference today between TI
>> and upstream optee, Any reason why we cannot use the forked project?
>> Similar to how we are doing with ATF today ?
> 
> Praneeth,
> 
>  From the community perspective, it's a bad practice to fork an upstream
> project "just in case", when there are no real differences...

Thanks for the explanation, makes sense.
We should be doing the same way for ATF too.

> 
> Denys
> 
> 
>>> Signed-off-by: Denys Dmytriyenko <denis@denix.org>

Reviewed-by: Praneeth Bajjuri <praneeth@ti.com>

>>> ---
>>>   meta-arago-distro/recipes-security/optee/optee-os_git.bbappend | 7 -------
>>>   1 file changed, 7 deletions(-)
>>>   delete mode 100644 meta-arago-distro/recipes-security/optee/optee-os_git.bbappend
>>>
>>> diff --git a/meta-arago-distro/recipes-security/optee/optee-os_git.bbappend b/meta-arago-distro/recipes-security/optee/optee-os_git.bbappend
>>> deleted file mode 100644
>>> index 677c6dd..0000000
>>> --- a/meta-arago-distro/recipes-security/optee/optee-os_git.bbappend
>>> +++ /dev/null
>>> @@ -1,7 +0,0 @@
>>> -PR_append = ".arago0"
>>> -
>>> -SRC_URI = "git://git.ti.com/optee/ti-optee-os.git;branch=${BRANCH} \
>>> -           file://0001-allow-setting-sysroot-for-libgcc-lookup.patch \
>>> -"
>>> -BRANCH = "ti-optee-os"
>>> -SRCREV = "199fca17b575d4c748c9c435e908a6ec9618c75a"
>>>


      reply	other threads:[~2021-01-05 16:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-17 21:42 [dunfell/master][PATCH] optee-os: as meta-ti now has upstream 3.11, drop local fork Denys Dmytriyenko
2020-12-17 23:31 ` Bajjuri, Praneeth
2020-12-21 23:59   ` Denys Dmytriyenko
2021-01-05 16:04     ` Bajjuri, Praneeth [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3fcd6f7b-7ef4-aed8-4e88-ec6084d383ca@ti.com \
    --to=praneeth@ti.com \
    --cc=denis@denix.org \
    --cc=meta-arago@arago-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.