From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D1F5C433E2 for ; Fri, 4 Sep 2020 15:12:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0BE742074D for ; Fri, 4 Sep 2020 15:12:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VGCiPtVS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730798AbgIDPMB (ORCPT ); Fri, 4 Sep 2020 11:12:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730777AbgIDPL7 (ORCPT ); Fri, 4 Sep 2020 11:11:59 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB759C061244 for ; Fri, 4 Sep 2020 08:11:57 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id w2so6407934wmi.1 for ; Fri, 04 Sep 2020 08:11:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=cc:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=AdLV9YJUjnLAQ+JQ9cfkAho1/qjI7j9F9E0VKpW+cys=; b=VGCiPtVSxuj92QO9gTy9rr4mE926isJZNVoUmHHhbrzvRCRWtCIRj9eR5hlD69tfOU C+V3prvqq+u0oybjaDbdsyyBFSnPXEJXkMy0pi3yL09W4DdKhrqIILhzdgamOIGANvRq vlL8k0LiHmZR4JnoJNj4pZgYVH+YjPMmz3c3Shxim+n4ecxB5NoIzbQ8mrMGg5uiKVJg ymfVv1zsl02i1AQzmLGIIOmtLXpKS+1mx/60EGsEy/FkLYHtEVg29VA86uvxuXvAM3UX i2FAedDKEqIM+GO7fjPsRURs9tigD3h/mU9e1/MPy6+sNG+Lq2Vml0q4lnf3azqxVp41 35qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:cc:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=AdLV9YJUjnLAQ+JQ9cfkAho1/qjI7j9F9E0VKpW+cys=; b=VQu6ykIY1/NspUZKIUt3etW9YDZkxygNTQJEgfIeL3cm4ux0wGQr8mSTznuPh2Csd5 exWBaRr15J+wsf9VYS4D7XguLn3zq9MVfHjqGGv9QyubIl7bD0+MzORU77apc2MPv3bj Huc+R5eS25w6WPBmm26yzcqhF74LUxEhdmWYRcdNIrQwmUtypZYhAHprL5IK8MA+Y8XG zzZXDfrUIjmPlipXud3olpRv9NHekjZIASxygSow22JC2BPOR3sLd8syetamQnHEmVsr HgKIophdj4NcRAwIZSfKPLFwlOcQqDYwJJCj8P+NNcu7AtfUyVZraXpzslmmvTW6pkP5 bVCw== X-Gm-Message-State: AOAM531zIMgQj9c9dk4FnFyYAnKnk9FDyBXaUq/8hLGAK/0AOXaTbMPg ed4lN7MXsVCCsT6ch8RfzK3sYf1H6XE= X-Google-Smtp-Source: ABdhPJxTl5AR7MuJx8bLJwbb2TvtntsE+HSpvc9Sp44v38gHDtBQkOVeQAF4jYrxOIeyw8GoAUJC8w== X-Received: by 2002:a1c:c256:: with SMTP id s83mr8136737wmf.93.1599232316400; Fri, 04 Sep 2020 08:11:56 -0700 (PDT) Received: from ?IPv6:2001:a61:3ab0:7001:e081:d401:3da8:e4bc? ([2001:a61:3ab0:7001:e081:d401:3da8:e4bc]) by smtp.gmail.com with ESMTPSA id z83sm4093513wmb.4.2020.09.04.08.11.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Sep 2020 08:11:54 -0700 (PDT) Cc: mtk.manpages@gmail.com, linux-man@vger.kernel.org, Jakub Wilk Subject: Re: [PATCH (2) 09/34] sysctl.2: Use sizeof consistently To: Alejandro Colomar References: <20200825111924.gwf3ck4bdq42lrzr@jwilk.net> <806999b7-8947-d350-2125-f04b69846f37@gmail.com> <9fcc512e-a12c-5b28-126f-aaf1854ed290@gmail.com> <2b288808-c840-343f-9e56-8097765e5528@gmail.com> <876dcc97-8151-7160-5eda-19307f0483c1@gmail.com> <462b75ca-bef8-063d-b6ec-d1c845fb1580@gmail.com> <26629635-bf4c-1279-314d-db92f11adbb7@gmail.com> <257c9374-3253-9091-c116-045ee16590c0@gmail.com> <40ba6e68-c2f6-649c-2225-6037e3c0c077@gmail.com> From: "Michael Kerrisk (man-pages)" Message-ID: <3fe03c56-4b86-0f3a-85ce-3d1c31bf20b6@gmail.com> Date: Fri, 4 Sep 2020 17:11:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-man-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-man@vger.kernel.org Hi Alex, On 9/4/20 3:43 PM, Alejandro Colomar wrote: >>>From 90572d59a4f3b1986e57c0b32e14e4e68ecab716 Mon Sep 17 00:00:00 2001 > From: Alejandro Colomar > Date: Thu, 3 Sep 2020 21:39:56 +0200 > Subject: [PATCH 09/34] sysctl.2: Use sizeof consistently > > Use ``sizeof`` consistently through all the examples in the following > way: > > - Use the name of the variable instead of its type as argument for > ``sizeof``. > > Rationale: > https://www.kernel.org/doc/html/v5.8/process/coding-style.html#allocating-memory > > Signed-off-by: Alejandro Colomar Patch applied. Thanks! Cheers, Michael > --- > man2/sysctl.2 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/man2/sysctl.2 b/man2/sysctl.2 > index 65f79516d..161060490 100644 > --- a/man2/sysctl.2 > +++ b/man2/sysctl.2 > @@ -154,7 +154,7 @@ main(void) > size_t osnamelth; > int name[] = { CTL_KERN, KERN_OSTYPE }; > > - memset(&args, 0, sizeof(struct __sysctl_args)); > + memset(&args, 0, sizeof(args)); > args.name = name; > args.nlen = sizeof(name)/sizeof(name[0]); > args.oldval = osname; > -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/