From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AE6AC2B9F8 for ; Tue, 25 May 2021 11:38:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0052F6128D for ; Tue, 25 May 2021 11:38:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231768AbhEYLjv (ORCPT ); Tue, 25 May 2021 07:39:51 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:48806 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230350AbhEYLjt (ORCPT ); Tue, 25 May 2021 07:39:49 -0400 Received: from mail-ua1-f72.google.com ([209.85.222.72]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1llVO7-0006Vx-6F for linux-kernel@vger.kernel.org; Tue, 25 May 2021 11:38:19 +0000 Received: by mail-ua1-f72.google.com with SMTP id o7-20020ab01e870000b029020d37e3e144so12923313uak.1 for ; Tue, 25 May 2021 04:38:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CZwbJzMdNKQ9pWB+s9p+++BmYWbMRl5a2xW6x+5P6p4=; b=CvhpCSDWSFSn2QZ9pASOZtIaFIQFfDzSM4mC5o1WpHpzTbGBqsacqPHOlObMJi/aJC 91uA+6UrKS1+yUBKwV0fdeteNFh6XHzGcF+znh2DsDDl/w8fwcZN91+akQCi/Xl8YWvI 8sF7doZK47laLp9vMiSVZQ9MwC7CjIH0Ke+mgSAlF8f2AAcEX8HtjCmSGML27LrU/Bin 26C0DCxQTOFGRk4OumsRsz/yBUX1+aTkMp3zBNTc+lgSbvIQE+4IVsTdHrhpNp5fG2Fg 51CMQF2nRHwJ6fGl9vINXTDj87T7pWngCn0gcO1KQj0DgIZ2WnWJHRCo4ZpqOdOCa+2p WVjg== X-Gm-Message-State: AOAM531LmhtH2Qva6ZOVS5kwc3jUwIGPicvopAgiuX70s+RWTTxLugCF vu5AXZA44LEImqpY5zkKG9+wdDkAF24jRCcK5ExNQtMlUj6xzpKU+SHAFweE/PplNVJHqrADjT7 kLv5oGjDSKR3DjTwnO4tDsIkuuLRKzoJedCHwUkP41g== X-Received: by 2002:a05:6102:c51:: with SMTP id y17mr25390310vss.26.1621942698293; Tue, 25 May 2021 04:38:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyOEzcON3XhO32bZ26xkZY6KWrQERAD0cR1oUrEsZ49BhW9FtyS4wfFrcDhfyuXV5mJmUftYQ== X-Received: by 2002:a05:6102:c51:: with SMTP id y17mr25390303vss.26.1621942698166; Tue, 25 May 2021 04:38:18 -0700 (PDT) Received: from [192.168.1.4] ([45.237.48.1]) by smtp.gmail.com with ESMTPSA id y129sm1549174vkg.9.2021.05.25.04.38.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 May 2021 04:38:17 -0700 (PDT) Subject: Re: [PATCH] NFC: st95hf: remove unnecessary assignment and label To: samirweng1979 , davem@davemloft.net, dinghao.liu@zju.edu.cn Cc: linux-nfc@lists.01.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, wengjianfeng References: <20210525063801.11840-1-samirweng1979@163.com> From: Krzysztof Kozlowski Message-ID: <3fe26970-91ab-d598-92ff-e13d8d707d47@canonical.com> Date: Tue, 25 May 2021 07:38:12 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210525063801.11840-1-samirweng1979@163.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/05/2021 02:38, samirweng1979 wrote: > From: wengjianfeng > > In function st95hf_in_send_cmd, the variable rc is assigned then goto > error label, which just return rc, so we use return to replace it. and s/return/returns/ s/. and/. Since/ (don't start sentences with "and", neither with lowercase letter). > error label only used once in the function, so we remove error label. With these fixes and subject prefix fix to "nfc" (lowercase): Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4078DC4707F for ; Tue, 25 May 2021 11:38:25 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D7EB06141D for ; Tue, 25 May 2021 11:38:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D7EB06141D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nfc-bounces@lists.01.org Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 1313C100ED497; Tue, 25 May 2021 04:38:24 -0700 (PDT) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=91.189.89.112; helo=youngberry.canonical.com; envelope-from=krzysztof.kozlowski@canonical.com; receiver= Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E0492100EF271 for ; Tue, 25 May 2021 04:38:21 -0700 (PDT) Received: from mail-vk1-f197.google.com ([209.85.221.197]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1llVO7-0006Vw-6M for linux-nfc@lists.01.org; Tue, 25 May 2021 11:38:19 +0000 Received: by mail-vk1-f197.google.com with SMTP id 28-20020a056122169cb0290200b091f299so3216008vkl.3 for ; Tue, 25 May 2021 04:38:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CZwbJzMdNKQ9pWB+s9p+++BmYWbMRl5a2xW6x+5P6p4=; b=H2m5tYa2fqT3GzI+tMegYVLuOBARAP+Cuw4YKHJ+8qaNaLkeo32hIAhGsG4TQq7Pxj PYnS18H8yvsuTkaGenUOdu0JuOetv6aYdFKsdYVw7kh0StDwDGXWWIAlKfvbew4Xb/yF FVgiqjKa/0M2lD3QjP9YVwOd4yR/S5BoIxTN+B04GtiPxCZrdb9ayKpEC4CRfbRh+KmR EAntnEtKsy0sZ7eMoft7ny9dnjhNL9Aido4yLUFtBmUkHF4VcTtgeRS4Y4qYSgGEpDbp UTrtbOJmHufrijeupfnQx+W2lCmWJOEVY3igpqo09q/d1+laSL8nMpGAZKPE5tN1B/z4 Nrug== X-Gm-Message-State: AOAM5324S7V3FAaMbc2Wp0RtTPnj7sTJb93IiJLj+ehtu3akzBak9dP9 uuUK9vCDiifrmu9+g07avX+AwFmpVDEOBgVlRdS8rrLpJKetawHwUHMAOXcHnNfgpBOssrIRCZ8 /wEENsCooTtrs0ueuPnJ1DKTDMjViiiU57A== X-Received: by 2002:a05:6102:c51:: with SMTP id y17mr25390313vss.26.1621942698338; Tue, 25 May 2021 04:38:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyOEzcON3XhO32bZ26xkZY6KWrQERAD0cR1oUrEsZ49BhW9FtyS4wfFrcDhfyuXV5mJmUftYQ== X-Received: by 2002:a05:6102:c51:: with SMTP id y17mr25390303vss.26.1621942698166; Tue, 25 May 2021 04:38:18 -0700 (PDT) Received: from [192.168.1.4] ([45.237.48.1]) by smtp.gmail.com with ESMTPSA id y129sm1549174vkg.9.2021.05.25.04.38.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 May 2021 04:38:17 -0700 (PDT) To: samirweng1979 , davem@davemloft.net, dinghao.liu@zju.edu.cn References: <20210525063801.11840-1-samirweng1979@163.com> From: Krzysztof Kozlowski Message-ID: <3fe26970-91ab-d598-92ff-e13d8d707d47@canonical.com> Date: Tue, 25 May 2021 07:38:12 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210525063801.11840-1-samirweng1979@163.com> Content-Language: en-US Message-ID-Hash: 2NCW4OKQQBJSOTSN55KHRMFPRVCRC57V X-Message-ID-Hash: 2NCW4OKQQBJSOTSN55KHRMFPRVCRC57V X-MailFrom: krzysztof.kozlowski@canonical.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: linux-nfc@lists.01.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, wengjianfeng X-Mailman-Version: 3.1.1 Precedence: list Subject: [linux-nfc] Re: [PATCH] NFC: st95hf: remove unnecessary assignment and label List-Id: NFC on Linux Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 25/05/2021 02:38, samirweng1979 wrote: > From: wengjianfeng > > In function st95hf_in_send_cmd, the variable rc is assigned then goto > error label, which just return rc, so we use return to replace it. and s/return/returns/ s/. and/. Since/ (don't start sentences with "and", neither with lowercase letter). > error label only used once in the function, so we remove error label. With these fixes and subject prefix fix to "nfc" (lowercase): Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof _______________________________________________ Linux-nfc mailing list -- linux-nfc@lists.01.org To unsubscribe send an email to linux-nfc-leave@lists.01.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============6285098690354950399==" MIME-Version: 1.0 From: Krzysztof Kozlowski To: linux-nfc@lists.01.org Subject: Re: [PATCH] NFC: st95hf: remove unnecessary assignment and label Date: Tue, 25 May 2021 07:38:12 -0400 Message-ID: <3fe26970-91ab-d598-92ff-e13d8d707d47@canonical.com> In-Reply-To: <20210525063801.11840-1-samirweng1979@163.com> List-Id: --===============6285098690354950399== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On 25/05/2021 02:38, samirweng1979 wrote: > From: wengjianfeng > = > In function st95hf_in_send_cmd, the variable rc is assigned then goto > error label, which just return rc, so we use return to replace it. and s/return/returns/ s/. and/. Since/ (don't start sentences with "and", neither with lowercase letter). > error label only used once in the function, so we remove error label. With these fixes and subject prefix fix to "nfc" (lowercase): Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof --===============6285098690354950399==--