From: Shawn Lin <shawn.lin@rock-chips.com>
To: Ulf Hansson <ulf.hansson@linaro.org>, linux-mmc@vger.kernel.org
Cc: shawn.lin@rock-chips.com, Jaehoon Chung <jh80.chung@samsung.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v3 15/15] mmc: core: Don't use extern declarations of public mmc functions
Date: Mon, 16 Jan 2017 11:16:05 +0800 [thread overview]
Message-ID: <3fef6372-ee5e-bcae-1d5f-199b73100a68@rock-chips.com> (raw)
In-Reply-To: <1484313256-25993-16-git-send-email-ulf.hansson@linaro.org>
On 2017/1/13 21:14, Ulf Hansson wrote:
> Using extern when declaring functions in the public header, core.h, is
> redundant. Let's just remove the use of it.
>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> include/linux/mmc/core.h | 17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>
> diff --git a/include/linux/mmc/core.h b/include/linux/mmc/core.h
> index 6440e10..6dcb339 100644
> --- a/include/linux/mmc/core.h
> +++ b/include/linux/mmc/core.h
> @@ -158,13 +158,14 @@ struct mmc_request {
> struct mmc_card;
> struct mmc_async_req;
>
> -extern struct mmc_async_req *mmc_start_req(struct mmc_host *,
> - struct mmc_async_req *,
> - enum mmc_blk_status *);
> -extern void mmc_wait_for_req(struct mmc_host *, struct mmc_request *);
> -extern int mmc_wait_for_cmd(struct mmc_host *, struct mmc_command *, int);
> -
> -extern int mmc_hw_reset(struct mmc_host *host);
> -extern void mmc_set_data_timeout(struct mmc_data *, const struct mmc_card *);
> +struct mmc_async_req *mmc_start_req(struct mmc_host *host,
> + struct mmc_async_req *areq,
> + enum mmc_blk_status *ret_stat);
> +void mmc_wait_for_req(struct mmc_host *host, struct mmc_request *mrq);
> +int mmc_wait_for_cmd(struct mmc_host *host, struct mmc_command *cmd,
> + int retries);
> +
> +int mmc_hw_reset(struct mmc_host *host);
> +void mmc_set_data_timeout(struct mmc_data *data, const struct mmc_card *card);
>
> #endif /* LINUX_MMC_CORE_H */
>
--
Best Regards
Shawn Lin
next prev parent reply other threads:[~2017-01-16 3:16 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-13 13:14 [PATCH v3 00/15] mmc: core: A start to slim down public mmc headers Ulf Hansson
2017-01-13 13:14 ` [PATCH v3 01/15] ARM: pxa: Don't rely on public mmc header to include leds.h Ulf Hansson
2017-01-13 13:14 ` Ulf Hansson
2017-01-20 8:01 ` Robert Jarzmik
2017-01-20 8:01 ` Robert Jarzmik
2017-01-20 8:27 ` Ulf Hansson
2017-01-20 8:27 ` Ulf Hansson
2017-01-20 19:34 ` Robert Jarzmik
2017-01-20 19:34 ` Robert Jarzmik
2017-01-22 10:25 ` Robert Jarzmik
2017-01-22 10:25 ` Robert Jarzmik
2017-01-24 7:57 ` Ulf Hansson
2017-01-24 7:57 ` Ulf Hansson
2017-01-24 16:34 ` Robert Jarzmik
2017-01-24 16:34 ` Robert Jarzmik
2017-01-13 13:14 ` [PATCH v3 02/15] ARM: davinci: " Ulf Hansson
2017-01-13 13:14 ` Ulf Hansson
2017-01-13 13:26 ` Sekhar Nori
2017-01-13 13:26 ` Sekhar Nori
2017-01-13 13:14 ` [PATCH v3 03/15] ARM: davinci: Don't rely on public mmc header to include interrupt.h Ulf Hansson
2017-01-13 13:14 ` Ulf Hansson
2017-01-13 13:38 ` Sekhar Nori
2017-01-13 13:38 ` Sekhar Nori
2017-01-13 13:14 ` [PATCH v3 04/15] MIPS: Alchemy: " Ulf Hansson
2017-01-13 13:14 ` Ulf Hansson
2017-01-17 14:50 ` Ralf Baechle
2017-01-13 13:14 ` [PATCH v3 05/15] mmc: core: First step in cleaning up public mmc header files Ulf Hansson
2017-01-16 2:54 ` Shawn Lin
2017-01-13 13:14 ` [PATCH v3 06/15] mmc: core: First step in cleaning up private " Ulf Hansson
2017-01-16 2:56 ` Shawn Lin
2017-01-13 13:14 ` [PATCH v3 07/15] mmc: core: Move public functions from core.h to private headers Ulf Hansson
2017-01-16 3:01 ` Shawn Lin
2017-01-17 15:07 ` Ulf Hansson
2017-01-13 13:14 ` [PATCH v3 08/15] mmc: core: Move some host specific public functions to host.h Ulf Hansson
2017-01-16 3:02 ` Shawn Lin
2017-01-13 13:14 ` [PATCH v3 09/15] mmc: core: Move erase/trim/discard defines from public core.h to mmc.h Ulf Hansson
2017-01-16 3:05 ` Shawn Lin
2017-01-17 15:06 ` Ulf Hansson
2017-01-13 13:14 ` [PATCH v3 10/15] mmc: core: Remove unused struct _mmc_csd from public mmc.h header Ulf Hansson
2017-01-16 3:07 ` Shawn Lin
2017-01-17 15:07 ` Ulf Hansson
2017-01-13 13:14 ` [PATCH v3 11/15] mmc: omap: Don't use mmc_card_present() when validating for inserted card Ulf Hansson
2017-01-13 13:14 ` [PATCH v3 12/15] mmc: vub300: " Ulf Hansson
2017-01-13 13:14 ` [PATCH v3 13/15] mmc: core: Move public functions from card.h to private headers Ulf Hansson
2017-01-16 3:10 ` Shawn Lin
2017-01-13 13:14 ` [PATCH v3 14/15] mmc: core: Move public functions from host.h " Ulf Hansson
2017-01-16 3:14 ` Shawn Lin
2017-01-13 13:14 ` [PATCH v3 15/15] mmc: core: Don't use extern declarations of public mmc functions Ulf Hansson
2017-01-16 3:16 ` Shawn Lin [this message]
2017-01-17 15:08 ` [PATCH v3 00/15] mmc: core: A start to slim down public mmc headers Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fef6372-ee5e-bcae-1d5f-199b73100a68@rock-chips.com \
--to=shawn.lin@rock-chips.com \
--cc=adrian.hunter@intel.com \
--cc=jh80.chung@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.