From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758243AbcGKKTi (ORCPT ); Mon, 11 Jul 2016 06:19:38 -0400 Received: from ozlabs.org ([103.22.144.67]:55551 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753501AbcGKKTg (ORCPT ); Mon, 11 Jul 2016 06:19:36 -0400 X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 8c6a0a1f4041f19559538649e0b9f3d9224b03a8 In-Reply-To: <146602104462.23192.4267928292361711364.stgit@bahia.lan> To: Greg Kurz From: Michael Ellerman Cc: linux-kernel@vger.kernel.org, qemu-ppc@nongnu.org, Paul Mackerras , linuxppc-dev@lists.ozlabs.org, David Gibson Subject: Re: [v2] powerpc/pseries: start rtasd before PCI probing Message-Id: <3rp1Ky5q41z9t10@ozlabs.org> Date: Mon, 11 Jul 2016 20:19:34 +1000 (AEST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2016-15-06 at 20:26:41 UTC, Greg Kurz wrote: > A strange behaviour is observed when comparing PCI hotplug in QEMU, between > x86 and pseries. If you consider the following steps: > - start a VM > - add a PCI device via the QEMU monitor before the rtasd has started (for > example starting the VM in paused state, or hotplug during FW or boot > loader) > - resume the VM execution > > The x86 kernel detects the PCI device, but the pseries one does not. > > This happens because the rtasd kernel worker is currently started under > device_initcall, while PCI probing happens earlier under subsys_initcall. > > As a consequence, if we have a pending RTAS event at boot time, a message > is printed and the event is dropped. > > This patch moves all the initialization of rtasd to arch_initcall, which is > run before subsys_call: this way, logging_enabled is true when the RTAS > event pops up and it is not lost anymore. > > The proc fs bits stay at device_initcall because they cannot be run before > fs_initcall. > > Signed-off-by: Greg Kurz Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/8c6a0a1f4041f19559538649e0 cheers