From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Russell Currey <ruscur@russell.cc>, linuxppc-dev@lists.ozlabs.org
Cc: aik@ozlabs.ru, Russell Currey <ruscur@russell.cc>
Subject: Re: powernv/pci: Fix m64 checks for SR-IOV and window alignment
Date: Sun, 25 Sep 2016 13:33:26 +1000 (AEST) [thread overview]
Message-ID: <3shXkH00dPz9srZ@ozlabs.org> (raw)
In-Reply-To: <20160914063717.2673-1-ruscur@russell.cc>
On Wed, 2016-14-09 at 06:37:17 UTC, Russell Currey wrote:
> Commit 5958d19a143e checks for prefetchable m64 BARs by comparing the
> addresses instead of using resource flags. This broke SR-IOV as the m64
> check in pnv_pci_ioda_fixup_iov_resources() fails.
>
> The condition in pnv_pci_window_alignment() also changed to checking
> only IORESOURCE_MEM_64 instead of both IORESOURCE_MEM_64 and
> IORESOURCE_PREFETCH.
>
> Revert these cases to the previous behaviour, adding a new helper function
> to do so. This is named pnv_pci_is_m64_flags() to make it clear this
> function is only looking at resource flags and should not be relied on for
> non-SRIOV resources.
>
> Fixes: 5958d19a143e ("Fix incorrect PE reservation attempt on some 64-bit BARs")
> Reported-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> Signed-off-by: Russell Currey <ruscur@russell.cc>
> Tested-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/b79331a5eb9f96e4dfd2169745
cheers
prev parent reply other threads:[~2016-09-25 3:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 6:37 [PATCH] powernv/pci: Fix m64 checks for SR-IOV and window alignment Russell Currey
2016-09-14 7:27 ` Alexey Kardashevskiy
2016-09-14 7:51 ` Benjamin Herrenschmidt
2016-09-14 11:30 ` Gavin Shan
2016-09-19 6:37 ` Russell Currey
2016-09-19 10:45 ` Benjamin Herrenschmidt
2016-09-25 3:33 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3shXkH00dPz9srZ@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=aik@ozlabs.ru \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=ruscur@russell.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.