From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Anton Blanchard <anton@ozlabs.org>,
benh@kernel.crashing.org, paulus@samba.org
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: powerpc: Avoid taking a data miss on every userspace instruction miss
Date: Thu, 6 Apr 2017 23:06:03 +1000 (AEST) [thread overview]
Message-ID: <3vzNHv6zMZz9s9c@ozlabs.org> (raw)
In-Reply-To: <20170403064102.23245-1-anton@ozlabs.org>
On Mon, 2017-04-03 at 06:41:02 UTC, Anton Blanchard wrote:
> From: Anton Blanchard <anton@samba.org>
>
> Early on in do_page_fault() we call store_updates_sp(), regardless of
> the type of exception. For an instruction miss this doesn't make
> sense, because we only use this information to detect if a data miss
> is the result of a stack expansion instruction or not.
>
> Worse still, it results in a data miss within every userspace
> instruction miss handler, because we try and load the very instruction
> we are about to install a pte for!
>
> A simple exec microbenchmark runs 6% faster on POWER8 with this fix:
>
> #include <stdlib.h>
> #include <stdio.h>
> #include <unistd.h>
>
> int main(int argc, char *argv[])
> {
> unsigned long left = atol(argv[1]);
> char leftstr[16];
>
> if (left-- == 0)
> return 0;
>
> sprintf(leftstr, "%ld", left);
> execlp(argv[0], argv[0], leftstr, NULL);
> perror("exec failed\n");
>
> return 0;
> }
>
> Pass the number of iterations on the command line (eg 10000) and time
> how long it takes to execute.
>
> Signed-off-by: Anton Blanchard <anton@samba.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/a7a9dcd882a67b68568868b988289f
cheers
next prev parent reply other threads:[~2017-04-06 13:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 6:41 [PATCH] powerpc: Avoid taking a data miss on every userspace instruction miss Anton Blanchard
2017-04-03 18:55 ` LEROY Christophe
2017-04-03 22:00 ` Anton Blanchard
2017-04-12 16:15 ` Christophe LEROY
2017-04-13 10:22 ` Michael Ellerman
2017-04-06 13:06 ` Michael Ellerman [this message]
2017-04-13 1:16 ` Balbir Singh
2017-04-13 1:29 ` Anton Blanchard
2017-04-13 10:24 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3vzNHv6zMZz9s9c@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=anton@ozlabs.org \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.