From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753058AbdF2MV1 (ORCPT ); Thu, 29 Jun 2017 08:21:27 -0400 Received: from ozlabs.org ([103.22.144.67]:34365 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752920AbdF2MVT (ORCPT ); Thu, 29 Jun 2017 08:21:19 -0400 X-powerpc-patch-notification: thanks X-powerpc-patch-commit: adeb8667eaf5f00b5a7f0cede680cda078e8424b In-Reply-To: <20170615185418.13980-17-javier@dowhile0.org> To: Javier Martinez Canillas , linux-kernel@vger.kernel.org From: Michael Ellerman Cc: Mark Rutland , Rob Herring , devicetree@vger.kernel.org, Wolfram Sang , Rob Herring , Paul Mackerras , Javier Martinez Canillas , linuxppc-dev@lists.ozlabs.org Subject: Re: [RESEND, v5, 16/16] powerpc/44x: Add generic compatible string for I2C EEPROM Message-Id: <3wyzKS5H8Rz9s3T@ozlabs.org> Date: Thu, 29 Jun 2017 22:21:16 +1000 (AEST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-06-15 at 18:54:18 UTC, Javier Martinez Canillas wrote: > The at24 driver allows to register I2C EEPROM chips using different vendor > and devices, but the I2C subsystem does not take the vendor into account > when matching using the I2C table since it only has device entries. > > But when matching using an OF table, both the vendor and device has to be > taken into account so the driver defines only a set of compatible strings > using the "atmel" vendor as a generic fallback for compatible I2C devices. > > So add this generic fallback to the device node compatible string to make > the device to match the driver using the OF device ID table. > > Signed-off-by: Javier Martinez Canillas Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/adeb8667eaf5f00b5a7f0cede680cd cheers From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Ellerman Subject: Re: [RESEND, v5, 16/16] powerpc/44x: Add generic compatible string for I2C EEPROM Date: Thu, 29 Jun 2017 22:21:16 +1000 (AEST) Message-ID: <3wyzKS5H8Rz9s3T@ozlabs.org> References: <20170615185418.13980-17-javier@dowhile0.org> Return-path: In-Reply-To: <20170615185418.13980-17-javier@dowhile0.org> Sender: linux-kernel-owner@vger.kernel.org To: linux-kernel@vger.kernel.org Cc: Mark Rutland , Rob Herring , devicetree@vger.kernel.org, Wolfram Sang , Rob Herring , Paul Mackerras , Javier Martinez Canillas , linuxppc-dev@lists.ozlabs.org List-Id: devicetree@vger.kernel.org On Thu, 2017-06-15 at 18:54:18 UTC, Javier Martinez Canillas wrote: > The at24 driver allows to register I2C EEPROM chips using different vendor > and devices, but the I2C subsystem does not take the vendor into account > when matching using the I2C table since it only has device entries. > > But when matching using an OF table, both the vendor and device has to be > taken into account so the driver defines only a set of compatible strings > using the "atmel" vendor as a generic fallback for compatible I2C devices. > > So add this generic fallback to the device node compatible string to make > the device to match the driver using the OF device ID table. > > Signed-off-by: Javier Martinez Canillas Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/adeb8667eaf5f00b5a7f0cede680cd cheers