All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Javier Carrasco <javier.carrasco@wolfvision.net>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Abdel Alkuor <abdelalkuor@geotab.com>,
	linux-usb@vger.kernel.org,  linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] usb: typec: tipd: rely on i2c_get_match_data()
Date: Mon, 29 Apr 2024 19:35:52 +0300	[thread overview]
Message-ID: <3xo5l7b5ushwkpq7tfmic7eurg624sd6f47v7fobmawtq4ai4w@qnbrumzv5nha> (raw)
In-Reply-To: <20240429-tps6598x_fix_event_handling-v3-3-4e8e58dce489@wolfvision.net>

On Mon, Apr 29, 2024 at 03:35:59PM +0200, Javier Carrasco wrote:
> The first thing i2c_get_match_data() does is calling
> device_get_match_data(), which already checks if there is a fwnode.
> 
> Remove explicit usage of device_get_match_data() as it is already
> included in i2c_get_match_data().
> 
> Signed-off-by: Javier Carrasco <javier.carrasco@wolfvision.net>
> ---
>  drivers/usb/typec/tipd/core.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>


-- 
With best wishes
Dmitry

  reply	other threads:[~2024-04-29 16:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-29 13:35 [PATCH v3 0/3] usb: typec: tipd: fix event checking in interrupt service routines Javier Carrasco
2024-04-29 13:35 ` [PATCH v3 1/3] usb: typec: tipd: fix event checking for tps25750 Javier Carrasco
2024-04-29 13:35 ` [PATCH v3 2/3] usb: typec: tipd: fix event checking for tps6598x Javier Carrasco
2024-04-29 13:35 ` [PATCH v3 3/3] usb: typec: tipd: rely on i2c_get_match_data() Javier Carrasco
2024-04-29 16:35   ` Dmitry Baryshkov [this message]
2024-05-06  8:29   ` Heikki Krogerus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3xo5l7b5ushwkpq7tfmic7eurg624sd6f47v7fobmawtq4ai4w@qnbrumzv5nha \
    --to=dmitry.baryshkov@linaro.org \
    --cc=abdelalkuor@geotab.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=javier.carrasco@wolfvision.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.